From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF347C352BE for ; Fri, 17 Apr 2020 11:29:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B98B9207FC for ; Fri, 17 Apr 2020 11:29:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UuOfXI5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730377AbgDQL3p (ORCPT ); Fri, 17 Apr 2020 07:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730324AbgDQL3p (ORCPT ); Fri, 17 Apr 2020 07:29:45 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B26C061A0F for ; Fri, 17 Apr 2020 04:29:45 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id t189so931497vst.7 for ; Fri, 17 Apr 2020 04:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lc+0dA5ZQ6U/TmJnVIFeGMJ1UgmxFTvQYOdMP2cGglY=; b=UuOfXI5pPysHol9zXgk317NJuZvCfQiXWDHh5nA1sEItDgTUCsp4xF/1omvUhOEakt ULf37ERYsiG1pKtq4hkc6WS8i1WkCjzKIUdXT1NxEULrCnEbEZX3TWIJzCWJlo0fHYxh frrHJXWGFayKHUcS6NuATF30wpb41eWLL6wYk8LnNVhEJiQJ9YYWHvpYdH710VbJgUMg mGFbalwNVkD2CP6jJ8GUznERRygLYYEjEAm4UQSUdC0GkAC1WPRnLkFHl7L25Krhi9ap VC1fh5Y4Nfy434MpX8ah2yd/isxal1+Lwk1/hKcJz/DSkhLpWCjFlVp5RkRZM5+v3WvK ocpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lc+0dA5ZQ6U/TmJnVIFeGMJ1UgmxFTvQYOdMP2cGglY=; b=P+G9slNq9RGjI5eTRQqUg7md7p5WgsrSdPwoFNd0kaWWcAxF79O3cAQKe6bsgFiDvf 0DFaGs0oBul6/cJN60eNhQvAew6tBkMZqS+uhwcLCl6j2WPq4pR8+boiBPplA95UTeEd sX5h15WCIJNj2Y5Ko3BkroetIfjFESJrgVm76jVB0b3Bh0tKjaJ8Gn/Lrzj5NFtbL6N+ 5npw5dR+DQBG4L87iaxjyIh5o9EnRo/8gSi+98VE/wediO7Mq3ngmkod8x09NhSqeq9Z HTSTfMCDYQbjE0asfezXaRHJsfb+dWgThAICsPZBn0vPXJOTXcblN86vh++McC/9M2BG 3T7Q== X-Gm-Message-State: AGi0Pubi7cdfNcZJAPyQyQW9cUahdmIVqOII5jns3SFnhaSiFyxsL+no 9yzPY+xBbFuzcXqSs+Yhi9MSOvw7Ukbn3PaqM2bzeA== X-Google-Smtp-Source: APiQypIOp3J008s/bXB9WKJub9sYBgZQSDtFNy6ifDOoslHH7Jbc679wSfxiWRv9bj/JvDoEvcOEy6Gs///EOUjlB+g= X-Received: by 2002:a05:6102:72d:: with SMTP id u13mr1662810vsg.35.1587122984277; Fri, 17 Apr 2020 04:29:44 -0700 (PDT) MIME-Version: 1.0 References: <20200410145643.630b0731@xhacker.debian> In-Reply-To: <20200410145643.630b0731@xhacker.debian> From: Ulf Hansson Date: Fri, 17 Apr 2020 13:29:08 +0200 Message-ID: Subject: Re: [PATCH] mmc: sd: use HIGH_SPEED_BUS_SPEED in mmc_sd_switch_hs() To: Jisheng Zhang Cc: "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Apr 2020 at 08:57, Jisheng Zhang wrote: > > Use the well defined HIGH_SPEED_BUS_SPEED macro in mmc_sd_switch_hs() > to make code more readable. > > Signed-off-by: Jisheng Zhang Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/core/sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c > index 76c7add367d5..43de3190d718 100644 > --- a/drivers/mmc/core/sd.c > +++ b/drivers/mmc/core/sd.c > @@ -376,11 +376,11 @@ int mmc_sd_switch_hs(struct mmc_card *card) > if (!status) > return -ENOMEM; > > - err = mmc_sd_switch(card, 1, 0, 1, status); > + err = mmc_sd_switch(card, 1, 0, HIGH_SPEED_BUS_SPEED, status); > if (err) > goto out; > > - if ((status[16] & 0xF) != 1) { > + if ((status[16] & 0xF) != HIGH_SPEED_BUS_SPEED) { > pr_warn("%s: Problem switching card into high-speed mode!\n", > mmc_hostname(card->host)); > err = 0; > -- > 2.26.0 >