From: Ulf Hansson <ulf.hansson@linaro.org>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux USB List <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
Date: Thu, 6 Dec 2018 09:57:40 +0100 [thread overview]
Message-ID: <CAPDyKFpoNY_zvX6dahdFEutYryxPSWAV0H_9tWsVkvgUbsvvzA@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFpHzERzE4T-AExwHAbhzrbxuSLy5cg0et24wzfbOZNw3Q@mail.gmail.com>
On Fri, 23 Nov 2018 at 13:21, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng <kai.heng.feng@canonical.com> wrote:
> >
> > Hi Ulf,
> >
> > > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@natalenko.name> wrote:
> > >
> > >> This is based on Ulf's work [1] [2].
> > >> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> > >> platforms and ~1.5W on AMD platforms.
> > >> [1] https://patchwork.kernel.org/patch/10440583/
> > >> [2] https://patchwork.kernel.org/patch/10445725/
> > >
> > > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> >
> > Do you think this series is ready to be merged to v4.20?
>
> I have had a brief look at the latest version a while ago, looked
> good. However, allow a few more days before I can give it my final
> blessing.
>
> BTW. We need to figure out what path to route the changes through. I
> can pick it via my mmc tree, unless someone object to that.
Okay, so I have picked up the patches and applied them to my next
branch to my mmc tree. While doing that, I have also added Oleksandr's
tested-by tag for all patches, including the four mmc patches. I also
added your tested-by tags to the the four mmc patches.
Finally I made little cosmetic change to last patch in this series,
which was dropping the surrounding #ifdef CONFIG_PM while do the
assignment of .driver.pm to &rtsx_usb_ms_pm_ops, as that isn't needed.
If anybody have any objections, please tell me.
Kind regards
Uffe
next prev parent reply other threads:[~2018-12-06 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<20181105084506.6476-1-kai.heng.feng@canonical.com>
2018-11-08 12:17 ` [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card Oleksandr Natalenko
2018-11-23 6:06 ` Kai Heng Feng
2018-11-23 12:21 ` Ulf Hansson
2018-12-06 8:57 ` Ulf Hansson [this message]
2018-11-05 8:45 Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpoNY_zvX6dahdFEutYryxPSWAV0H_9tWsVkvgUbsvvzA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).