From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD78C4332F for ; Wed, 20 Oct 2021 14:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8ADE611B0 for ; Wed, 20 Oct 2021 14:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbhJTOcu (ORCPT ); Wed, 20 Oct 2021 10:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbhJTOcg (ORCPT ); Wed, 20 Oct 2021 10:32:36 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB48C06176A for ; Wed, 20 Oct 2021 07:30:22 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id i24so15389627lfj.13 for ; Wed, 20 Oct 2021 07:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=V8w9KrLOh1e4/GeU4pCFQml0fcDuxEzceReSFQbl/RY=; b=Z4SbQud7ZO2doXmNbDxU8eh364WpB+CytVG+jjq/n2wOGTwGgEyHbkVSFNxfBA1v5K Tez31O/2/krC7zuzCiFYCeyyVGeTTfK9iTRzgdFEKuYsrF0upefHM0JNNFfoFX++j9Yt ygq/expCumks7h7y+U2H1zsz3Svs5/gzVwsAqw/ljPpbFiJOwuUOQHtHdJPY4gaDaTRo o3Lx0zImErdtRXIBOe7xQwqWqo+KFQ0ow1EvsMXjlPl3H2ZDEyO6r45EEAjJFNOYj0+x 1UkBmJewQAMB1n8URyzu9DIcA2Xb4nzwxd9qfvX3rKedFfrNtErMbJnbJVQfYMGUeBw7 gbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V8w9KrLOh1e4/GeU4pCFQml0fcDuxEzceReSFQbl/RY=; b=gz+XvAAKxIgGj8s2CGk0/hWj5auVdJa5eMeze34jocQTp0rRGNWbjZnhLpGivEg9QI Zp2Agoho3/oTo24Dybd4tMA1XA8v/RAaSnFK0i/Nc/tc9BrGq+GiXSyxz2rsh7R59JYs REOqzzOkZcM0qoinrNZith2EyGqsQ7gSC6BspoVOrAya6YhNqkm5jZFupN6tM3Itjv3Q IrFip78U4H16SrZMsPVfCT0Fk0JQXhYR/aghg8RAqsEoHaZ4CUh05pEdOFZAR8QqL0Dk HbRTsLnR0qWxAyriSQcT/+TK4ktM7wgVSoPQW8cdPiwXezlPXeD7FAHBLkasXQ7F1LRO i0Aw== X-Gm-Message-State: AOAM533QteFaKPCiOZQGyR8cfb9O4MWReKg6C4oyQ+//TPlMlgqu1x+3 g4UdkLuNp4ga2sjG7gjVKEWrH0H3/kXHNg85PVA9P3e4nVd/JA== X-Google-Smtp-Source: ABdhPJyiRYwjpNbimgCBc8Bb0ImqExuF52wcmQN7YkfkIuNEmX2BOdjiQfUP3MJSXgo9cLEPYL8sBG21S/UfXH7Bx/w= X-Received: by 2002:ac2:5e3c:: with SMTP id o28mr135613lfg.184.1634740220385; Wed, 20 Oct 2021 07:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20211014143031.1313783-1-Jerome.Pouiller@silabs.com> <20211014143031.1313783-3-Jerome.Pouiller@silabs.com> In-Reply-To: <20211014143031.1313783-3-Jerome.Pouiller@silabs.com> From: Ulf Hansson Date: Wed, 20 Oct 2021 16:29:44 +0200 Message-ID: Subject: Re: [RFC PATCH 2/2] mmc: allow to match the device tree to apply quirks To: Jerome Pouiller Cc: linux-mmc , Linux Kernel Mailing List , linux-wireless , Kalle Valo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Oct 2021 at 16:30, Jerome Pouiller wrote: > > From: J=C3=A9r=C3=B4me Pouiller > > MMC subsystem provides a way to apply quirks when a device match some > properties (VID, PID, etc...) Unfortunately, some SDIO devices does not > comply with the SDIO specification and does not provide reliable VID/PID > (eg. Silabs WF200). > > So, the drivers for these devices rely on device tree to identify the > device. > > This patch allows the MMC to also rely on the device tree to apply a > quirk. > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > --- > drivers/mmc/core/card.h | 3 +++ > drivers/mmc/core/quirks.h | 18 ++++++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h > index 7bd392d55cfa..2f73f8567e14 100644 > --- a/drivers/mmc/core/card.h > +++ b/drivers/mmc/core/card.h > @@ -59,6 +59,9 @@ struct mmc_fixup { > /* for MMC cards */ > unsigned int ext_csd_rev; > > + /* Match against functions declared in device tree */ > + const char *const *of_compatible; const char is probably sufficient. > + > void (*vendor_fixup)(struct mmc_card *card, int data); > int data; > }; > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h > index c7ef2d14b359..ef368386e711 100644 > --- a/drivers/mmc/core/quirks.h > +++ b/drivers/mmc/core/quirks.h > @@ -10,6 +10,7 @@ > * > */ > > +#include > #include > > #include "card.h" > @@ -145,6 +146,20 @@ static const struct mmc_fixup __maybe_unused sdio_fi= xup_methods[] =3D { > END_FIXUP > }; > > +static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card, > + const char *const *compa= t_list) > +{ > + struct device_node *of_node; > + int i; > + > + for (i =3D 0; i < 7; i++) { We need to iterate up '8', to cover all functional devices. The function numbers are from 1->7, while we use '0' for the "mmc-card" compatible. > + of_node =3D mmc_of_find_child_device(card->host, i); > + if (of_node && of_device_compatible_match(of_node, compat= _list)) > + return true; > + } Another option, which would avoid doing the iteration over and over again in mmc_of_find_child_device(), would be to simply do the parsing of the compatible in the child nodes, right here. In other words, just use for_each_child_of_node(). > + return false; > +} > + > static inline void mmc_fixup_device(struct mmc_card *card, > const struct mmc_fixup *table) > { > @@ -173,6 +188,9 @@ static inline void mmc_fixup_device(struct mmc_card *= card, > continue; > if (rev < f->rev_start || rev > f->rev_end) > continue; > + if (f->of_compatible !=3D NULL && > + !mmc_fixup_of_compatible_match(card, f->of_compatible= )) > + continue; > > dev_dbg(&card->dev, "calling %ps\n", f->vendor_fixup); > f->vendor_fixup(card, f->data); Kind regards Uffe