From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation
Date: Tue, 28 Aug 2018 13:41:35 +0200 [thread overview]
Message-ID: <CAPDyKFpwCx_jReqHBsDh-Sc6zb+4sQGtLsH8QcQ1L=0GUqrcYg@mail.gmail.com> (raw)
In-Reply-To: <20180828174534.00fb5e24@xhacker.debian>
On 28 August 2018 at 11:45, Jisheng Zhang <Jisheng.Zhang@synaptics.com> wrote:
> When using DMA, if the DMA addr spans 128MB boundary, we have to split
> the DMA transfer into two so that each one doesn't exceed the boundary.
>
> patch1 adds adma_table_cnt to struct sdhci_host so that driver can
> control the ADMA table count.
> patch2 introduces adma_write_desc() hook to struct sdhci_ops so that
> driver can override it.
> patch3 finally solves the 128MB boundary limitation.
>
> since v5:
> - use dma_get_required_mask() to calculate the extra adma_table_cnt
>
> since v4:
> - add Adrian's ack to patch 1 and patch 2
> - address Adrian's comment -- if the boundary is fine, we have to
> return after writing dma desc once; adma_table_cnt updating could
> make use of the fact that it's already initialized by the common
> sdhci code, we just need to tune.
>
> since v3:
> - s/adma_table_num/adma_table_cnt
> - add comment to adma_table_cnt
> - make the exported function name without the _
> - let sdhci_adma_write_desc() accept &desc param and set the new desc
> value
>
> since v2:
> - make use of "likely" to check (!len || BOUNDARY_OK(addr, len))
> - explicitly include <linux/sizes.h> for SZ_128M
>
> since v1:
> - fix BOUNDARY_OK macro if addr+len is aligned to 128MB
> - use DIV_ROUND_UP to cal extra desc num
> - fix !len for dwcmshc_adma_write_desc()
>
>
>
> Jisheng Zhang (3):
> mmc: sdhci: add adma_table_cnt member to struct sdhci_host
> mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops
> mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation
>
> drivers/mmc/host/sdhci-of-dwcmshc.c | 39 +++++++++++++++++++++
> drivers/mmc/host/sdhci.c | 54 +++++++++++++++++------------
> drivers/mmc/host/sdhci.h | 7 ++++
> 3 files changed, 78 insertions(+), 22 deletions(-)
>
> --
> 2.18.0
>
Applied for next, thanks!
Kind regards
Uffe
prev parent reply other threads:[~2018-08-28 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 9:45 [PATCH v6 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation Jisheng Zhang
2018-08-28 9:46 ` [PATCH v6 1/3] mmc: sdhci: add adma_table_cnt member to struct sdhci_host Jisheng Zhang
2018-08-28 9:47 ` [PATCH v6 2/3] mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops Jisheng Zhang
2018-08-28 9:48 ` [PATCH v6 3/3] mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation Jisheng Zhang
2018-08-28 10:47 ` Adrian Hunter
2018-08-28 11:41 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpwCx_jReqHBsDh-Sc6zb+4sQGtLsH8QcQ1L=0GUqrcYg@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).