From: Ulf Hansson <ulf.hansson@linaro.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yue Hu <huyue2@yulong.com>,
zbestahu@163.com
Subject: Re: [PATCH] mmc: mediatek: remove useless data parameter from msdc_data_xfer_next()
Date: Mon, 24 May 2021 16:10:36 +0200 [thread overview]
Message-ID: <CAPDyKFpyoEFt6CEwitD12sskG_YuLW=B+635_hyJ5gOLAzwYPQ@mail.gmail.com> (raw)
In-Reply-To: <20210517105432.1682-1-zbestahu@gmail.com>
On Mon, 17 May 2021 at 12:54, Yue Hu <zbestahu@gmail.com> wrote:
>
> From: Yue Hu <huyue2@yulong.com>
>
> We do not use the 'data' in msdc_data_xfer_next().
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index c4db944..4dfc246 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1347,8 +1347,7 @@ static void msdc_post_req(struct mmc_host *mmc, struct mmc_request *mrq,
> }
> }
>
> -static void msdc_data_xfer_next(struct msdc_host *host,
> - struct mmc_request *mrq, struct mmc_data *data)
> +static void msdc_data_xfer_next(struct msdc_host *host, struct mmc_request *mrq)
> {
> if (mmc_op_multi(mrq->cmd->opcode) && mrq->stop && !mrq->stop->error &&
> !mrq->sbc)
> @@ -1407,7 +1406,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> (int)data->error, data->bytes_xfered);
> }
>
> - msdc_data_xfer_next(host, mrq, data);
> + msdc_data_xfer_next(host, mrq);
> done = true;
> }
> return done;
> --
> 1.9.1
>
prev parent reply other threads:[~2021-05-24 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 10:54 [PATCH] mmc: mediatek: remove useless data parameter from msdc_data_xfer_next() Yue Hu
2021-05-24 14:10 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpyoEFt6CEwitD12sskG_YuLW=B+635_hyJ5gOLAzwYPQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=huyue2@yulong.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).