From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754683AbbJULBT (ORCPT ); Wed, 21 Oct 2015 07:01:19 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37343 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbbJULBS convert rfc822-to-8bit (ORCPT ); Wed, 21 Oct 2015 07:01:18 -0400 MIME-Version: 1.0 In-Reply-To: <56276832.9040006@arm.com> References: <1445422216-29375-1-git-send-email-sudeep.holla@arm.com> <1445422216-29375-11-git-send-email-sudeep.holla@arm.com> <5627672D.60108@atmel.com> <56276832.9040006@arm.com> Date: Wed, 21 Oct 2015 13:01:17 +0200 Message-ID: Subject: Re: [PATCH 10/19] ARM: dts: at91: replace gpio-key,wakeup with wakeup-source property From: Ulf Hansson To: Sudeep Holla Cc: Nicolas Ferre , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Alexandre Belloni , Jean-Christophe Plagniol-Villard Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 October 2015 at 12:25, Sudeep Holla wrote: > > > On 21/10/15 11:21, Nicolas Ferre wrote: >> >> Le 21/10/2015 12:10, Sudeep Holla a écrit : >>> >>> Though the keyboard driver for GPIO buttons(gpio-keys) will continue to >>> check for/support the legacy "gpio-key,wakeup" boolean property to >>> enable gpio buttons as wakeup source, "wakeup-source" is the new >>> standard binding. >>> >>> This patch replaces the legacy "gpio-key,wakeup" with the unified >>> "wakeup-source" property in order to avoid any futher copy-paste >>> duplication. >>> >>> Cc: Nicolas Ferre >> >> >> I'm not against this if the whole series goes further. >> Acked-by: Nicolas Ferre >> > > Thanks ! > >> I suspect that we would need to take this patch with us on the AT91 >> branches that would go to arm-soc. Is it the intentions? >> > > Yes that was my intention for splitting the patches per SoC group. > Many SoC maintainers prefer that. Hold on! All patches that changes the DT parsing to accept the "standardized wakeup-source" binding, need to be merged upstream before corresponding DTS changes. Therefore, I suggest we go for a two step approach, starting with changes affecting the DT parsing/documentation for various drivers/subsystem and perhaps we can reach 4.4 for these. Then the DTS changes can go in at any later point. Kind regards Uffe