From: Ulf Hansson <ulf.hansson@linaro.org>
To: Chaotian Jing <chaotian.jing@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
srv_heupstream <srv_heupstream@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 3/3] mmc: mmc: fix switch timeout issue caused by jiffies precision
Date: Tue, 21 Jun 2016 15:15:58 +0200 [thread overview]
Message-ID: <CAPDyKFqVW0sdwwvYoJcwZh=WKq1QzJREvt2y+rNWyA324J7p4A@mail.gmail.com> (raw)
In-Reply-To: <1463647662-27426-4-git-send-email-chaotian.jing@mediatek.com>
On 19 May 2016 at 10:47, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> with CONFIG_HZ=100, the precision of jiffies is 10ms, and the
> generic_cmd6_time of some card is also 10ms. then, may be current
> time is only 5ms, but already timed out caused by jiffies precision.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/core/mmc_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index 32de144..ad6e979 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -534,7 +534,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> timeout_ms = MMC_OPS_TIMEOUT_MS;
>
> /* Must check status to be sure of no errors. */
> - timeout = jiffies + msecs_to_jiffies(timeout_ms);
> + timeout = jiffies + msecs_to_jiffies(timeout_ms) + 1;
> do {
> /*
> * Due to the possibility of being preempted after
> --
> 1.8.1.1.dirty
>
prev parent reply other threads:[~2016-06-21 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 8:47 [PATCH v2] mmc: mmc: do not use CMD13 to get status after speed mode Chaotian Jing
2016-05-19 8:47 ` [PATCH 1/3] mmc: mmc: use ops->card_busy() to check card status in __mmc_switch() Chaotian Jing
2016-06-21 13:15 ` Ulf Hansson
2016-05-19 8:47 ` [PATCH 2/3] mmc: mmc: do not use CMD13 to get status after speed mode switch Chaotian Jing
2016-06-21 13:16 ` Ulf Hansson
2016-07-15 22:10 ` Bjorn Andersson
2016-07-18 12:50 ` Ulf Hansson
2016-07-18 13:38 ` Georgi Djakov
2016-07-19 9:31 ` Ulf Hansson
2016-07-19 16:27 ` Georgi Djakov
2016-05-19 8:47 ` [PATCH 3/3] mmc: mmc: fix switch timeout issue caused by jiffies precision Chaotian Jing
2016-06-21 13:15 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqVW0sdwwvYoJcwZh=WKq1QzJREvt2y+rNWyA324J7p4A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=chaotian.jing@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).