From: Ulf Hansson <ulf.hansson@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>, Mark Brown <broonie@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>, Sekhar Nori <nsekhar@ti.com>,
Russell King <linux@armlinux.org.uk>,
Ravikumar Kattekola <rk@ti.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/3] mmc: Add OMAP SDHCI driver
Date: Fri, 22 Sep 2017 11:45:11 +0200 [thread overview]
Message-ID: <CAPDyKFqWMy857LqpO2rPCb4TBQSU4oyFWbo8NunM_89OGsusvQ@mail.gmail.com> (raw)
In-Reply-To: <20170906114556.32532-1-kishon@ti.com>
On 6 September 2017 at 13:45, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> This is the first step in deprecating omap_hsmmc driver completely
> and moving to sdhci-omap driver which uses the sdhci library.
>
> This patch that adds a new SDHCI quirk "MMC_RSP_136" has already been
> merged and hence removed it in this revision.
>
> Apart from the quirk, sdhci-omap has it's own callbacks
> to set_clock (clock divider programming is different from generic sdhci)
> , set_power, set_bus_width, set_bus_mode and platform_send_init_74_clocks.
> These callback functions are implemented based on omap_hsmmc driver.
> Since sdhci-omap driver requires pbias regulator fixes to be present, I've
> sent them as part of this series.
>
> The sdhci-omap driver supports only the high speed mode and UHS/HS200
> mode will be added in a later series.
>
> It has been tested only in boards having DRA7 SoCs like dra7-evm, dra72-evm,
> am571x-idk, am572x-idk, am57xx-evm. (Tested only eMMC and SD.
> SDIO support will be added later). The plan is to fully convert DRA7
> SoC to use SDHCI driver and then convert other legacy platforms to use
> SDHCI.
>
> For sdhci-omap to be functional, the following tag should be merged (There
> are no compilation dependencies).
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
> tags/regulator-pbias-variants
Tag pulled.
>
> However the above regulator tag will impact omap_hsmmc driver. so [1]
> should be merged before everything else is merged.
>
> [1] -> https://lkml.org/lkml/2017/8/31/300
Applied.
>
> The patch to add config and dts changes to use sdhci-omap will be sent
> separately.
>
> Next Steps:
> *) Add UHS support to sdhci-omap
> *) Add SDIO support
> *) Add support for older TI platforms
>
> Changes from v3:
> *) removed omap_hsmmc and pbias-regulator patches from the series
> *) Fixed dt-binding documentation (remove '0x' in node name)
> *) stop clock if MMC core sends '0' in frequency
>
> Changes from v2:
> *) Rebased on git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
> *) Included a couple of patches from Ravikumar to fix pbias-regulator driver
> to support max-voltage of 3.3V. This is required for sdhci-omap driver.
> *) Create sdhci-omap as a new driver with MMC generic bindings and hence doesn't
> have bindings like ti,dual-volt added for omap-hsmmc. (Instead of
> ti,dual-volt, sdhci-omap driver uses the supported regulator voltage to
> set controller IO voltage capabilities).
> When omap-hsmmc driver is deprecated, support for these properties will
> be added to sdhci-omap.
> *) Fixed minor comments from Adrian).
>
> Changes from v1:
> *) Remove the quirks and instead use sdhci_omap specific callbacks for
> set_power, set_busmode etc.
> *) Add a patch from Adrian to tidy reading 136-bit responses
>
> I've also pushed the entire series along with dependent dt patches @
> https://github.com/kishon/linux-wip.git sdhci_v3 (in case someone
> wants to test)
>
> Kishon Vijay Abraham I (3):
> dt-bindings: sdhci-omap: Add bindings for the sdhci-omap controller
> mmc: sdhci-omap: Add OMAP SDHCI driver
> MAINTAINERS: Add TI OMAP SDHCI Maintainer
>
> .../devicetree/bindings/mmc/sdhci-omap.txt | 16 +
> MAINTAINERS | 6 +
> drivers/mmc/host/Kconfig | 12 +
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-omap.c | 607 +++++++++++++++++++++
> 5 files changed, 642 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> create mode 100644 drivers/mmc/host/sdhci-omap.c
>
> --
> 2.11.0
>
Thanks, everything applied/pulled for next! Great work!
Kind regards
Uffe
prev parent reply other threads:[~2017-09-22 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 11:45 [PATCH v3 0/3] mmc: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-09-06 11:45 ` [PATCH v3 1/3] dt-bindings: sdhci-omap: Add bindings for the sdhci-omap controller Kishon Vijay Abraham I
2017-09-13 17:26 ` Rob Herring
2017-09-06 11:45 ` [PATCH v3 2/3] mmc: sdhci-omap: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-09-14 7:26 ` Adrian Hunter
2017-09-06 11:45 ` [PATCH v3 3/3] MAINTAINERS: Add TI OMAP SDHCI Maintainer Kishon Vijay Abraham I
2017-09-07 16:30 ` [PATCH v3 0/3] mmc: Add OMAP SDHCI driver Tony Lindgren
2017-09-22 9:45 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqWMy857LqpO2rPCb4TBQSU4oyFWbo8NunM_89OGsusvQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=rk@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).