From: Ulf Hansson <ulf.hansson@linaro.org>
To: kehuanlin <chgokhl@gmail.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kehuanlin@fishsemi.com
Subject: Re: [PATCH] mmc: core: Mark mmc_host device with pm_runtime_no_callbacks
Date: Mon, 22 Mar 2021 11:25:23 +0100 [thread overview]
Message-ID: <CAPDyKFqXtKPngfnQZXXaF=rvqw0=nWzDc7P++QxNHPwGHHSxUA@mail.gmail.com> (raw)
In-Reply-To: <20210320045720.11872-1-chgokhl@gmail.com>
On Sat, 20 Mar 2021 at 05:57, kehuanlin <chgokhl@gmail.com> wrote:
>
> The rpm_resume() will call parent's resume callback recursively.
> Since mmc_host has no its own pm_runtime callbacks, the mmc devices
> may fail to resume (-ENOSYS in rpm_callback) sometimes. Mark mmc_host
> device with pm_runtime_no_callbacks can fix the issue.
Can you please elaborate more on this? What do you mean by "sometimes"?
More precisely, how do you trigger the rpm_callback() for mmc class
device to return -ENOSYS?
Don't get me wrong, the patch is fine, but I want to understand if it
actually solves a problem for you - or that it's better considered as
an optimization?
Kind regards
Uffe
>
> Signed-off-by: kehuanlin <chgokhl@gmail.com>
> ---
> drivers/mmc/core/host.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 9b89a91b6b47..177bebd9a6c4 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -15,6 +15,7 @@
> #include <linux/of.h>
> #include <linux/of_gpio.h>
> #include <linux/pagemap.h>
> +#include <linux/pm_runtime.h>
> #include <linux/pm_wakeup.h>
> #include <linux/export.h>
> #include <linux/leds.h>
> @@ -480,6 +481,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
> host->class_dev.class = &mmc_host_class;
> device_initialize(&host->class_dev);
> device_enable_async_suspend(&host->class_dev);
> + pm_runtime_no_callbacks(&host->class_dev);
>
> if (mmc_gpio_alloc(host)) {
> put_device(&host->class_dev);
> --
> 2.30.0
>
next prev parent reply other threads:[~2021-03-22 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 4:57 [PATCH] mmc: core: Mark mmc_host device with pm_runtime_no_callbacks kehuanlin
2021-03-22 10:25 ` Ulf Hansson [this message]
2021-03-23 10:49 ` hieagle
2021-03-23 14:00 ` Ulf Hansson
2021-05-07 11:38 ` Ulf Hansson
2021-05-26 12:18 ` Ulf Hansson
2021-06-21 1:38 ` hieagle
2021-06-21 9:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqXtKPngfnQZXXaF=rvqw0=nWzDc7P++QxNHPwGHHSxUA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=chgokhl@gmail.com \
--cc=kehuanlin@fishsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).