From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4447CC433FE for ; Thu, 17 Feb 2022 13:22:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240662AbiBQNW2 (ORCPT ); Thu, 17 Feb 2022 08:22:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiBQNWY (ORCPT ); Thu, 17 Feb 2022 08:22:24 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E9611C24 for ; Thu, 17 Feb 2022 05:22:10 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id g39so9910177lfv.10 for ; Thu, 17 Feb 2022 05:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9EY4j+oM8cn7vYGKtEF2tzpVEZCHYXK2JURuNjwopTw=; b=kduzqmfEqxbHDUgUXrQclE3JtdsvXWr75nwItngZZiLOGjCqOKwB2nRX1DL5iG6r7B /vGvr/TNVkOLxlBxhGRGCl3glo5yvXcxU6c7dd/s+CQoVhC14Tih0jGSWU7bKCV759N9 0QhAU4c57O7IqgStPym1LrlxNUBcMBHwnCrLGVfowoxhj3LHmQ07Z6lHOcOFTwJ5ISL/ QK37rfZo7xGmCvkAySuKzKu/KNjYL/UkuB//MdfnmWspBpYG2Fj9t/0Ww4Ttul5XwlqF CCSyBF/G3XjKV7/wQW/P3dAODzMdMCuMm6eTXefuxHtbkh2iP8gHRMv2RAWNFu9+TN1/ 8HLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9EY4j+oM8cn7vYGKtEF2tzpVEZCHYXK2JURuNjwopTw=; b=ltcHYsKzPm9ZPHK039nUkrBBmpR5ilfg0XMJ/tto/G49UQ5A3uJir6gwKhw805d22L NRWkURpf/itLEEDDzoORT8SgzYb0DYa07fvJrDsgJLauvkRY1H/d3zoS7y2QQ/L9CAUO rvJ2uuhns8tL0yxMMnQKmxgdgKIg5bCvosmojnvxXPlnlSWGqgDMHDwuTeM8tDD8B0MJ GdMPFiKLOzw63LK5cXBYJurLyJ88jEfYrrDFMTT/4X+bn9VwaVlMW/UwPQFurIsENGh9 OG9CCSp274IONpsAQHy+GBa+269FxDiheQ6vYC/gVPsCkORkdZ2vINpxCmfo4kEI7wyS LkLg== X-Gm-Message-State: AOAM531SGUQN3Ttvq01q4CnfS6OSSEvn3CszfTF9vRtzuRsezRnv8Iz2 u+9EXtX8a/cq/HZGkArJXVi2RSszOORiiKou5wOh+g== X-Google-Smtp-Source: ABdhPJzafXtiHCJClXvfvyVdYWtrkRnjKKOAEEPES+t05l2rICWKILqPgTORWYqMCiCakdRFT7+ODuiTJ6cX/7YSM/k= X-Received: by 2002:a05:6512:3604:b0:443:5d4b:3760 with SMTP id f4-20020a056512360400b004435d4b3760mr2018666lfs.358.1645104128404; Thu, 17 Feb 2022 05:22:08 -0800 (PST) MIME-Version: 1.0 References: <20220130210210.549877-1-daniel.lezcano@linaro.org> <20220130210210.549877-7-daniel.lezcano@linaro.org> In-Reply-To: <20220130210210.549877-7-daniel.lezcano@linaro.org> From: Ulf Hansson Date: Thu, 17 Feb 2022 14:21:31 +0100 Message-ID: Subject: Re: [PATCH v1 7/7] dtpm/soc/rk3399: Add the ability to unload the module To: Daniel Lezcano Cc: rjw@rjwysocki.net, heiko@sntech.de, lukasz.luba@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Jan 2022 at 22:02, Daniel Lezcano wrote: > > The dtpm hierarchy can now be removed with the > dtpm_destroy_hierarchy() function. Add the module_exit() callback so > the module can be unloaded by removing the previously created > hierarchy. > > Signed-off-by: Daniel Lezcano Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/soc/rockchip/dtpm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/soc/rockchip/dtpm.c b/drivers/soc/rockchip/dtpm.c > index ebebb748488b..5a23784b5221 100644 > --- a/drivers/soc/rockchip/dtpm.c > +++ b/drivers/soc/rockchip/dtpm.c > @@ -52,6 +52,12 @@ static int __init rockchip_dtpm_init(void) > } > module_init(rockchip_dtpm_init); > > +static void __exit rockchip_dtpm_exit(void) > +{ > + return dtpm_destroy_hierarchy(); > +} > +module_exit(rockchip_dtpm_exit); > + > MODULE_SOFTDEP("pre: panfrost cpufreq-dt"); > MODULE_DESCRIPTION("Rockchip DTPM driver"); > MODULE_LICENSE("GPL"); > -- > 2.25.1 >