From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932467AbdJ3LkM (ORCPT ); Mon, 30 Oct 2017 07:40:12 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:47177 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbdJ3LkJ (ORCPT ); Mon, 30 Oct 2017 07:40:09 -0400 X-Google-Smtp-Source: ABhQp+QDRSVquVsjnn4W2rjT2aNZxkJkV1NPErLlhGNx8CVpAJXVwNln6SrwL9Vpn7vQoMSBdJMpc3W/83/7eDTx//4= MIME-Version: 1.0 In-Reply-To: <20171012201118.23570-1-dianders@chromium.org> References: <20171012201118.23570-1-dianders@chromium.org> From: Ulf Hansson Date: Mon, 30 Oct 2017 12:40:08 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer To: Douglas Anderson , Jaehoon Chung Cc: Shawn Lin , Ziyuan Xu , Alexandru Stan , "open list:ARM/Rockchip SoC..." , Brian Norris , linux-samsung-soc , kernel@esmil.dk, "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12 October 2017 at 22:11, Douglas Anderson wrote: > Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for > broken command transfer over scheme"). I found a bunch of problems > with that patch, so this series attempts to solve some of them. > > This also fixes the DTO timer in some of the same ways even though I > haven't personally seen problems with the DTO timer. > > NOTE: this series has only been lighly tested so far. I can at least > reproduce the need for the CTO timer on one of my devices and so I can > confirm that part still works. As mentioned in the 3rd patch I also > ran the mmc_test kernel module on this and did manage to see the 3rd > patch doing something useful. > > Changes in v2: > - Removed extra "int i" > - Fix the DTO timeout calculation new for v2 > - Cleanup the DTO timer new for v2 > > Douglas Anderson (5): > mmc: dw_mmc: cancel the CTO timer after a voltage switch > mmc: dw_mmc: Fix the CTO timeout calculation > mmc: dw_mmc: Add locking to the CTO timer > mmc: dw_mmc: Fix the DTO timeout calculation > mmc: dw_mmc: Cleanup the DTO timer like the CTO one > > drivers/mmc/host/dw_mmc.c | 162 +++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 146 insertions(+), 16 deletions(-) > Douglas, Jaehoon, I decided to pick patch 1->4 for fixes and the patch 5 for next, that should help us to get them more tested, while Jaehoon is still catching up. I can add ack/drop patches for yet a couple of days this week. Kind regards Uffe