linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
	Niklas Cassel <niklas.cassel@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 01/10] PM / Domains: Rename genpd virtual devices as virt_dev
Date: Thu, 25 Oct 2018 12:54:32 +0200	[thread overview]
Message-ID: <CAPDyKFqb0kuZdpBeV2Uktd0gDXAg+v2p=a1vuRowj7f2zk1NOA@mail.gmail.com> (raw)
In-Reply-To: <d5f993001c97895d82bb68e246f6eaafce6dc795.1540446493.git.viresh.kumar@linaro.org>

On 25 October 2018 at 07:52, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> There are several struct device instances that genpd core handles. The
> most common one is the consumer device structure, which is named
> (correctly) as "dev" within genpd core. The second one is the genpd's
> device structure, referenced as genpd->dev. The third one is the virtual
> device structures created by the genpd core to represent the consumer
> device for multiple power domain case, currently named as genpd_dev. The
> naming of these virtual devices isn't very clear or readable and it
> looks more like the genpd->dev.
>
> Rename the virtual device instances within the genpd core as "virt_dev".
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Thanks, this make the code more clear!

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/domain.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 7f38a92b444a..fe9b0527b161 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2338,7 +2338,7 @@ EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
>  struct device *genpd_dev_pm_attach_by_id(struct device *dev,
>                                          unsigned int index)
>  {
> -       struct device *genpd_dev;
> +       struct device *virt_dev;
>         int num_domains;
>         int ret;
>
> @@ -2352,31 +2352,31 @@ struct device *genpd_dev_pm_attach_by_id(struct device *dev,
>                 return NULL;
>
>         /* Allocate and register device on the genpd bus. */
> -       genpd_dev = kzalloc(sizeof(*genpd_dev), GFP_KERNEL);
> -       if (!genpd_dev)
> +       virt_dev = kzalloc(sizeof(*virt_dev), GFP_KERNEL);
> +       if (!virt_dev)
>                 return ERR_PTR(-ENOMEM);
>
> -       dev_set_name(genpd_dev, "genpd:%u:%s", index, dev_name(dev));
> -       genpd_dev->bus = &genpd_bus_type;
> -       genpd_dev->release = genpd_release_dev;
> +       dev_set_name(virt_dev, "genpd:%u:%s", index, dev_name(dev));
> +       virt_dev->bus = &genpd_bus_type;
> +       virt_dev->release = genpd_release_dev;
>
> -       ret = device_register(genpd_dev);
> +       ret = device_register(virt_dev);
>         if (ret) {
> -               kfree(genpd_dev);
> +               kfree(virt_dev);
>                 return ERR_PTR(ret);
>         }
>
>         /* Try to attach the device to the PM domain at the specified index. */
> -       ret = __genpd_dev_pm_attach(genpd_dev, dev->of_node, index, false);
> +       ret = __genpd_dev_pm_attach(virt_dev, dev->of_node, index, false);
>         if (ret < 1) {
> -               device_unregister(genpd_dev);
> +               device_unregister(virt_dev);
>                 return ret ? ERR_PTR(ret) : NULL;
>         }
>
> -       pm_runtime_enable(genpd_dev);
> -       genpd_queue_power_off_work(dev_to_genpd(genpd_dev));
> +       pm_runtime_enable(virt_dev);
> +       genpd_queue_power_off_work(dev_to_genpd(virt_dev));
>
> -       return genpd_dev;
> +       return virt_dev;
>  }
>  EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_id);
>
> --
> 2.19.1.568.g152ad8e3369a
>

  reply	other threads:[~2018-10-25 10:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  5:52 [PATCH V3 00/10] OPP: Support multiple power-domains per device Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 01/10] PM / Domains: Rename genpd virtual devices as virt_dev Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson [this message]
2018-10-25  5:52 ` [PATCH V3 02/10] OPP: Identify and mark genpd OPP tables Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 03/10] OPP: Separate out custom OPP handler specific code Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 04/10] OPP: Populate required opp tables from "required-opps" property Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 05/10] OPP: Populate OPPs " Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 06/10] PM / Domains: Add genpd_opp_to_performance_state() Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson
2018-10-25  5:52 ` [PATCH V3 07/10] OPP: Add dev_pm_opp_{set|put}_genpd_virt_dev() helper Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson
2018-10-25  5:52 ` [PATCH V3 08/10] OPP: Configure all required OPPs Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson
2018-10-25  5:52 ` [PATCH V3 09/10] OPP: Rename and relocate of_genpd_opp_to_performance_state() Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson
2018-11-02  9:15   ` [PATCH V4 " Viresh Kumar
2018-10-25  5:52 ` [PATCH V3 10/10] OPP: Remove of_dev_pm_opp_find_required_opp() Viresh Kumar
2018-10-25 10:54   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFqb0kuZdpBeV2Uktd0gDXAg+v2p=a1vuRowj7f2zk1NOA@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=khilman@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=niklas.cassel@linaro.org \
    --cc=nm@ti.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --subject='Re: [PATCH V3 01/10] PM / Domains: Rename genpd virtual devices as virt_dev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).