From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Maulik Shah <mkshah@codeaurora.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Len Brown <len.brown@intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] PM: sleep: Fix runtime PM based cpuidle support
Date: Thu, 21 Oct 2021 20:49:09 +0200 [thread overview]
Message-ID: <CAPDyKFqdF0DptpLvp21yzDOOAbFiiDwSmWZCWa1Vt9KO3fz44A@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0iWxiH686bkZ3-mhKK0+F7f+wMWp8Adnjuk7BvdMywTww@mail.gmail.com>
[...]
> > The PM-runtime case should be addressed directly IMO, we only need to
> > figure out how to do that.
> >
> > I'm wondering how you are dealing with the case when user space
> > prevents pd_dev from suspending via sysfs, for that matter.
>
> Or what happens if rpm_suspend() returns -EAGAIN, because someone has
> started to resume the device right after its reference counter went
> down to 0.
That would mean that the pm_runtime_put_sync() call fails to runtime
suspend the device. In other words, the corresponding genpd stays
powered on, which prevents idle states from being selected by the
genpd governor.
So, yes, this should work fine.
>
> It looks to me like the problem is there regardless of the whole
> interference with system suspend.
I don't think so, but I may be overlooking some points.
Kind regards
Uffe
next prev parent reply other threads:[~2021-10-21 18:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 14:44 [PATCH 0/2] cpuidle: Fix runtime PM based cpuidle for s2idle Ulf Hansson
2021-09-29 14:44 ` [PATCH 1/2] cpuidle: Avoid calls to cpuidle_resume|pause() " Ulf Hansson
2021-10-06 10:22 ` Maulik Shah
2021-10-06 13:10 ` Ulf Hansson
2021-10-09 15:42 ` Rafael J. Wysocki
2021-10-09 15:39 ` Rafael J. Wysocki
2021-10-11 10:04 ` Ulf Hansson
2021-09-29 14:44 ` [PATCH 2/2] PM: sleep: Fix runtime PM based cpuidle support Ulf Hansson
2021-10-06 10:28 ` Maulik Shah
2021-10-20 18:18 ` Rafael J. Wysocki
2021-10-21 11:48 ` Ulf Hansson
2021-10-21 13:45 ` Rafael J. Wysocki
2021-10-21 14:04 ` Ulf Hansson
2021-10-21 15:09 ` Rafael J. Wysocki
2021-10-21 15:45 ` Rafael J. Wysocki
2021-10-21 16:28 ` Ulf Hansson
2021-10-21 16:41 ` Rafael J. Wysocki
2021-10-21 17:05 ` Rafael J. Wysocki
2021-10-21 18:49 ` Ulf Hansson [this message]
2021-10-21 18:36 ` Ulf Hansson
2021-10-21 16:16 ` Ulf Hansson
2021-10-21 16:33 ` Rafael J. Wysocki
2021-10-21 18:11 ` Ulf Hansson
2021-10-21 19:02 ` Rafael J. Wysocki
2021-10-21 19:56 ` Ulf Hansson
2021-10-22 9:15 ` Maulik Shah
2021-10-22 10:18 ` Ulf Hansson
2021-10-22 12:02 ` Rafael J. Wysocki
2021-10-22 12:56 ` Ulf Hansson
2021-10-22 13:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqdF0DptpLvp21yzDOOAbFiiDwSmWZCWa1Vt9KO3fz44A@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).