From: Ulf Hansson <ulf.hansson@linaro.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH 13/13] mmc: au1xmmc: switch to platform_get_irq
Date: Wed, 18 Dec 2019 15:01:43 +0100 [thread overview]
Message-ID: <CAPDyKFqeoefkTy7prJ=nKKh4NVdhtHfawxfsEYGyYZd6b3igrA@mail.gmail.com> (raw)
In-Reply-To: <20191215175120.3290-13-tiny.windzz@gmail.com>
- trimmed cc list (please do that also for any future submissions).
On Sun, 15 Dec 2019 at 18:51, Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Patch 1->13 applied for next, thanks!
Next time, please use a cover-letter when you send a series.
Kind regards
Uffe
> ---
> drivers/mmc/host/au1xmmc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
> index bc8aeb47a7b4..8823680ca42c 100644
> --- a/drivers/mmc/host/au1xmmc.c
> +++ b/drivers/mmc/host/au1xmmc.c
> @@ -984,12 +984,9 @@ static int au1xmmc_probe(struct platform_device *pdev)
> goto out2;
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!r) {
> - dev_err(&pdev->dev, "no IRQ defined\n");
> + host->irq = platform_get_irq(pdev, 0);
> + if (host->irq < 0)
> goto out3;
> - }
> - host->irq = r->start;
>
> mmc->ops = &au1xmmc_ops;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-12-18 14:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 17:51 [PATCH 01/13] mmc: sunxi-mmc: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-15 17:51 ` [PATCH 02/13] mmc: tmio: " Yangtao Li
2019-12-18 9:47 ` Wolfram Sang
2019-12-15 17:51 ` [PATCH 03/13] mmc: meson-mx-sdio: " Yangtao Li
2019-12-15 17:51 ` [PATCH 04/13] mmc: sdhci-s3c: " Yangtao Li
2019-12-15 17:51 ` [PATCH 05/13] mmc: sdhci-spear: " Yangtao Li
2019-12-15 17:51 ` [PATCH 06/13] mmc: sh_mmcif: " Yangtao Li
2019-12-18 9:49 ` Wolfram Sang
2019-12-15 17:51 ` [PATCH 07/13] mmc: sdhci_f_sdh30: " Yangtao Li
2019-12-15 17:51 ` [PATCH 08/13] mmc: sdhci_am654: " Yangtao Li
2019-12-15 17:51 ` [PATCH 09/13] mmc: sdhci-milbeaut: " Yangtao Li
2019-12-15 17:51 ` [PATCH 10/13] mmc: sdhci-msm: " Yangtao Li
2019-12-18 6:30 ` Bjorn Andersson
2019-12-18 14:01 ` Ulf Hansson
2019-12-15 17:51 ` [PATCH 11/13] mmc: mvsdio: " Yangtao Li
2019-12-15 17:51 ` [PATCH 12/13] mmc: mtk-sd: " Yangtao Li
2019-12-15 17:51 ` [PATCH 13/13] mmc: au1xmmc: switch to platform_get_irq Yangtao Li
2019-12-18 14:01 ` Ulf Hansson [this message]
2019-12-18 2:27 ` [PATCH 01/13] mmc: sunxi-mmc: convert to devm_platform_ioremap_resource Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqeoefkTy7prJ=nKKh4NVdhtHfawxfsEYGyYZd6b3igrA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).