From: Ulf Hansson <ulf.hansson@linaro.org>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Kishon <kishon@ti.com>, Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 2/4] mmc: sdhci-omap: Add variable to indicate host is tuning
Date: Mon, 19 Nov 2018 14:18:46 +0100 [thread overview]
Message-ID: <CAPDyKFqkscm9ZhJhk7SWFc_tmqqqXSx5_t2tzEL-DV6aE+Q=KA@mail.gmail.com> (raw)
In-Reply-To: <20181119111618.2745-3-faiz_abbas@ti.com>
On 19 November 2018 at 12:16, Faiz Abbas <faiz_abbas@ti.com> wrote:
> Add a variable in sdhc_omap_host to indicate whether a tuning
> operation is ongoing.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Please squash this into patch3 as it seems a bit silly to keep this a
separate change.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-omap.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 87138067e334..cfffcf58be3f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -115,6 +115,7 @@ struct sdhci_omap_host {
>
> struct pinctrl *pinctrl;
> struct pinctrl_state **pinctrl_state;
> + bool is_tuning;
> };
>
> static void sdhci_omap_start_clock(struct sdhci_omap_host *omap_host);
> @@ -318,6 +319,8 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode)
> */
> host->ier &= ~SDHCI_INT_DATA_CRC;
>
> + omap_host->is_tuning = true;
> +
> while (phase_delay <= MAX_PHASE_DELAY) {
> sdhci_omap_set_dll(omap_host, phase_delay);
>
> @@ -355,9 +358,12 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode)
> phase_delay = max_window + 4 * (max_len >> 1);
> sdhci_omap_set_dll(omap_host, phase_delay);
>
> + omap_host->is_tuning = false;
> +
> goto ret;
>
> tuning_error:
> + omap_host->is_tuning = false;
> dev_err(dev, "Tuning failed\n");
> sdhci_omap_disable_tuning(omap_host);
>
> --
> 2.19.1
>
next prev parent reply other threads:[~2018-11-19 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 11:16 [PATCH 0/4] Tuning Fixes for sdhci-omap Faiz Abbas
2018-11-19 11:16 ` [PATCH 1/4] mmc: sdhci-omap: Fix DCRC error handling during tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson
2018-11-20 7:28 ` Faiz Abbas
2018-11-20 4:53 ` Kishon Vijay Abraham I
2018-11-21 9:39 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 2/4] mmc: sdhci-omap: Add variable to indicate host is tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson [this message]
2018-11-20 12:58 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 3/4] mmc: sdhci-omap: Add platform specific reset callback Faiz Abbas
2018-11-20 5:00 ` Kishon Vijay Abraham I
2018-11-19 11:16 ` [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments Faiz Abbas
2018-11-20 5:01 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqkscm9ZhJhk7SWFc_tmqqqXSx5_t2tzEL-DV6aE+Q=KA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).