From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732FBC43331 for ; Mon, 11 Nov 2019 17:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 026DF214DB for ; Mon, 11 Nov 2019 17:28:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t5ZpWPML" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbfKKR2c (ORCPT ); Mon, 11 Nov 2019 12:28:32 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:45886 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbfKKR2b (ORCPT ); Mon, 11 Nov 2019 12:28:31 -0500 Received: by mail-vs1-f68.google.com with SMTP id n9so3880209vsa.12 for ; Mon, 11 Nov 2019 09:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1OTu7RzLc243iGue7chxiy8Vk2YRX4D1tgtKssbyxYs=; b=t5ZpWPMLeBDEvkNCdWobOXpY1rn8mKKbhlJAqH/nClIIPOo8xtotQlHbtDHya4Is2h oMEZKC6Qh/5PvNDFNmY7Qo0a3QcMJk8QVG0lTAlBXtjVdwYFZGnwxEfUmx0l/jfycAlA wQB0V12uNIgPHHMkZZzhcbKeXCUVhZeNQYZb9vvA6OAYGiQ1jyh3DqSXYUX4O4VUgcbM nntC2qRDQHoKCArmi5zgZ9chZOb3Z+WZDSz02rWVMpT8A+tmZWrPjxhJ990eCDT4/D7z 1KGN6yioFbYO0lWiOBt1hF/sQINuGYPnD6hUG9Ty9K/hpA13WopK8gW42j8mHxk+adXW OKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1OTu7RzLc243iGue7chxiy8Vk2YRX4D1tgtKssbyxYs=; b=UcVYousv/WuvVaBA7HPSFhxBNqdX6zkvp5y8EJ5FDGdoxZPmUZyPLUY0J0MxE1Chq+ PnALgX6M7YvqK/vrMkrc/DcGD2nqyFtwGdwy78owaI3SyDdZmb2eOrSLFyK2+PdH2iPi Oj/lQKRIDlPFo71MaMzdnYSd1ct9lrd0hzUUTllzlx8ZKU9niW549Ypk2cP6iKc//ov/ EXpzEpVmLKqgbJ+M9ZQiID1DqCge0P5+E053oX7xNYBZ/+4o/HoFOvBDTrODTrL1didr YghKwc76kSVfo6UMrpcZ86n9Cx6BaFMdyh5ybznVHIWX3RTkpOP22rLUEk3MNBVoI995 Avsw== X-Gm-Message-State: APjAAAXaRaAPxz9bieEiHW25fiAHWJ1xbZ9DizD3TC/ixwZLG/vcLx/h EfFI14QZODdHafiQ8WJImE0jOxTIYxETL4kzKALrFA== X-Google-Smtp-Source: APXvYqwilC07dl1RnIx5npEnNIV0hBMmZ1Z8YLoBy1QbElednuBWAi2IH+P4714/fpUNZRzKUbKdgOH1iwmWYFORaFA= X-Received: by 2002:a67:ef4e:: with SMTP id k14mr10817201vsr.165.1573493310523; Mon, 11 Nov 2019 09:28:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Mon, 11 Nov 2019 18:27:54 +0100 Message-ID: Subject: Re: arm64: dts: rockchip: Add SDR104 mode to SD-card I/F on rk3399-roc-pc To: Markus Reichl Cc: Rob Herring , Mark Rutland , Heiko Stuebner , Jagan Teki , DTML , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Nov 2019 at 15:13, Markus Reichl wrote: > > Add SDR104 capability and regulators to SD card node. > While at it, fix a typo in lcd pinctrl and remove two > undocumented bindings from pmic. > > Signed-off-by: Markus Reichl > --- > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 31 +++++++++++++++---- > 1 file changed, 25 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index 33df95e384b4..e86a6db54499 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -135,6 +135,20 @@ > vin-supply = <&vcc_1v8>; > }; > > + vcc3v0_sd: vcc3v0-sd { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc3v0_sd_en>; > + regulator-name = "vcc3v0_sd"; > + regulator-always-on; This looks odd. A GPIO regulator being always on? > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + vin-supply = <&vcc3v3_sys>; > + }; Assumes this powers an SDIO embedded card. Often those have a specific power sequence, just wanted to make sure the above are really sufficient? No delays or external clock needed? [...] Kind regards Uffe