From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD95C433DF for ; Mon, 24 Aug 2020 09:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E73632075B for ; Mon, 24 Aug 2020 09:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qn81eyst" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbgHXJwR (ORCPT ); Mon, 24 Aug 2020 05:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729568AbgHXJvT (ORCPT ); Mon, 24 Aug 2020 05:51:19 -0400 Received: from mail-ua1-x942.google.com (mail-ua1-x942.google.com [IPv6:2607:f8b0:4864:20::942]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54CF8C061797 for ; Mon, 24 Aug 2020 02:51:17 -0700 (PDT) Received: by mail-ua1-x942.google.com with SMTP id v20so2416131ual.4 for ; Mon, 24 Aug 2020 02:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lAijYwEhVki3ASVGSGr03ujQoKI91GWpC9DTd+zqR0A=; b=qn81eystRutEQfbCLxokhFYJd8I+U2gytbLbne7CogTPMGmSh08XyhDIgI/v2QToR+ kT+/d/FTJMHoVzz3GQRU0+WI6B5tzZ+g5lv9LH5R/ufdfMDth07OXvmKPldXy8R+wH7Z Aq5SkhxScTBiedB2/9jzUCfIpT/3HR3xNLXxDc8IhpGWJrhCkQwS1D8zEMM3mIUSJxFw 0URvOSFzKErG49kZ5jM9Tiv5+m03GAQWPQAfPQgRvgOFExOanVct6VSB0hB39pWPLrgl EJzFdUbXrjRm6hTYef8Xl2JLpe+7wSmFt0+AIvnNwINNSPhjO0CbUMGnZBxP5rfshhka ChRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lAijYwEhVki3ASVGSGr03ujQoKI91GWpC9DTd+zqR0A=; b=PaWsYSjNMkk9KoI1EXAahtJIJRsqCZm4Ckfcz07BlKJSH+UiExsuTdP6/W58Es/JuY HUnmKljHBhoSPIN+3/0laQDoi1HTbtMFkhRWxLcQDOp//zot/lzko+hBmp1fSGoFN2c6 EusRcrQO7vbhPATPULdwOH1vy1NNYSVaaOd8Ai/CyAo7Tx4m5o5lNnOz+bibRm1AnAxn oeGQPOJTVoEG4AKwWDLpBmBlF0KLOeZDwgKvb6QYc/L3t+9F2TkMFtolYTGlWvOmNJE5 Jedmz0Pl/ssF0FDyd1wHB6rhYTJAm50zxQw4Q4l++N6aYvFEqMVQ+90xdLthf2+jEEaN 42WQ== X-Gm-Message-State: AOAM530l/v3F+cfBDnYYuvYmNgSIujL+jRvhdZqwcG87JT8i8Nkhud1G m7TBmxqW37pLA1bQ9iRuZDYU8+IMRFI+oJ6W3Uqlzg== X-Google-Smtp-Source: ABdhPJzjncwbZlj5jNnq9VPppz4EGIptpW5meuYQu1QoZeXcpK4+nWbBg2mnjp49m9YA3c/5bJZ6ncdZPbElHbfd3mA= X-Received: by 2002:ab0:3114:: with SMTP id e20mr1857025ual.104.1598262675798; Mon, 24 Aug 2020 02:51:15 -0700 (PDT) MIME-Version: 1.0 References: <20200814014346.6496-1-wenbin.mei@mediatek.com> <20200814014346.6496-4-wenbin.mei@mediatek.com> In-Reply-To: <20200814014346.6496-4-wenbin.mei@mediatek.com> From: Ulf Hansson Date: Mon, 24 Aug 2020 11:50:38 +0200 Message-ID: Subject: Re: [v5,3/3] mmc: mediatek: add optional module reset property To: Wenbin Mei Cc: Rob Herring , Chaotian Jing , Matthias Brugger , Philipp Zabel , "linux-mmc@vger.kernel.org" , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , srv_heupstream , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Aug 2020 at 03:44, Wenbin Mei wrote: > > This patch fixs eMMC-Access on mt7622/Bpi-64. > Before we got these Errors on mounting eMMC ion R64: > [ 48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE) > flags 0x800 phys_seg 1 prio class 0 > [ 48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write > > This patch adds a optional reset management for msdc. > Sometimes the bootloader does not bring msdc register > to default state, so need reset the msdc controller. > > Cc: # v5.4+ > Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC") > Signed-off-by: Wenbin Mei > Reviewed-by: Philipp Zabel > Tested-by: Frank Wunderlich Applied for fixes, but needed to resolve a conflict when applying, thanks! > --- > drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 39e7fc54c438..fc97d5bf3a20 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -434,6 +435,7 @@ struct msdc_host { > struct msdc_save_para save_para; /* used when gate HCLK */ > struct msdc_tune_para def_tune_para; /* default tune setting */ > struct msdc_tune_para saved_tune_para; /* tune result of CMD21/CMD19 */ > + struct reset_control *reset; I moved this a couple of lines above, since this conflicts with later changes for mtk-sd. [...] Kind regards Uffe