From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB4AAC433DB for ; Wed, 31 Mar 2021 09:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C122619B9 for ; Wed, 31 Mar 2021 09:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234590AbhCaJbL (ORCPT ); Wed, 31 Mar 2021 05:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234542AbhCaJbA (ORCPT ); Wed, 31 Mar 2021 05:31:00 -0400 Received: from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com [IPv6:2607:f8b0:4864:20::a2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC24C06174A for ; Wed, 31 Mar 2021 02:31:00 -0700 (PDT) Received: by mail-vk1-xa2d.google.com with SMTP id o4so4201653vka.12 for ; Wed, 31 Mar 2021 02:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B206DLBs5pNzOwU/8DxV6d6XKC69s62Sja9FabTzXRo=; b=rd5DW/59utrI6rSPrKyItHnZ8jcE7fbzh9HSRXXS+BFXi6Uzs9L3FSenKBvw4p/DmM WZjqXbOYlMzcgJZGa5lQmfNGtRqkgX0UtFoL3RV2cn1HzKuI5/3ew6783VTrfTK3zHcr gfthtb2mIrkLucKN9IShoh/R/To/dTaMGl32A8yDorl7xw8xXRJ7goDshqoYlOqAK6iA YRIMC43MfLQMY2CJgmDyfeJgKKUbplul9i+bDorUKe9BLt1SsEVwJByDahBaObXU2E8M tKMVw3TtxABveMyyRhB1KP+OwFBdTQUYsq0vBWiDMLjMKiHXRSTHcTntkKJgVc0PL8VS BR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B206DLBs5pNzOwU/8DxV6d6XKC69s62Sja9FabTzXRo=; b=XUMz+l0t2p1RgjX64+/sjqz6KPsksyq2h7lnpYpR7C+1fIOYARNBJU77tWcAGTDPDx qGnzG5ouqcZGyeUrOd1GcSOCfYg3rIFZD2GJ+0eBgZ56ay0240IIX90h+lMtutBc7k74 0rw9QvQXDBG7bdciFlQpWLXDdzGnKcW2GzsBEjKIm1n+BlQcjb/ePceDg+0ktk6TA6rd 7bolAiJoYd+5X4YU+sRgoX9F0Lz27XU0oX77+ZxQRCzMVqC8Ws8hcQTpVH0y8mzJkbQW aadrsW+WBj6T4ACxdLzWVgA25Ve/ZUicHICOatkLzOF3uuscKDjp5iz3AXwmqOQOxn8c ImNg== X-Gm-Message-State: AOAM5326lPGBJUBOBD6T4QBg9gzAqcec03fF9W/V0GC71frNa1BepegV 23+b0B8VUrPEY5lcr6lEZCG5iZp+qHIzmvjLfBMUaA== X-Google-Smtp-Source: ABdhPJzFbprNq/7lspfkQH7+GKX9EQmI1MVogRrAG3+QjqvUOu0V1N8mI6de1OSSr9hdfTgjuHGrSuxzjwpwvt7RMok= X-Received: by 2002:a1f:2a95:: with SMTP id q143mr1010157vkq.8.1617183059626; Wed, 31 Mar 2021 02:30:59 -0700 (PDT) MIME-Version: 1.0 References: <20210324164408.14722-1-huobean@gmail.com> <7a774027-ad2c-21bf-8cb0-eaa92a76bad7@oracle.com> In-Reply-To: <7a774027-ad2c-21bf-8cb0-eaa92a76bad7@oracle.com> From: Ulf Hansson Date: Wed, 31 Mar 2021 11:30:23 +0200 Message-ID: Subject: Re: [External] : Re: [PATCH v2] mmc-utils: Add eMMC erase command support To: kimito.sakata@oracle.com Cc: Bean Huo , "Bean Huo (beanhuo)" , kenny.gibbons@oracle.com, rkamdar@micron.com, Chris Ball , linux-mmc , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Mar 2021 at 23:36, wrote: > > > > On 3/30/2021 6:39 AM, Ulf Hansson wrote: > > On Wed, 24 Mar 2021 at 17:45, Bean Huo wrote: > >> From: Kimito Sakata > >> > >> we have been using this erase feature for a while, but it is > >> still not merged into the upstream mmc-utils. Especially, for > >> the customer, every time when they update the mmc-utils, they > >> should re-install this patch again, let's try to make this > >> erase command upstreamed in the mmc-utils. > >> > >> Co-developed-by: Bean Huo > >> Signed-off-by: Bean Huo > >> Reviewed-by: Kenneth Gibbons > >> --- > >> > >> Hi Ulf, > >> Please help us review this mmc-utils patch, and if agree, it is > >> possible to make it merged in the official mmc-utils. > >> > >> Changelog: > >> > >> V1--V2: > >> 1. refactor Kimito's original patch > >> 2. change to use MMC_IOC_MULTI_CMD > >> 3. add checkup if eMMC devie supports secure erase/trim > >> > >> --- > >> mmc.c | 8 ++++ > >> mmc.h | 13 +++++- > >> mmc_cmds.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > >> mmc_cmds.h | 1 + > >> 4 files changed, 156 insertions(+), 1 deletion(-) > >> > >> diff --git a/mmc.c b/mmc.c > >> index 50c9c9e..cb29a65 100644 > >> --- a/mmc.c > >> +++ b/mmc.c > >> @@ -215,6 +215,14 @@ static struct Command commands[] = { > >> "Run Field Firmware Update with on .\n", > >> NULL > >> }, > >> + { do_erase, -4, > >> + "erase", " " " " " " "\n" > >> + "Send Erase CMD38 with specific argument to the \n\n" > >> + "NOTE!: This will delete all user data in the specified region of the device\n" > >> + " must be: legacy | discard | secure-erase | " > >> + "secure-trim1 | secure-trim2 | trim \n", > >> + NULL > >> + }, > >> { 0, 0, 0, 0 } > >> }; > >> > >> diff --git a/mmc.h b/mmc.h > >> index 648fb26..90b7fb5 100644 > >> --- a/mmc.h > >> +++ b/mmc.h > >> @@ -34,7 +34,15 @@ > >> #define MMC_SET_WRITE_PROT 28 /* ac [31:0] data addr R1b */ > >> #define MMC_CLEAR_WRITE_PROT 29 /* ac [31:0] data addr R1b */ > >> #define MMC_SEND_WRITE_PROT_TYPE 31 /* ac [31:0] data addr R1 */ > >> - > >> +#define MMC_ERASE_GROUP_START 35 /* ac [31:0] data addr R1 */ > >> +#define MMC_ERASE_GROUP_END 36 /* ac [31:0] data addr R1 */ > >> +#define MMC_ERASE 38 /* ac [31] Secure request > >> + [30:16] set to 0 > >> + [15] Force Garbage Collect request > >> + [14:2] set to 0 > >> + [1] Discard Enable > >> + [0] Identify Write Blocks for > >> + Erase (or TRIM Enable) R1b */ > >> /* > >> * EXT_CSD fields > >> */ > >> @@ -61,6 +69,7 @@ > >> #define EXT_CSD_CACHE_SIZE_2 251 > >> #define EXT_CSD_CACHE_SIZE_1 250 > >> #define EXT_CSD_CACHE_SIZE_0 249 > >> +#define EXT_CSD_SEC_FEATURE_SUPPORT 231 > >> #define EXT_CSD_BOOT_INFO 228 /* R/W */ > >> #define EXT_CSD_HC_ERASE_GRP_SIZE 224 > >> #define EXT_CSD_HC_WP_GRP_SIZE 221 > >> @@ -177,6 +186,8 @@ > >> #define EXT_CSD_REV_V4_2 2 > >> #define EXT_CSD_REV_V4_1 1 > >> #define EXT_CSD_REV_V4_0 0 > >> +#define EXT_CSD_SEC_GB_CL_EN (1<<4) > >> +#define EXT_CSD_SEC_ER_EN (1<<0) > >> > >> > >> /* From kernel linux/mmc/core.h */ > >> diff --git a/mmc_cmds.c b/mmc_cmds.c > >> index fb37189..17986e3 100644 > >> --- a/mmc_cmds.c > >> +++ b/mmc_cmds.c > >> @@ -2435,6 +2435,141 @@ int do_cache_dis(int nargs, char **argv) > >> return do_cache_ctrl(0, nargs, argv); > >> } > >> > >> +static int erase(int dev_fd, __u32 argin, __u32 start, __u32 end) > >> +{ > >> +#ifndef MMC_IOC_MULTI_CMD > > In kernel v4.4 we added the multi cmd support, which is quite some > > time ago. So, I think it's time to drop these ifdef hackary from the > > userland tool. At least, we shouldn't need it for new kinds of > > features that we add. > Ulf > Do you want us to take out the MMC_IOC_MULTI_CMD ifdef and resubmit? Yes, please. Moreover, we should probably also remove all the other #ifndef MMC_IOC_MULTI_CMD hacks that we currently have in the code. But that's a separate patch. > Kimito > > > > >> + fprintf(stderr, "mmc-utils has been compiled without MMC_IOC_MULTI_CMD" > >> + " support, needed by erase.\n"); > >> + return -ENOTSUP; > >> +#else > >> + int ret = 0; > >> + struct mmc_ioc_multi_cmd *multi_cmd; > >> + > > [...] Kind regards Uffe