From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
kernel@pengutronix.de, Alim Akhtar <alim.akhtar@samsung.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mmc: dw_mmc: exynos: Obviously always return success in remove callback
Date: Wed, 15 Jun 2022 10:32:57 -0700 [thread overview]
Message-ID: <CAPDyKFr35sr7RFpv4S0eosY4BT1r0te083rdan_tRq0T+7agJA@mail.gmail.com> (raw)
In-Reply-To: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de>
On Fri, 10 Jun 2022 at 14:13, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> dw_mci_pltfm_remove() returns 0 unconditionally and returning an error
> in a platform remove callback isn't very sensible. (The only effect of
> the latter is that the device core emits a generic warning and then
> removes the device anyhow.)
>
> So return 0 unconditionally to make it obvious there is no error
> forwarded to the upper layers.
>
> This is a preparation for making platform remove callbacks return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
This one and the other 4 patches in the series, applied for next. Thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index ca5be4445ae0..9f20ac524c8b 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev)
> pm_runtime_set_suspended(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
>
> - return dw_mci_pltfm_remove(pdev);
> + dw_mci_pltfm_remove(pdev);
> +
> + return 0;
> }
>
> static const struct dev_pm_ops dw_mci_exynos_pmops = {
>
> base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
> --
> 2.36.1
>
prev parent reply other threads:[~2022-06-15 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 21:12 [PATCH 1/5] mmc: dw_mmc: exynos: Obviously always return success in remove callback Uwe Kleine-König
2022-06-10 21:12 ` [PATCH 2/5] mmc: dw_mmc: hi3789cv200: " Uwe Kleine-König
2022-06-10 21:12 ` [PATCH 3/5] mmc: dw_mmc: rockchip: " Uwe Kleine-König
2022-06-10 21:12 ` [PATCH 4/5] mmc: sdhci-of-arasan: " Uwe Kleine-König
2022-06-13 7:13 ` Adrian Hunter
2022-06-13 8:35 ` Uwe Kleine-König
2022-06-10 21:12 ` [PATCH 5/5] mmc: sdhci-st: " Uwe Kleine-König
2022-06-13 7:14 ` Adrian Hunter
2022-06-15 17:32 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFr35sr7RFpv4S0eosY4BT1r0te083rdan_tRq0T+7agJA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).