From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5BEC4708C for ; Fri, 28 May 2021 09:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 763196128B for ; Fri, 28 May 2021 09:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235754AbhE1J2i (ORCPT ); Fri, 28 May 2021 05:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235393AbhE1J2a (ORCPT ); Fri, 28 May 2021 05:28:30 -0400 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67ADCC061574 for ; Fri, 28 May 2021 02:26:55 -0700 (PDT) Received: by mail-vs1-xe2e.google.com with SMTP id f11so1860329vst.0 for ; Fri, 28 May 2021 02:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lSrNJA8L2mfz3nzO0xWuQ7uzakK2R6vwdeEdePCtnq0=; b=vbGvnUB2ee8gN6kCb1QtHqgW5zdRB/De+4KKFZ3odYzssoqcORAziKqW3t/dl5074O MU02ZAwhTEUhcC5GUqskXZmCEId1/j/GxI7mGj/gxuVqU58+5iq4Y2yDNbcYUTl26J3N tbXjR0gcPStSOp+5QLfk9jCopcLRrqm5guRDC9vvuQFHJtwfckd9Ppz9E1l1wm616a2T ZcZLfN6Qm0Rv2NNVDqP1+Hatk0Lg2TWStZE5z3nPwyCjU0KcgkQIHgBPgHBpFdIUtOgr S30CVnx1+6dBR9MmULejbnwv+VnAT0/VQj2bym9pbKn1rthEPbbuloD9QHkEY4WO8vNo uUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lSrNJA8L2mfz3nzO0xWuQ7uzakK2R6vwdeEdePCtnq0=; b=m5FuxBPO/yXCTbMc8fDnai184Y+85fm3hdnUJnHkFAUgYBBf4jO6myhIaDX4UVIAxK mxnTh+LmIy8x6qEGg8KTSAEpP9jG0EGIoHM02N57YvGp01KG82H5dHiXoA/oq5JUKKAE 8Q2UUPmrDtoYwXCJ/43xZ0fIjxP3I+3ZU5y8/WeJjAW3gCBNUS5ZmbmObJZrLR3vAHBg tAfbY6wwz1DqVRNi6JBRQ6JzNS1Jz8zT0xdt6tsZXmA8czOS3TS9JO3ahxduFGPkDGrt 2i5ySA8tlxUSmNg7M3aL8RGkudDyUkaZNm8XjfoceV1r6TUhgMMBtHObl4ijbUMcdDXM hHfQ== X-Gm-Message-State: AOAM533M+1apMMz6B/NyjU1jLkO9xz+Hzgcb3gtBCYITlhJoj+iMRpYf /WHc5XFWPqQIJ4Q4qRXaQYP5HITa490p+Pmb+ZNb8g== X-Google-Smtp-Source: ABdhPJxnrT+9YO8VN0qWp0ACEUIbWnM1BEz+8iWMoAfJeIBYb9C3q1nJUf5ntroetINW8lgpgRY3na9se5SJiT9rv6Q= X-Received: by 2002:a05:6102:7b4:: with SMTP id x20mr6125121vsg.48.1622194014560; Fri, 28 May 2021 02:26:54 -0700 (PDT) MIME-Version: 1.0 References: <20210517130823.796963-1-anup.patel@wdc.com> <20210517130823.796963-6-anup.patel@wdc.com> In-Reply-To: From: Ulf Hansson Date: Fri, 28 May 2021 11:26:18 +0200 Message-ID: Subject: Re: [RFC PATCH v4 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 May 2021 at 11:05, Ulf Hansson wrote: > > On Tue, 25 May 2021 at 07:39, Anup Patel wrote: > > > > On Mon, May 24, 2021 at 11:31 PM Ulf Hansson wrote: > > > > > > On Mon, 17 May 2021 at 15:10, Anup Patel wrote: > > > > > > > > The generic power domain related code in PSCI domain driver is largely > > > > independent of PSCI and can be shared with RISC-V SBI domain driver > > > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > > > > > Signed-off-by: Anup Patel > > > > > > This is clearly a big step in the right direction. Just a couple minor > > > things, see more below. > > > > > > Note that, I have a couple of patches in the pipe for the > > > cpuidle-psci-domain driver (not ready to be posted). I need a couple > > > of more days to confirm this restructuring still makes sense beyond > > > these potential new changes. I will let you know as soon as I can with > > > the outcome. > > > > Sure, I will wait for more comments from you. I was thinking of sending > > next revision of patches sometime next week with the renaming of > > function names which you suggested. > > Sounds good, that allows me a few more days this week. I don't have any further comments at this point. It looks good to me, but let me have a quick review on the next version before I provide my ack. [...] Kind regards Uffe