From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756584AbaIILxS (ORCPT ); Tue, 9 Sep 2014 07:53:18 -0400 Received: from mail-qg0-f50.google.com ([209.85.192.50]:46625 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756558AbaIILxP (ORCPT ); Tue, 9 Sep 2014 07:53:15 -0400 MIME-Version: 1.0 In-Reply-To: <1410251689-12740-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1408683219-7939-1-git-send-email-srinivas.kandagatla@linaro.org> <1410251689-12740-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Tue, 9 Sep 2014 13:53:13 +0200 Message-ID: Subject: Re: [PATCH] mmc: mmci_qcom_dml: fix is never less than zero warning. From: Ulf Hansson To: Srinivas Kandagatla Cc: linux-mmc , Chris Ball , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9 September 2014 10:34, Srinivas Kandagatla wrote: > This patch fixes a typo which resulted in 'is never less > than zero warning' reported by static checker. > > drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init() > warn: unsigned 'producer_id' is never less than zero. > > drivers/mmc/host/mmci_qcom_dml.c > 121 /* Initialize the dml hardware connected to SD Card controller */ > 122 int dml_hw_init(struct mmci_host *host, struct device_node *np) > 123 { > 124 u32 config; > 125 void __iomem *base; > 126 u32 consumer_id, producer_id; > 127 > 128 consumer_id = of_get_dml_pipe_index(np, "tx"); > 129 producer_id = of_get_dml_pipe_index(np, "rx"); > 130 > 131 if (producer_id < 0 || consumer_id < 0) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 132 > > Reported-by: Dan Carpenter > Signed-off-by: Srinivas Kandagatla > --- > Hi Ulf, > > This patch is on top of https://git.linaro.org/people/ulf.hansson/mmc.git next branch > to fix up a warning reported by static checker tool. > > Are you ok to take this patch as it is or do you think I should resend the > original DML patch with this fix? > I am fine with this, I will fold it into the original patch. Applied for next. Kind regards Uffe > thanks, > srini > > drivers/mmc/host/mmci_qcom_dml.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c > index 300ef50..2b7fc37 100644 > --- a/drivers/mmc/host/mmci_qcom_dml.c > +++ b/drivers/mmc/host/mmci_qcom_dml.c > @@ -123,7 +123,7 @@ int dml_hw_init(struct mmci_host *host, struct device_node *np) > { > u32 config; > void __iomem *base; > - u32 consumer_id, producer_id; > + int consumer_id, producer_id; > > consumer_id = of_get_dml_pipe_index(np, "tx"); > producer_id = of_get_dml_pipe_index(np, "rx"); > -- > 1.9.1 >