From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48669C636CC for ; Tue, 7 Feb 2023 11:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbjBGLAb (ORCPT ); Tue, 7 Feb 2023 06:00:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231886AbjBGLA0 (ORCPT ); Tue, 7 Feb 2023 06:00:26 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D8339CFC for ; Tue, 7 Feb 2023 03:00:25 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id v18-20020a17090ae99200b00230f079dcd9so843589pjy.1 for ; Tue, 07 Feb 2023 03:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8+jhmIIz48dIXQX2IFPY0M3iWQXpZf8pO+LrMnazejU=; b=hMhZBrkwn9mu5rwO8P/wWBjO2hseEQQzHCJR2ZiThOOEH2glFvgReRPEFc6st2394h KJToZcnRQCop96jBGOSm+FA6D8/nUtORcBXIj+aI2pqB5s4kh+qkXg9yYTVeeX2VLhP+ 7yEuqZYYWjbxlzQrAywc/9namt2wZI0VALX6GfWH53wjYbKOBfzrMdgBObVwi6PkGtsL xzYhfX66LrbNCKS67UbfEQXkmFwQadAvEjYHkMULhFbxkhWglOBz+VXTZ4oqbDWMZEtQ sPiDLdzJLh0waxyM3hMvfubtsZ2vuUWFuXRpe7Gvoz9s1mIBwv6uYRV0LvO006WHGZie WoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8+jhmIIz48dIXQX2IFPY0M3iWQXpZf8pO+LrMnazejU=; b=b/DJcL4DaZAGpPgx7QZvGqsC2nFrPo1mUXT0iKum4Ei7G6ksSpd5x8+If9Zx59cFrG cwPakW49oXXl4NnYSRbrT7BJxwSF0gCazpW9nVkiey7ho3Hz7Do3anVHp5fJhaJEsnXk gPwklO5AnIZYhJfHSyeyBOJjj4R9LZ6W/Z0AC3rSEJ1q1hHlHaZRSljBJNtcd6DNMpW7 O2ME4rHGRYBEGVKSFGb91iDFReklbvyIa1Q2YUvrCwLA6eBGsK29Gf8fCBSnfXEXqA2F kGT6fVNl4+yX8GrsdRpEfmQUWAN+uOyTC6s3yBgO5AE9BTYCJcWg6v/eRw94o6aE8nCe /P5g== X-Gm-Message-State: AO0yUKUryFQGnB6dXlbg4hfclLWtJ4tLl7KkIaioSYBCMDHFa7IJPJdK z1q4dFWh+koRXOKvDvY2/hjgoHk+BfqG3Fw6rd446Q== X-Google-Smtp-Source: AK7set83msoaMiTXRrS5ta9B0EOybiGY0PCDj8JRYR9tI5TDFdGRWQJC3vfZF78+7WvToBf8qOiWISFUOlFdc4SubaE= X-Received: by 2002:a17:90a:d24f:b0:230:d1d5:2041 with SMTP id o15-20020a17090ad24f00b00230d1d52041mr1289670pjw.109.1675767624059; Tue, 07 Feb 2023 03:00:24 -0800 (PST) MIME-Version: 1.0 References: <20221213090047.3805-1-victor.shih@genesyslogic.com.tw> <20221213090047.3805-6-victor.shih@genesyslogic.com.tw> In-Reply-To: <20221213090047.3805-6-victor.shih@genesyslogic.com.tw> From: Ulf Hansson Date: Tue, 7 Feb 2023 11:59:47 +0100 Message-ID: Subject: Re: [PATCH V6 05/24] mmc: core: Add definitions for SD UHS-II cards To: Victor Shih Cc: adrian.hunter@intel.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw, takahiro.akashi@linaro.org, dlunev@chromium.org, Victor Shih , Jason Lai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Dec 2022 at 10:01, Victor Shih wrote: > > Add UHS-II specific data structures for commands and defines for > registers, as described in Part 1 UHS-II Addendum Version 1.01. > > UHS-II related definitions are listed below: > 1. UHS-II card capability: sd_uhs2_caps{} > 2. UHS-II configuration: sd_uhs2_config{} > 3. UHS-II Command structure: uhs2_command{} > 4. UHS-II register I/O address and register field definitions: sd_uhs2.h > > Signed-off-by: Ulf Hansson > Signed-off-by: Jason Lai > Signed-off-by: Victor Shih [...] > --- a/include/linux/mmc/core.h > +++ b/include/linux/mmc/core.h > @@ -23,6 +23,14 @@ enum mmc_blk_status { > MMC_BLK_NEW_REQUEST, > }; > > +struct uhs2_command { > + u16 header; > + u16 arg; > + __be32 *payload; > + u32 payload_len; > + u32 packet_len; > +}; > + > struct mmc_command { > u32 opcode; > u32 arg; > @@ -109,6 +117,11 @@ struct mmc_command { > unsigned int busy_timeout; /* busy detect timeout in ms */ > struct mmc_data *data; /* data segment associated with cmd */ > struct mmc_request *mrq; /* associated request */ > + > + struct uhs2_command *uhs2_cmd; /* UHS2 command */ > + u8 *uhs2_resp; /* UHS2 native cmd resp */ > + u8 uhs2_resp_len; /* UHS2 native cmd resp len */ > + u8 uhs2_tmode0_flag; /* UHS2 transfer mode flag */ I forgot to comment on this flag in my earlier reply. It looks like the flag is being set for "MMC_CMD_ADTC" commands. This makes me wonder, why can't we keep using cmd->flags to check this, rather than adding a new flag solely for UHS2? Or is there a problem with this? I will continue to comment around this at patch7 too. [...] Kind regards Uffe