From: Ulf Hansson <ulf.hansson@linaro.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
Adrian Hunter <adrian.hunter@intel.com>,
rajan.vaja@xilinx.com, jolly.shah@xilinx.com,
nava.manne@xilinx.com, Olof Johansson <olof@lixom.net>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup
Date: Mon, 17 Jun 2019 13:15:03 +0200 [thread overview]
Message-ID: <CAPDyKFrJwpwUUX_q2kcR9QY_fv9Lgos+ixPmU6JMeJVqJAiFpg@mail.gmail.com> (raw)
In-Reply-To: <1560247011-26369-4-git-send-email-manish.narani@xilinx.com>
On Tue, 11 Jun 2019 at 11:57, Manish Narani <manish.narani@xilinx.com> wrote:
>
> Apart from taps set by auto tuning, ZynqMP platform has feature to set
> the tap values manually. Add support to read tap delay values from
> DT and set the same in HW via ZynqMP SoC framework. Reading Tap
> Delays from DT is optional, if the property is not available in DT the
> driver will use the pre-defined Tap Delay Values.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 173 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 172 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b12abf9..7af6cec 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -22,6 +22,7 @@
> #include <linux/phy/phy.h>
> #include <linux/regmap.h>
> #include <linux/of.h>
> +#include <linux/firmware/xlnx-zynqmp.h>
>
> #include "cqhci.h"
> #include "sdhci-pltfm.h"
> @@ -32,6 +33,10 @@
>
> #define PHY_CLK_TOO_SLOW_HZ 400000
>
> +/* Default settings for ZynqMP Tap Delays */
> +#define ZYNQMP_ITAP_DELAYS {0, 0x15, 0x15, 0, 0x15, 0, 0, 0x3D, 0x12, 0, 0}
> +#define ZYNQMP_OTAP_DELAYS {0, 0x5, 0x6, 0, 0x5, 0x3, 0x3, 0x4, 0x6, 0x3, 0}
> +
> /*
> * On some SoCs the syscon area has a feature where the upper 16-bits of
> * each 32-bit register act as a write mask for the lower 16-bits. This allows
> @@ -81,6 +86,7 @@ struct sdhci_arasan_soc_ctl_map {
> * @sdcardclk: Pointer to normal 'struct clock' for sdcardclk_hw.
> * @soc_ctl_base: Pointer to regmap for syscon for soc_ctl registers.
> * @soc_ctl_map: Map to get offsets into soc_ctl registers.
> + * @of_data: Platform specific runtime data storage pointer
> */
> struct sdhci_arasan_data {
> struct sdhci_host *host;
> @@ -101,6 +107,15 @@ struct sdhci_arasan_data {
> /* Controller immediately reports SDHCI_CLOCK_INT_STABLE after enabling the
> * internal clock even when the clock isn't stable */
> #define SDHCI_ARASAN_QUIRK_CLOCK_UNSTABLE BIT(1)
> +
> + void *of_data;
> +};
> +
> +struct sdhci_arasan_zynqmp_data {
> + void (*set_tap_delay)(struct sdhci_host *host);
> + const struct zynqmp_eemi_ops *eemi_ops;
> + u8 tapdly[MMC_TIMING_MMC_HS400 + 1][2]; /* [0] for input delay, */
> + /* [1] for output delay */
> };
Please use two different structs, one for the clock provider data and
one for the mmc variant/platform data. This makes the code more
readable.
In regards to the mmc data part, I suggest to drop the
->set_tap_delay() callback, but rather use a boolean flag to indicate
whether clock phases needs to be changed for the variant. Potentially
that could even be skipped and instead call clk_set_phase()
unconditionally, as the clock core deals fine with clock providers
that doesn't support the ->set_phase() callback.
[...]
Otherwise this looks good to me!
When it comes to patch1, I need an ack from Michal to pick it up.
Kind regards
Uffe
next prev parent reply other threads:[~2019-06-17 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:56 [PATCH 0/3] Add ZynqMP SD Clock Tap Delays configuration support Manish Narani
2019-06-11 9:56 ` [PATCH 1/3] firmware: xilinx: Add SDIO Tap Delay API Manish Narani
2019-06-11 9:56 ` [PATCH 2/3] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Manish Narani
2019-06-11 9:56 ` [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Manish Narani
2019-06-13 10:36 ` Adrian Hunter
2019-06-17 11:15 ` Ulf Hansson [this message]
2019-06-17 11:27 ` Michal Simek
2019-06-17 12:21 ` Ulf Hansson
2019-06-17 14:23 ` Michal Simek
2019-06-17 14:58 ` Ulf Hansson
2019-06-18 4:59 ` Manish Narani
2019-06-19 14:40 ` Ulf Hansson
2019-06-20 8:19 ` Manish Narani
2019-06-19 8:40 ` Manish Narani
2019-06-19 13:38 ` Ulf Hansson
2019-06-20 8:14 ` Manish Narani
2019-06-20 13:33 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrJwpwUUX_q2kcR9QY_fv9Lgos+ixPmU6JMeJVqJAiFpg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jolly.shah@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=olof@lixom.net \
--cc=rajan.vaja@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).