linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [GIT PULL] MMC fixes for v5.13-rc8
Date: Mon, 28 Jun 2021 09:49:07 +0200	[thread overview]
Message-ID: <CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=whn_yTjV=YAU4xMBkLEb+E76zUKM_Xy5ZwMp_504wqR9A@mail.gmail.com>

+ Neil, Robin

On Thu, 24 Jun 2021 at 20:00, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, Jun 24, 2021 at 5:32 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > Neil Armstrong (1):
> >       mmc: meson-gx: use memcpy_to/fromio for dram-access-quirk
>
> Ugh. How horribly ugly.
>
> Why is that 'host->dram_access_quirk' test _inside_ the loop, rather
> than be something like
>
>         if (host->dram_access_quirk)
>                 return sg_copy_to_buffer(data->sg, data->sg_len,
>                                 host->bounce_buf, xfer_bytes);
>
> at the top of the function, with meson_mmc_copy_buffer() then only
> handling the mmio case?
>
> No, I don't know this code, I'm just looking at the patch and going
> "that looks really ugly".
>
> Anyway, I've pulled it, but I thought I'd voice my reaction to it..

Thanks, good point!

Robin and Neil did discuss some cleanup that could be made on top [1],
but it looks like that was targeting a different part.

In any case, Neil, would you mind sending a cleanup according to the
comment from Linus?

Kind regards
Uffe

[1]
https://www.spinics.net/lists/arm-kernel/msg901045.html

  reply	other threads:[~2021-06-28  7:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 12:32 [GIT PULL] MMC fixes for v5.13-rc8 Ulf Hansson
2021-06-24 18:00 ` Linus Torvalds
2021-06-28  7:49   ` Ulf Hansson [this message]
2021-06-28  8:28     ` Neil Armstrong
2021-06-24 18:01 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robin.murphy@arm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).