From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77903CA9EC5 for ; Wed, 30 Oct 2019 16:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462D2208E3 for ; Wed, 30 Oct 2019 16:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uKbzD6z3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbfJ3QpC (ORCPT ); Wed, 30 Oct 2019 12:45:02 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:43090 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726995AbfJ3QpA (ORCPT ); Wed, 30 Oct 2019 12:45:00 -0400 Received: by mail-ua1-f65.google.com with SMTP id c25so902250uap.10 for ; Wed, 30 Oct 2019 09:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p3/pbvedwS4IhZb4B6nbOhbMOZh2AXw7ndulwhv3TfM=; b=uKbzD6z3ZGjc1fWALJKpEEB/bbWW4HPabd5njl25crREYFACWhI8l1Kir807xOxFpf uaLa/jYOBB4myt492ky0Bm4YMaUYwzK/94ra2AKsk/hjtGfxyIUNsYZMw3k03FhB7aa+ D2OMDUrVDFG4lh3JnM9JNhFiNrQATzIWHgWWrsFo/gfWlZcp7D/KPuimOVmXF9dmZDOE kqpQKHr+JjnMM9ArF0cPmyy5HSVupmLBQmTJ2rUO9BmpLiphAUI7CTD1n8sVbxM3f7P+ y4tJ9cXCf+NQfuudxvOK6UYmowPV5Kf2WNvQcUvzZdfMJCJXPEp22cQ//ywxY1dvTRRP vp1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p3/pbvedwS4IhZb4B6nbOhbMOZh2AXw7ndulwhv3TfM=; b=RII9i6+UI+74Sr0/Jw6Sogg/LLe4Rbl6JcVvyeR0fv6+gsKgygnflF0S63R5QSnH3v Yt79KPnPq1feL3hpx8xFf0w2MauqYBWPKDejR8raHBGgxL+zbXlXkp0TD3e/bSp0sy9u mm95rYx2s3yKqfJzaeqRDEDatkbjK0WqHVipoJ0V2x6DIwyEMUROYpVQDJikXtZjQ7xb Y82I2Mo8pv1o2XeqoTEVAFuoyP//TnLJJTwHtQH/egABLOwONcHSvKrhPwNdiAy9IUBc 3I9lC0e5dH8CjuAQN7a6MA7rr27KQ7F9gPx1mxwEpj53CJA0O7Xlc6dOjO6ZOYtpnoic 3Pjg== X-Gm-Message-State: APjAAAVcgV5wpZFwTr40f6Aka4vcBOTcM1oY2AFmJHbA0oJGHasgoBfZ EKCDZ70HWJ6exIONgI6ebSesuixzAqYitwxfNlsseQ== X-Google-Smtp-Source: APXvYqxJtN6SyNTtxvr9eHmowjOiNggxSentSJ3MZnyqcgsnfmMgt0WjJPDMGJJ+lnTYhFM/TEriRkTW1hDBpWXDXFc= X-Received: by 2002:ab0:2258:: with SMTP id z24mr367974uan.100.1572453897721; Wed, 30 Oct 2019 09:44:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Wed, 30 Oct 2019 17:44:21 +0100 Message-ID: Subject: Re: [PATCH v2 03/11] DTS: ARM: pandora-common: define wl1251 as child node of mmc3 To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas , linux-omap , DTML , Linux Kernel Mailing List , Linux ARM , "linux-mmc@vger.kernel.org" , linux-wireless , netdev , Discussions about the Letux Kernel , kernel@pyra-handheld.com, "# 4.0+" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Oct 2019 at 20:42, H. Nikolaus Schaller wrote: > > Since v4.7 the dma initialization requires that there is a > device tree property for "rx" and "tx" channels which is > not provided by the pdata-quirks initialization. > > By conversion of the mmc3 setup to device tree this will > finally allows to remove the OpenPandora wlan specific omap3 > data-quirks. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > Signed-off-by: H. Nikolaus Schaller > Cc: # 4.7.0 > --- > arch/arm/boot/dts/omap3-pandora-common.dtsi | 37 +++++++++++++++++++-- > 1 file changed, 35 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi > index ec5891718ae6..c595b3eb314d 100644 > --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi > +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi > @@ -226,6 +226,18 @@ > gpio = <&gpio6 4 GPIO_ACTIVE_HIGH>; /* GPIO_164 */ > }; > > + /* wl1251 wifi+bt module */ > + wlan_en: fixed-regulator-wg7210_en { > + compatible = "regulator-fixed"; > + regulator-name = "vwlan"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; I doubt these are correct. I guess this should be in the range of 2.7V-3.6V. > + startup-delay-us = <50000>; > + regulator-always-on; Always on? > + enable-active-high; > + gpio = <&gpio1 23 GPIO_ACTIVE_HIGH>; > + }; > + > /* wg7210 (wifi+bt module) 32k clock buffer */ > wg7210_32k: fixed-regulator-wg7210_32k { > compatible = "regulator-fixed"; > @@ -522,9 +534,30 @@ > /*wp-gpios = <&gpio4 31 GPIO_ACTIVE_HIGH>;*/ /* GPIO_127 */ > }; > > -/* mmc3 is probed using pdata-quirks to pass wl1251 card data */ > &mmc3 { > - status = "disabled"; > + vmmc-supply = <&wlan_en>; > + > + bus-width = <4>; > + non-removable; > + ti,non-removable; > + cap-power-off-card; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + wlan: wl1251@1 { > + compatible = "ti,wl1251"; > + > + reg = <1>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ > + > + ti,wl1251-has-eeprom; > + }; > }; > > /* bluetooth*/ > -- > 2.19.1 > Kind regards Uffe