From: Ulf Hansson <ulf.hansson@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
martyn.welch@collabora.co.uk, David Airlie <airlied@linux.ie>,
Tomas Winkler <tomas.winkler@intel.com>,
linux-usb@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Russell King <linux@arm.linux.org.uk>,
Len Brown <lenb@kernel.org>, Len Brown <len.brown@intel.com>,
Kevin Hilman <khilman@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-omap <linux-omap@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 0/4] Allow USB devices to remain runtime-suspended when sleeping
Date: Mon, 5 Oct 2015 23:36:17 +0200 [thread overview]
Message-ID: <CAPDyKFrU5mBz+xrj9dHkNfGa_QFBBWVsarFm4UG0oOTXyQfiHQ@mail.gmail.com> (raw)
In-Reply-To: <1444056332-30246-1-git-send-email-tomeu.vizoso@collabora.com>
On 5 October 2015 at 16:45, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Hi,
>
> this is v9 of an attempt to make it easier for devices to remain in
> runtime PM when the system goes to sleep, mainly to reduce the time
> spent resuming devices.
>
> For this, we interpret the absence of all PM callback implementations as
> it being safe to do direct_complete, so their ancestors aren't prevented
> from remaining runtime-suspended.
>
> Additionally, the prepare() callback of USB devices will return 1 if
> runtime PM is enabled and the current wakeup settings are correct.
>
> With these changes, a uvcvideo device (for example) stays in runtime
> suspend when the system goes to sleep and is left in that state when the
> system resumes, not delaying it unnecessarily.
>
> Thanks,
>
> Tomeu
>
> Changes in v9:
> - Add docs noting the need for the device lock to be held before calling
> device_is_bound()
> - Add docs noting the need for the device lock to be held before calling
> dev_pm_domain_set()
> - Move to CONFIG_PM_SLEEP as suggested by Rafael and Ulf.
> - Rename from device_check_pm_callbacks to device_pm_check_callbacks to
> follow with the naming convention of existing API.
> - Re-add calling to device_pm_check_callbacks from device registration
> and when updating the PM domain of a device.
>
> Changes in v8:
> - Add device_is_bound()
> - Add dev_pm_domain_set() and update code to use it
> - Move no_pm_callbacks field into CONFIG_PM_SLEEP
> - Call device_check_pm_callbacks only after a device is bound or unbound
>
> Changes in v7:
> - Reduce indentation by adding a label in device_prepare()
>
> Changes in v6:
> - Add stub for !CONFIG_PM.
> - Move implementation of device_check_pm_callbacks to power/main.c as it
> doesn't belong to CONFIG_PM_SLEEP.
> - Take dev->power.lock before modifying flag.
>
> Changes in v5:
> - Check for all dev_pm_ops instances associated to a device, updating a
> no_pm_callbacks flag at the times when that could change.
>
> Tomeu Vizoso (4):
> device core: add device_is_bound()
> PM / Domains: add setter for dev.pm_domain
> PM / sleep: Go direct_complete if driver has no callbacks
> USB / PM: Allow USB devices to remain runtime-suspended when sleeping
>
> arch/arm/mach-omap2/omap_device.c | 7 ++++---
> drivers/acpi/acpi_lpss.c | 5 +++--
> drivers/acpi/device_pm.c | 5 +++--
> drivers/base/dd.c | 21 +++++++++++++++++++--
> drivers/base/power/clock_ops.c | 5 +++--
> drivers/base/power/common.c | 24 ++++++++++++++++++++++++
> drivers/base/power/domain.c | 6 ++++--
> drivers/base/power/main.c | 35 +++++++++++++++++++++++++++++++++++
> drivers/base/power/power.h | 3 +++
> drivers/gpu/vga/vga_switcheroo.c | 10 +++++-----
> drivers/misc/mei/pci-me.c | 5 +++--
> drivers/misc/mei/pci-txe.c | 5 +++--
> drivers/usb/core/port.c | 6 ++++++
> drivers/usb/core/usb.c | 11 ++++++++++-
> include/linux/device.h | 2 ++
> include/linux/pm.h | 1 +
> include/linux/pm_domain.h | 3 +++
> 17 files changed, 131 insertions(+), 23 deletions(-)
>
> --
> 2.4.3
>
This looks good to me, for the series you may add:
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
prev parent reply other threads:[~2015-10-05 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 14:45 [PATCH v9 0/4] Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
2015-10-05 14:45 ` [PATCH v9 1/4] device core: add device_is_bound() Tomeu Vizoso
2015-10-05 14:45 ` [PATCH v9 2/4] PM / Domains: add setter for dev.pm_domain Tomeu Vizoso
2015-10-05 14:45 ` [PATCH v9 3/4] PM / sleep: Go direct_complete if driver has no callbacks Tomeu Vizoso
2015-10-05 14:45 ` [PATCH v9 4/4] USB / PM: Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
2015-10-17 6:38 ` Greg Kroah-Hartman
2015-10-17 15:12 ` Alan Stern
2015-10-05 20:26 ` [PATCH v9 0/4] " Rafael J. Wysocki
2015-10-05 21:36 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrU5mBz+xrj9dHkNfGa_QFBBWVsarFm4UG0oOTXyQfiHQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=martyn.welch@collabora.co.uk \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=tomas.winkler@intel.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).