From: Ulf Hansson <ulf.hansson@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jisheng Zhang <jszhang@marvell.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Joshua Frkuska <joshua_frkuska@mentor.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH] drivers: base: add support to skip power management in device/driver model
Date: Mon, 11 Feb 2019 17:20:20 +0100 [thread overview]
Message-ID: <CAPDyKFrV7XpKK-Pds=BNgJm9EC50C0wB_f99DK-6N7+K8aZXZw@mail.gmail.com> (raw)
In-Reply-To: <20190207152908.GC14464@e107155-lin>
On Thu, 7 Feb 2019 at 16:29, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Thu, Feb 07, 2019 at 04:18:57PM +0100, Ulf Hansson wrote:
> > On Thu, 7 Feb 2019 at 16:06, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> [...]
>
> > > Indeed, I was ignoring knowing that it's harmless. But more people
> > > started to complain, and Rafael suggested this which I agree as we
> > > have several pseudo devices created in the kernel that we can bypass
> > > some of these pm handling knowing we won't need it.
> >
> > Okay, I see.
> >
> > Anyway, I will likely need to restore part of this change, via my
> > cluster idling series then. As from that point, the cpu device that
> > you call device_set_pm_not_required() for, starts to be used from both
> > PM core and runtime PM point of view. But I guess that's okay then.
> >
>
> Ah I see. I can drop for CPU devices then. Since I didn't see any use for
> them, I set the flag, but I can drop it now or you can do that as part
> of that series.
Well, I prefer if you drop it for CPU devices, as least for now.
> There are quite a few devices(especially the ones
> registered under system subsys can set this but I would take it separate
> once we settle on this). Also Rafael may have seen use for few more
> devices when he suggested this.
Yep, let's find another first user of this.
Additionally, it seems like we should drop the print in device_pm_add().
Kind regards
Uffe
next prev parent reply other threads:[~2019-02-11 16:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 15:09 [PATCH] drivers: base: add support to skip power management in device/driver model Sudeep Holla
2019-02-06 15:41 ` Sudeep Holla
2019-02-07 9:53 ` Ulf Hansson
2019-02-07 10:36 ` Sudeep Holla
2019-02-07 14:29 ` Ulf Hansson
2019-02-07 15:06 ` Sudeep Holla
2019-02-07 15:18 ` Ulf Hansson
2019-02-07 15:29 ` Sudeep Holla
2019-02-11 16:20 ` Ulf Hansson [this message]
2019-02-12 17:49 ` Sudeep Holla
2019-02-12 18:07 ` Rafael J. Wysocki
2019-02-12 18:20 ` Sudeep Holla
2019-02-12 18:59 ` Rafael J. Wysocki
2019-02-15 8:21 ` [LKP] [drivers] a0c863ed70: WARNING:at_fs/sysfs/group.c:#sysfs_remove_group kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFrV7XpKK-Pds=BNgJm9EC50C0wB_f99DK-6N7+K8aZXZw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=erosca@de.adit-jv.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua_frkuska@mentor.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=slongerbeam@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).