From: Ulf Hansson <ulf.hansson@linaro.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: rrangel@google.com, "Shah,
Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE_A
Date: Mon, 6 Jul 2020 16:49:11 +0200 [thread overview]
Message-ID: <CAPDyKFrV9vn1jFEzCWZ-5aDHSyTz9+m9MM_CWLp9iA86YCGTwg@mail.gmail.com> (raw)
In-Reply-To: <20200623133347.4598-1-akshu.agrawal@amd.com>
On Tue, 23 Jun 2020 at 15:34, Akshu Agrawal <akshu.agrawal@amd.com> wrote:
>
> HS400/HS200/eMMC HS doesn't have Preset Value register.
> Hence, sdhci_set_ios function overrides the value set by fmw to
> SDHCI_CTRL_DRV_TYPE_B.
> This patch sets drv_type to MMC_SET_DRIVER_TYPE_A
> so that host_control2 register gets updated with the required
> strength value.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index d8b76cb8698a..48ecbd0b180d 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card,
> unsigned int max_dtr, int host_drv,
> int card_drv, int *drv_type)
> {
> + *drv_type = MMC_SET_DRIVER_TYPE_A;
> return MMC_SET_DRIVER_TYPE_A;
> }
>
> --
> 2.20.1
>
prev parent reply other threads:[~2020-07-06 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:33 [PATCH] mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE_A Akshu Agrawal
2020-07-01 10:43 ` Adrian Hunter
2020-07-06 14:49 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrV9vn1jFEzCWZ-5aDHSyTz9+m9MM_CWLp9iA86YCGTwg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=akshu.agrawal@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=rrangel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).