From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbeCOM3e (ORCPT ); Thu, 15 Mar 2018 08:29:34 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:40560 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbeCOM3c (ORCPT ); Thu, 15 Mar 2018 08:29:32 -0400 X-Google-Smtp-Source: AG47ELuEqL3UpGHuMLOaAioLQAsF+tkGkkryiFWtwGmfk28fbqkjgPGPSBGOh4gIrxKirlTJUpNNeOYllw8+j+LJsk0= MIME-Version: 1.0 In-Reply-To: <1521109575.10722.654.camel@linux.intel.com> References: <1520917812-20047-1-git-send-email-harish_kandiga@mentor.com> <1521109575.10722.654.camel@linux.intel.com> From: Ulf Hansson Date: Thu, 15 Mar 2018 13:29:30 +0100 Message-ID: Subject: Re: [PATCH v10] mmc: Export host capabilities to debugfs. To: Andy Shevchenko Cc: Harish Jenny K N , Linus Walleij , Adrian Hunter , Shawn Lin , avri.altman@wdc.com, "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Vladimir Zapolskiy Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 March 2018 at 11:26, Andy Shevchenko wrote: > On Thu, 2018-03-15 at 11:12 +0100, Ulf Hansson wrote: >> On 13 March 2018 at 06:10, Harish Jenny K N > > wrote: >> > > >> Honestly, I don't like this, but maybe other people do, then I am fine >> with this approach. >> >> If were to decide, I would just rather print the caps field in a >> hexadecimal bit form and leave the translation to the user. > > A compromise would be to print both: > > 0xHHHHHHHH\n > Description of each enabled field, one per line > > > Another format would be: > > Bit XX: Description of a field If we were to print the description, there is no point in printing the bits in hex. Or is it? As I said, if you and other folkz thinks this is valuable, then I am fine as well. Just saying, it's not my preferred option. Kind regards Uffe