From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memstick: r592: remove unused variable
Date: Thu, 15 Apr 2021 14:02:29 +0200 [thread overview]
Message-ID: <CAPDyKFr_Rnds6=W-TpOMhVcO9aP9OLapqCy1rFp8EHriWuQbuw@mail.gmail.com> (raw)
In-Reply-To: <1618366903-94346-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Wed, 14 Apr 2021 at 04:21, Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following clang warning:
>
> drivers/memstick/host/r592.c:363:6: warning: variable ‘len’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/memstick/host/r592.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index d2ef463..026fada 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -360,12 +360,11 @@ static void r592_write_fifo_pio(struct r592_device *dev,
> static void r592_flush_fifo_write(struct r592_device *dev)
> {
> u8 buffer[4] = { 0 };
> - int len;
>
> if (kfifo_is_empty(&dev->pio_fifo))
> return;
>
> - len = kfifo_out(&dev->pio_fifo, buffer, 4);
> + kfifo_out(&dev->pio_fifo, buffer, 4);
> r592_write_reg_raw_be(dev, R592_FIFO_PIO, *(u32 *)buffer);
> }
>
> --
> 1.8.3.1
>
prev parent reply other threads:[~2021-04-15 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 2:21 [PATCH] memstick: r592: remove unused variable Jiapeng Chong
2021-04-15 12:02 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFr_Rnds6=W-TpOMhVcO9aP9OLapqCy1rFp8EHriWuQbuw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).