From: Ulf Hansson <ulf.hansson@linaro.org>
To: Alex Shi <alex.shi@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu
Date: Thu, 1 Sep 2016 11:26:15 +0200 [thread overview]
Message-ID: <CAPDyKFra5YRUPB7a2th6K1hnK=PUz9k27d6DNNoVaJ76QSWe3w@mail.gmail.com> (raw)
In-Reply-To: <57C7A597.4050001@linaro.org>
On 1 September 2016 at 05:50, Alex Shi <alex.shi@linaro.org> wrote:
>
> Few commits and patch changed according to Greg's comments.
>
> Regards
> Alex
>
> ====
>
> From 186c534b0b8b9649fbfce05b0b4f90f764c571a4 Mon Sep 17 00:00:00 2001
> From: Alex Shi <alex.shi@linaro.org>
> Date: Tue, 16 Aug 2016 15:29:01 +0800
> Subject: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu
>
> Adding /sys/devices/system/cpu/cpux/power/pm_qos_resume_latency_us for
> each of cpus. The pm_qos_resume_latency usage defined in
> Documentation/ABI/testing/sysfs-devices-power
>
> The cpu-dma PM QoS constraint impacts all the cpus in the system. There
> is no way to let the user to choose a PM QoS constraint per cpu.
>
> The following patch exposes to the userspace a per cpu based sysfs file
> in order to let the userspace to change the value of the PM QoS latency
> constraint.
>
> This change is inoperative in its form and the cpuidle governors have to
> take into account the per cpu latency constraint in addition to the
> global cpu-dma latency constraint in order to operate properly.
In general I think the change makes sense, although it's this last
piece here that I wonder about.
Is it okay that we expose sysfs attributes to userspace that don't
have any effect if they change the values? Perhaps it should be the
responsibility of the menu governor somehow to expose the sysfs nodes
instead? Unless there are some difficulties that prevents us from that
of course.
Kind regards
Uffe
>
> Signed-off-by: Alex Shi <alex.shi@linaro.org>
> To: linux-kernel@vger.kernel.org
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/base/cpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 4c28e1a..2c3b359 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -17,6 +17,7 @@
> #include <linux/of.h>
> #include <linux/cpufeature.h>
> #include <linux/tick.h>
> +#include <linux/pm_qos.h>
>
> #include "base.h"
>
> @@ -376,6 +377,7 @@ int register_cpu(struct cpu *cpu, int num)
>
> per_cpu(cpu_sys_devices, num) = &cpu->dev;
> register_cpu_under_node(num, cpu_to_node(num));
> + dev_pm_qos_expose_latency_limit(&cpu->dev, 0);
>
> return 0;
> }
> --
> 2.8.1.101.g72d917a
>
>
>
next prev parent reply other threads:[~2016-09-01 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 8:42 [PATCH 1/4] cpu: clean up register_cpu func Alex Shi
2016-08-25 8:42 ` [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi
2016-08-31 10:45 ` Alex Shi
2016-08-31 13:18 ` Greg Kroah-Hartman
2016-09-01 3:39 ` Alex Shi
2016-09-01 3:45 ` Alex Shi
2016-09-01 3:50 ` Alex Shi
2016-09-01 9:26 ` Ulf Hansson [this message]
2016-09-13 1:04 ` Alex Shi
2016-09-13 7:17 ` Ulf Hansson
2016-09-13 13:57 ` Alex Shi
2016-08-25 8:42 ` [PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep Alex Shi
2016-08-31 10:45 ` Alex Shi
2016-09-13 14:01 ` Alex Shi
2016-08-25 8:42 ` [PATCH 4/4] cpuidle/menu: add per cpu pm_qos_resume_latency consideration Alex Shi
2016-08-31 10:46 ` Alex Shi
2016-09-13 14:02 ` Alex Shi
2016-09-13 22:10 ` Rafael J. Wysocki
2016-09-14 8:28 ` Vincent Guittot
2016-09-23 1:36 ` Rafael J. Wysocki
2016-09-23 4:58 ` Alex Shi
2016-08-31 10:45 ` [PATCH 1/4] cpu: clean up register_cpu func Alex Shi
2016-08-31 13:17 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2016-08-19 8:25 Alex Shi
2016-08-19 8:25 ` [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu Alex Shi
2016-08-22 4:49 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFra5YRUPB7a2th6K1hnK=PUz9k27d6DNNoVaJ76QSWe3w@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=alex.shi@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).