From: Ulf Hansson <ulf.hansson@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 06/13] mmc: mmci: add ddrmode mask to variant data
Date: Fri, 30 May 2014 11:35:01 +0200 [thread overview]
Message-ID: <CAPDyKFraGdp2QUHzhjoe5mO6ZyuS08notgkxpRB5A_GpYtyXTw@mail.gmail.com> (raw)
In-Reply-To: <1401284807-16686-1-git-send-email-srinivas.kandagatla@linaro.org>
On 28 May 2014 15:46, <srinivas.kandagatla@linaro.org> wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> This patch adds ddrmode mask to variant structure giving more flexibility
> to the driver to support more SOCs which have different datactrl register
> layout.
>
> Without this patch datactrl register is updated with wrong ddrmode mask on non
> ST SOCs, resulting in card detection failures.
The above statement seems not correct. We don't have any issues
currently, right. :-)
Kind regards
Ulf Hansson
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mmc/host/mmci.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index 23401b0..729105b 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -59,6 +59,7 @@ static unsigned int fmax = 515633;
> * is asserted (likewise for RX)
> * @sdio: variant supports SDIO
> * @st_clkdiv: true if using a ST-specific clock divider algorithm
> + * @datactrl_mask_ddrmode: ddr mode mask in datactrl register.
> * @blksz_datactrl16: true if Block size is at b16..b30 position in datactrl register
> * @blksz_datactrl4: true if Block size is at b4..b16 position in datactrl
> * register
> @@ -74,6 +75,7 @@ struct variant_data {
> unsigned int datalength_bits;
> unsigned int fifosize;
> unsigned int fifohalfsize;
> + unsigned int datactrl_mask_ddrmode;
> bool sdio;
> bool st_clkdiv;
> bool blksz_datactrl16;
> @@ -152,6 +154,7 @@ static struct variant_data variant_ux500v2 = {
> .fifohalfsize = 8 * 4,
> .clkreg = MCI_CLK_ENABLE,
> .clkreg_enable = MCI_ST_UX500_HWFCEN,
> + .datactrl_mask_ddrmode = MCI_ST_DPSM_DDRMODE,
> .datalength_bits = 24,
> .sdio = true,
> .st_clkdiv = true,
> @@ -779,7 +782,7 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data)
> }
>
> if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50)
> - datactrl |= MCI_ST_DPSM_DDRMODE;
> + datactrl |= variant->datactrl_mask_ddrmode;
>
> /*
> * Attempt to use DMA operation mode, if this
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-05-30 9:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 13:43 [PATCH v4 00/13] Add Qualcomm SD Card Controller support srinivas.kandagatla
2014-05-28 13:45 ` [PATCH v4 01/13] mmc: mmci: use NSEC_PER_SEC macro srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 02/13] mmc: mmci: convert register bits to use BIT() macro srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 03/13] mmc: mmci: Add Qualcomm Id to amba id table srinivas.kandagatla
2014-05-30 9:39 ` Ulf Hansson
2014-05-30 9:49 ` Srinivas Kandagatla
2014-05-28 13:46 ` [PATCH v4 04/13] mmc: mmci: Add enough delay between writes to CMD register srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 05/13] mmc: mmci: Add Qcom datactrl register variant srinivas.kandagatla
2014-05-28 13:46 ` [PATCH v4 06/13] mmc: mmci: add ddrmode mask to variant data srinivas.kandagatla
2014-05-30 9:35 ` Ulf Hansson [this message]
2014-05-30 9:50 ` Srinivas Kandagatla
2014-05-28 13:47 ` [PATCH v4 07/13] mmc: mmci: add 8bit bus support in " srinivas.kandagatla
2014-05-28 13:47 ` [PATCH v4 08/13] mmc: mmci: add edge support to data and command out " srinivas.kandagatla
2014-05-28 13:47 ` [PATCH v4 09/13] mmc: mmci: add Qcom specifics of clk and datactrl registers srinivas.kandagatla
2014-05-30 9:55 ` Ulf Hansson
2014-05-30 9:59 ` Srinivas Kandagatla
2014-05-28 13:47 ` [PATCH v4 10/13] mmc: mmci: Add support to data commands via variant structure srinivas.kandagatla
2014-05-28 13:47 ` [PATCH v4 11/13] mmc: mmci: add f_max to " srinivas.kandagatla
2014-05-30 10:28 ` Ulf Hansson
2014-05-30 10:29 ` Srinivas Kandagatla
2014-05-28 13:47 ` [PATCH v4 12/13] mmc: mmci: add explicit clk control srinivas.kandagatla
2014-05-30 10:25 ` Ulf Hansson
2014-05-30 10:39 ` Srinivas Kandagatla
2014-05-28 13:48 ` [PATCH v4 13/13] mmc: mmci: Add Qcom specific pio_read function srinivas.kandagatla
2014-05-30 11:27 ` Ulf Hansson
2014-05-30 11:44 ` Srinivas Kandagatla
2014-05-30 16:20 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFraGdp2QUHzhjoe5mO6ZyuS08notgkxpRB5A_GpYtyXTw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=chris@printf.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).