From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933225AbcFGVmO (ORCPT ); Tue, 7 Jun 2016 17:42:14 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35899 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbcFGVmM (ORCPT ); Tue, 7 Jun 2016 17:42:12 -0400 MIME-Version: 1.0 In-Reply-To: <374e7cf7-fd34-45a7-db34-0d9337833fac@rock-chips.com> References: <20160606113848.534cbdf7@canb.auug.org.au> <374e7cf7-fd34-45a7-db34-0d9337833fac@rock-chips.com> From: Ulf Hansson Date: Tue, 7 Jun 2016 23:42:09 +0200 Message-ID: Subject: Re: linux-next: build warning after merge of the mmc-uh tree To: Shawn Lin , Stephen Rothwell Cc: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6 June 2016 at 03:51, Shawn Lin wrote: > Hi Stephen, > > On 2016/6/6 9:38, Stephen Rothwell wrote: >> >> Hi Ulf, >> >> After merging the mmc-uh tree, today's linux-next build (x86_64 >> allmodconfig) produced this warning: >> >> In file included from include/linux/err.h:4:0, >> from drivers/mmc/core/mmc.c:13: >> drivers/mmc/core/mmc.c: In function 'mmc_select_hs400es': >> include/linux/err.h:21:49: warning: cast to pointer from integer of >> different size [-Wint-to-pointer-cast] >> #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned >> long)-MAX_ERRNO) >> ^ >> include/linux/compiler.h:170:42: note: in definition of macro 'unlikely' >> # define unlikely(x) __builtin_expect(!!(x), 0) >> ^ >> drivers/mmc/core/mmc.c:1244:6: note: in expansion of macro 'IS_ERR_VALUE' >> if (IS_ERR_VALUE(err)) >> ^ > > > Yup, sorry for this noise. Arnd had removed a lot of IS_ERR_VALUE > abuses, but I forgot to amend this one. > > > Hi Ulf, > > Should I come up with a new fix or you could manually amend it from > "IS_ERR_VALUE(err)" to "err < 0"? :) > >> >> Introduced by commit >> >> 8141f0ace818 ("mmc: core: implement enhanced strobe support") >> >> I think error values now must be "long". >> Thanks for reporting and fixing! I have amended the commit above and published the change on my next branch. Kind regards Uffe