From: Ulf Hansson <ulf.hansson@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pierre Ossman <pierre@ossman.eu>,
linux-mmc <linux-mmc@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] mmc: winbond: don't build on M68K
Date: Tue, 19 Oct 2021 12:59:12 +0200 [thread overview]
Message-ID: <CAPDyKFrhdkp2W6rPorw+0T_dZkcg6TXFcqB2vrWnnfvwdhpKzw@mail.gmail.com> (raw)
In-Reply-To: <20211017175949.23838-1-rdunlap@infradead.org>
On Sun, 17 Oct 2021 at 19:59, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> The Winbond MMC driver fails to build on ARCH=m68k so prevent
> that build config. Silences these build errors:
>
> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
> 212 | dmaflags = claim_dma_lock();
> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
> 215 | release_dma_lock(dmaflags);
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Pierre Ossman <pierre@ossman.eu>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: Arnd Bergmann <arnd@arndb.de>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211015.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20211015/drivers/mmc/host/Kconfig
> @@ -508,7 +508,7 @@ config MMC_OMAP_HS
>
> config MMC_WBSD
> tristate "Winbond W83L51xD SD/MMC Card Interface support"
> - depends on ISA_DMA_API
> + depends on ISA_DMA_API && !M68K
> help
> This selects the Winbond(R) W83L51xD Secure digital and
> Multimedia card Interface.
prev parent reply other threads:[~2021-10-19 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 17:59 [PATCH] mmc: winbond: don't build on M68K Randy Dunlap
2021-10-17 19:20 ` Arnd Bergmann
2021-10-17 19:31 ` Randy Dunlap
2021-10-18 4:18 ` Randy Dunlap
2021-10-19 10:59 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrhdkp2W6rPorw+0T_dZkcg6TXFcqB2vrWnnfvwdhpKzw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).