From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752590AbdCOMsv (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Mar 2017 08:48:51 -0400
Received: from mail-vk0-f53.google.com ([209.85.213.53]:33950 "EHLO
        mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751374AbdCOMsb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Mar 2017 08:48:31 -0400
MIME-Version: 1.0
In-Reply-To: <3a4ce2fd25ed812482b0fc96f50dd305c8f40fe9.1487091464.git-series.gregory.clement@free-electrons.com>
References: <cover.ff78bebe0384f650a51e5e6f0f1dca6e7894b53b.1487091464.git-series.gregory.clement@free-electrons.com>
 <3a4ce2fd25ed812482b0fc96f50dd305c8f40fe9.1487091464.git-series.gregory.clement@free-electrons.com>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Wed, 15 Mar 2017 13:48:29 +0100
Message-ID: <CAPDyKFrmb51cTR7B5S0JkmACH0=bw9+28RmWnjwWkuiT7N4wVw@mail.gmail.com>
Subject: Re: [PATCH v6 07/14] dt: bindings: Add bindings for Marvell Xenon SD
 Host Controller
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Ziji Hu <huziji@marvell.com>, Jimmy Xu <zmxu@marvell.com>,
        Jisheng Zhang <jszhang@marvell.com>, Nadav Haklai <nadavh@marvell.com>,
        Ryan Gao <ygao@marvell.com>, Doug Jones <dougj@marvell.com>,
        Victor Gu <xigu@marvell.com>, "Wei(SOCP) Liu" <liuw@marvell.com>,
        Wilson Ding <dingwei@marvell.com>,
        Yehuda Yitschak <yehuday@marvell.com>, Marcin Wojtas <mw@semihalf.com>,
        Hanna Hawa <hannah@marvell.com>,
        Kostya Porotchkin <kostap@marvell.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[...]

> +
> +Example:
> +- For eMMC:
> +
> +       sdhci@aa0000 {
> +               compatible = "marvell,armada-ap806-sdhci";
> +               reg = <0xaa0000 0x1000>;
> +               interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>
> +               clocks = <&emmc_clk>;
> +               clock-names = "core";
> +               bus-width = <4>;
> +               marvell,xenon-phy-slow-mode;
> +               marvell,xenon-tun-count = <11>;

There's no vmmc-supply here.

How do you control power to the eMMC card?

> +
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               apm_mmccard: mmccard@0 {
> +                       compatible = "mmc-card";
> +                       reg = <0>;
> +               };
> +       };
> +
> +- For SD/SDIO:
> +
> +       sdhci@ab0000 {
> +               compatible = "marvell,armada-cp110-sdhci";
> +               reg = <0xab0000 0x1000>;
> +               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>
> +               vqmmc-supply = <&sd_regulator>;

I guess you know vqmmc is for the I/O voltage.

Again, how do you power the SD/SDIO card? No vmmc?

> +               clocks = <&sdclk>;
> +               clock-names = "core";
> +               bus-width = <4>;
> +               marvell,xenon-tun-count = <9>;
> +       };
> +
> +- For eMMC with compatible "marvell,armada-3700-sdhci":
> +
> +       sdhci@aa0000 {
> +               compatible = "marvell,armada-3700-sdhci";
> +               reg = <0xaa0000 0x1000>,
> +                     <phy_addr 0x4>;
> +               interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>
> +               clocks = <&emmcclk>;
> +               clock-names = "core";
> +               bus-width = <8>;
> +               mmc-ddr-1_8v;
> +               mmc-hs400-1_8v;

Again, no vmmc?

> +
> +               marvell,pad-type = "fixed-1-8v";
> +
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               mmccard: mmccard@0 {
> +                       compatible = "mmc-card";
> +                       reg = <0>;
> +               };
> +       };
> +
> +- For SD/SDIO with compatible "marvell,armada-3700-sdhci":
> +
> +       sdhci@ab0000 {
> +               compatible = "marvell,armada-3700-sdhci";
> +               reg = <0xab0000 0x1000>,
> +                     <phy_addr 0x4>;
> +               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>
> +               vqmmc-supply = <&sd_regulator>;

Again, no vmmc?

> +               clocks = <&sdclk>;
> +               clock-names = "core";
> +               bus-width = <4>;
> +
> +               marvell,pad-type = "sd";
> +       };
> --
> git-series 0.9.1


Kind regards
Uffe