From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DF4C433FE for ; Fri, 4 Dec 2020 15:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C884C22B2D for ; Fri, 4 Dec 2020 15:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730384AbgLDPIs (ORCPT ); Fri, 4 Dec 2020 10:08:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725923AbgLDPIr (ORCPT ); Fri, 4 Dec 2020 10:08:47 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF19C0613D1 for ; Fri, 4 Dec 2020 07:08:01 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id o24so6986677ljj.6 for ; Fri, 04 Dec 2020 07:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ugm6nci6pFkFE2fZ87+ANMj4imEPU508tEZXdZdhnMQ=; b=p10DaLJuegWL96xzPso5dt1qrw6xgzlmwOoM7oDf4usYdru+bxc+QbiI4MBs0YwHmi 6oYgnLKlWYw1ZnKUnLeB7VKUYbBS+z/zYK3cEE1d0bQdYbpNY3CJeydIU/+NIpsbQMW5 5iwMSzHgpA6DWxGvawABSI+IVSiyfjJI41HzjVKEB20clw9Zl5+2gkiTqPKtdHyuxDfl FG3bz3narKSAlfO9TG9AlBHkq7IZCnJrkybg+hhCXgXgw2fjHYLEB+UyYdial0Fwh5hS oYUAqoD6vY+TVj2LU5U7mJ7WDGKQhJXll4/P7SWUXLuCqwzgruZH0zLIrw+poQm498F3 /HIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ugm6nci6pFkFE2fZ87+ANMj4imEPU508tEZXdZdhnMQ=; b=K5Vf2jm0v6glTPhw2D8vnBfcWdJyXLGoYUeuit8zJGD00oxSAAxG+6TgtevtNacjvr mOckhehw2G0q35+zWil7KfoRSMBCd/z4g63PAL0dhNF4qvnDP896vYh/ESyOg1iljsGs JYE2TP6oz+haFftMoh+oUfLB3+JCji3cjUEoKjo2g0z0aYBOct2e/59avctVVJPm6X/H Hwewz9IIWhYLLCh41o0GnPJfoRM9DQRfHJvlM0xJmPImIDeK51wGcn99r/nR0npKwxZz lFTUTQtCT4jvuUnFAFpp2f4HkLjkLFWn6lNYjrmGObnX7iUFcfUt1JjefWD9cfUxQXqI bIIg== X-Gm-Message-State: AOAM533+wfcJYtQfUC+clJgjDNyRUMF5s6WKO/t63Zg1RC7yOTUCZahH 5pm1CsTVcX6qLmjrYyGj6J8THWlckYn6OJcxf9dxAA== X-Google-Smtp-Source: ABdhPJzHIwMUOmMN2sHISP7xlPGum+N6euE1+Z7nIc8dnisLvUyDzFd9N0UJu6A2WfrDU5SsPk6AJhpJ3zSMrsEzK6g= X-Received: by 2002:a2e:80c3:: with SMTP id r3mr3574649ljg.391.1607094479850; Fri, 04 Dec 2020 07:07:59 -0800 (PST) MIME-Version: 1.0 References: <20201118063405.24906-1-wenbin.mei@mediatek.com> <1606266655.11864.7.camel@mhfsdcap03> In-Reply-To: From: Ulf Hansson Date: Fri, 4 Dec 2020 16:07:22 +0100 Message-ID: Subject: Re: [PATCH] mmc: mediatek: Add system suspend/resume interface To: Nicolas Boichat Cc: Wenbin Mei , Chaotian Jing , Matthias Brugger , "linux-mmc@vger.kernel.org" , Linux ARM , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , srv_heupstream , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2020 at 02:29, Nicolas Boichat wrote: > > This causes a 0-day warning (on our chromeos-5.4 backports but I don't > see why upstream would not be affected): > https://groups.google.com/g/cros-kernel-buildreports/c/MfS3SInT5jg/m/Hkzxh_U7AwAJ > > Didn't look at the details of the config, but SET_SYSTEM_SLEEP_PM_OPS > is a noop if CONFIG_PM_SLEEP is not set (while SET_RUNTIME_PM_OPS is > noop-ed by CONFIG_PM). > > So I guess msdc_suspend/msdc_resume should be guarded by > CONFIG_PM_SLEEP instead of CONFIG_PM. Yep. There is already a patch [1] in my queue for this. It uses the _maybe_unused approach (Arnd prefers that and I don't mind). [...] Kind regards Uffe [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20201203222922.1067522-1-arnd@kernel.org/