From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E11C433DB for ; Wed, 20 Jan 2021 00:22:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2612A22AAA for ; Wed, 20 Jan 2021 00:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbhATAWS (ORCPT ); Tue, 19 Jan 2021 19:22:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389221AbhASNoN (ORCPT ); Tue, 19 Jan 2021 08:44:13 -0500 Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49F0CC0613C1 for ; Tue, 19 Jan 2021 05:43:29 -0800 (PST) Received: by mail-ua1-x92d.google.com with SMTP id v23so2388141uam.8 for ; Tue, 19 Jan 2021 05:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iN6LdNddtCPvRlGXitGPbToLS1CEl0fCsvQKN0BpriY=; b=m785Q8QxruIQgi3wqou/VxiBLJ/MVprrsoEl26S11OjFrdkVNeBiBSQzbWq5wc3Bnk WebjUhGaBZup0HmRhG1iHJWgPSiFnLZyBzGWNI20XYsn0k5hKcZiKhImt7Ma53urQp36 Ks0JtGiJq+9ofbOLlSzc0kEaziHNjCAEr7Sz5mI5NogFbrmG7T7P87zGcBBsxFuKgqRL UkP3EvyYE72XCvWqmms377Treyd3hnNcDperSD7wzNJ6RWRciyYfh7wdpACYJEJSpEs9 Xt1aHHTKD5GTRaT1mnwWEyAqr2PoRhM3/wJJgFlU3SZldkU0vszqgdYfJurQCU0hPcoJ 2VRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iN6LdNddtCPvRlGXitGPbToLS1CEl0fCsvQKN0BpriY=; b=dKBoaW77oSFVET6+PHLm86ZNajhaXSAfDp6WGxZgODydkMejF5+WyIuNPlYcKij8+Z gcPcu7uA35MbP5YIZ2Mtzqn+Q5+FJgItmg4IBxFL+0/k9wBzxNIkCPg4BId4y/a/g12Z ScmQ1gnUDHgv48MJukkEn7hEquE1Jru2+kXKJhXLt22wnmnXPD7tjhX8RV6f5JHvuPCY wTLKtzlfWsF2YPF63o4nHLJ8aT3PKUXuH12iHLQbDpap6K6RrpLM4mlM3ygol6mtVXSz Ktm5i9XbK67xuTIttlXXyXV84DgvruZhVuzSXLcCq118Ma+uUydkveSmZDIDJKibT9th b2/A== X-Gm-Message-State: AOAM530MH6OxhvFG6sIXaXBm+vgyUHJRq1dVw4+oktRDd1Kx7gyKUDs+ 9ihHyOhF1u3sjCWItGdxkuHBq3N0BBBllVEel7SAPw== X-Google-Smtp-Source: ABdhPJy8YfW3TY12bJa5OWZwiU4SCjJkJNpC1EcV4z3zof+egZ29HsMFioSINO1T9lcPwSbYO0VGk61l1zVyHuRcmlQ= X-Received: by 2002:a9f:204e:: with SMTP id 72mr2102277uam.19.1611063808290; Tue, 19 Jan 2021 05:43:28 -0800 (PST) MIME-Version: 1.0 References: <20210114152700.21916-1-muhammad.husaini.zulkifli@intel.com> In-Reply-To: <20210114152700.21916-1-muhammad.husaini.zulkifli@intel.com> From: Ulf Hansson Date: Tue, 19 Jan 2021 14:42:52 +0100 Message-ID: Subject: Re: [PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC To: Muhammad Husaini Zulkifli Cc: Mark Brown , Liam Girdwood , Rob Herring , DTML , Adrian Hunter , Michal Simek , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , "Shevchenko, Andriy" , Rashmi.A@intel.com, mahesh.r.vaidya@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jan 2021 at 16:28, Muhammad Husaini Zulkifli wrote: > > Hi, > > This patch series adds Ultra High Speed(UHS-1) Bus Speed Mode Support for Keem Bay SoC SD Card. > Summary of each patches as per below: > > Patch 1: Use of_device_get_match_data() helper to get the match-data. > Patch 2: Convert to use np pointer instead of using pdev->dev.of_node. > Patch 3: Add struct device *dev in probe func(), so that dev pointer can be widely use in probe to make code more readable. > Patch 4: Change from dev_err to dev_err_probe() to avoid spamming logs when probe is deferred. > Patch 5: Export function to be use by device driver to configure i/o voltage rail output which communicate with Trusted Firmware. > Patch 6: Update phy and regulator supply for Keem Bay SoC. > Patch 7: Add DT Binding for Keem Bay SoC SD Regulator. > Patch 8: Add SD Regulator driver to support Keem Bay SoC. This is to model using standard regulator abstraction during voltage operation > as for Keem Bay SoC, i/o voltage rail need to be configure by setting specific bit in the AON_CFG1 Register. > AON_CFG1 Register is a secure register. Direct access to AON_CFG1 register will cause firewall violation in secure system. > Patch 9: Add Ultra High Speed (UHS-1) Support for Keem Bay SOC. For Keem Bay hardware, two regulators are been used to change the I/O bus line voltage which are "vqmmc-supply" and "sdvrail-supply". > > All of these patches was tested with Keem Bay evaluation module board. > > Kindly help to review this patch set. > > Muhammad Husaini Zulkifli (9): > mmc: sdhci-of-arasan: use of_device_get_match_data() > mmc: sdhci-of-arasan: Convert to use np instead of pdev->dev.of_node > mmc: sdhci-of-arasan: Add structure device pointer in probe function > mmc: sdhci-of-arasan: Use dev_err_probe() to avoid spamming logs > firmware: keembay: Add support for Trusted Firmware Service call > dt-bindings: mmc: Update phy and regulator supply for Keem Bay SOC > dt-bindings: regulator: keembay: Add DT binding documentation > regulator: keembay: Add regulator for Keem Bay SoC > mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC > > .../devicetree/bindings/mmc/arasan,sdhci.yaml | 7 +- > .../bindings/regulator/keembay-regulator.yaml | 36 ++ > drivers/mmc/host/sdhci-of-arasan.c | 313 ++++++++++++++++-- > drivers/regulator/Kconfig | 10 + > drivers/regulator/Makefile | 1 + > drivers/regulator/keembay-sd-regulator.c | 112 +++++++ > include/linux/firmware/intel/keembay.h | 82 +++++ > 7 files changed, 532 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/keembay-regulator.yaml > create mode 100644 drivers/regulator/keembay-sd-regulator.c > create mode 100644 include/linux/firmware/intel/keembay.h > > -- > 2.17.1 > Applied patch 1 to patch 4. I assume you will be respinning the rest? Thanks and kind regards Uffe