* [PATCH] rtc: pl031: fix alarm support
[not found] <CGME20200716053452eucas1p24dedd4565b90817c244724b1c52a8329@eucas1p2.samsung.com>
@ 2020-07-16 5:34 ` Marek Szyprowski
2020-07-16 9:06 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2020-07-16 5:34 UTC (permalink / raw)
To: linux-arm-kernel, linux-rtc, linux-kernel
Cc: Marek Szyprowski, Alexandre Belloni, Alessandro Zummo, Linus Walleij
Commit 75a472845196 ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64")
adjusted driver to the new API, but during the conversion a call to enable
alarm irq in set_alarm() was lost. Restore it, what fixes alarm support in
the PL031 RTC driver.
Fixes: 75a472845196 ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/rtc/rtc-pl031.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 40d7450a1ce4..c6b89273feba 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -275,6 +275,7 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
struct pl031_local *ldata = dev_get_drvdata(dev);
writel(rtc_tm_to_time64(&alarm->time), ldata->base + RTC_MR);
+ pl031_alarm_irq_enable(dev, alarm->enabled);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: pl031: fix alarm support
2020-07-16 5:34 ` [PATCH] rtc: pl031: fix alarm support Marek Szyprowski
@ 2020-07-16 9:06 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2020-07-16 9:06 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-arm, linux-rtc, open list, Alexandre Belloni,
Alessandro Zummo, Linus Walleij, Sudeep Holla
On Thu, Jul 16, 2020 at 6:37 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Commit 75a472845196 ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64")
> adjusted driver to the new API, but during the conversion a call to enable
> alarm irq in set_alarm() was lost. Restore it, what fixes alarm support in
> the PL031 RTC driver.
>
I posted exact same fix couple of days back[1]
--
Regards,
Sudeep
[1] http://lore.kernel.org/r/20200714124556.20294-1-sudeep.holla@arm.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-16 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200716053452eucas1p24dedd4565b90817c244724b1c52a8329@eucas1p2.samsung.com>
2020-07-16 5:34 ` [PATCH] rtc: pl031: fix alarm support Marek Szyprowski
2020-07-16 9:06 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).