From: Sam Protsenko <semen.protsenko@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Andi Shyti <andi@etezian.org>, Mark Brown <broonie@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 3/4] spi: dt-bindings: samsung: allow controller-data to be optional
Date: Fri, 14 Jan 2022 18:45:32 +0200 [thread overview]
Message-ID: <CAPLW+4m5+BXD0vDi6YxvE7XYWZ5ej+QdL3OzzSCWG=mqX_sTqA@mail.gmail.com> (raw)
In-Reply-To: <20220111101338.58630-4-krzysztof.kozlowski@canonical.com>
On Tue, 11 Jan 2022 at 12:13, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The Samsung SoC SPI bindings requires to provide controller-data node
> for each of SPI peripheral device nodes. Make this controller-data node
> optional, so DTS could be simpler.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../devicetree/bindings/spi/samsung,spi-peripheral-props.yaml | 1 +
> Documentation/devicetree/bindings/spi/samsung,spi.yaml | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
> index aa5a1f48494b..cadc8a5f061f 100644
> --- a/Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
> @@ -28,6 +28,7 @@ properties:
> - 3: 270 degree phase shift sampling.
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1, 2, 3]
> + default: 0
>
> required:
> - samsung,spi-feedback-delay
> diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
> index da4533feb946..322558818a43 100644
> --- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
> @@ -75,9 +75,6 @@ patternProperties:
> allOf:
> - $ref: spi-peripheral-props.yaml
>
> - required:
> - - controller-data
> -
> unevaluatedProperties: false
>
> required:
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-01-14 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 10:13 [PATCH v2 0/4] spi: dt-bindings: samsung: convert to dtschema Krzysztof Kozlowski
2022-01-11 10:13 ` [PATCH v2 1/4] ARM: dts: exynos: split dmas into array of phandles in Exynos5250 Krzysztof Kozlowski
2022-01-11 10:13 ` [PATCH v2 2/4] spi: dt-bindings: samsung: convert to dtschema Krzysztof Kozlowski
2022-01-12 2:25 ` Rob Herring
2022-01-12 9:52 ` Krzysztof Kozlowski
2022-01-11 10:13 ` [PATCH v2 3/4] spi: dt-bindings: samsung: allow controller-data to be optional Krzysztof Kozlowski
2022-01-12 2:25 ` Rob Herring
2022-01-14 16:45 ` Sam Protsenko [this message]
2022-01-11 10:13 ` [PATCH v2 4/4] spi: s3c64xx: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPLW+4m5+BXD0vDi6YxvE7XYWZ5ej+QdL3OzzSCWG=mqX_sTqA@mail.gmail.com' \
--to=semen.protsenko@linaro.org \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).