From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9441DC4332F for ; Thu, 14 Oct 2021 11:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B13E610F9 for ; Thu, 14 Oct 2021 11:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbhJNL1y (ORCPT ); Thu, 14 Oct 2021 07:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbhJNL1x (ORCPT ); Thu, 14 Oct 2021 07:27:53 -0400 Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF135C061570 for ; Thu, 14 Oct 2021 04:25:48 -0700 (PDT) Received: by mail-ua1-x932.google.com with SMTP id a17so1514339uax.12 for ; Thu, 14 Oct 2021 04:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kSckpstnup2DmrGx5/lGiQeAbXcf7pXBoI+smXRBHM=; b=zQCyOXiH6/zHZe0gpe+oikxi2opvKMhIvaoF8PKvbU8RZzA5iuQU1+t+POg7tOqT+x 7VtjwHdWHxH4EujiGXf3a+uH+KjftQTyeLsb6IFjwGJD5ZP+gVKa9S6HwQ9CjfB24ZJz IyKG88gn8ylL9Ie0hmSQ7jfxPA+9QZT3HIfiEicX+iaP6ZvlmWWq9BUJJWGDpFk7PNnI 8ohuyFlLmEop2upSAltY6YIlWrCUg4qihDjfOMA3K8yuRJ2r17kbVanxS5nWkNVAQkEK ZApuQUBCrkoJ/xwxFiwO+q39FfCoICL4BjNlgh6MMoEMIGqkdqELKFtAOYlh8CDqf5v/ rAyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kSckpstnup2DmrGx5/lGiQeAbXcf7pXBoI+smXRBHM=; b=GGBoJwAakb/9VcNRuvNZGsPOrS7+Ag2agbAym+ts5RUdcYkYnLzif2G6lFmIAlO4fG D6Kqme+s7t+wVlYIBWlqRZw4kYYfEp2PcUpD+nzLvlN2Jo/3GgMM0PZBY0YOPn1M+58h Krh8+WmMvO5fRGGtbVRR1p6ZrdpKCOAZxsQViqG44sl4W6GnyAFOSYRaktg816/jGOiA kc4jB+Zd1LluUea/qnjQIYLHLN+vRo5moD63MPIZlFpx+GE7cGS9O8aY+XK5DXeRZPTc vIWprUw3Fyxzsdom5KPVYsKvZWob7ZZFRQ8EAoZx3IJ5RZ4YaZEs9N+Pf38K4mSfsg6r IQpQ== X-Gm-Message-State: AOAM530EjgCEi6JfI+qIzJAipf7hymnpyRrzJp66lhyRs3ieCGTsOSTm Zm6Qf9L8j1aaGNHQbwRnbAts0YQwKPIoyQIrbFQPNA== X-Google-Smtp-Source: ABdhPJw7tA5Itylbliuf7uRWxKCnJodfXYqfOPUb1k3YcjKxi04jWBTcookWXl0DvsdLYHC8ihFrLDT3VdUPs07klso= X-Received: by 2002:a67:1781:: with SMTP id 123mr5847970vsx.1.1634210747944; Thu, 14 Oct 2021 04:25:47 -0700 (PDT) MIME-Version: 1.0 References: <20211013202110.31701-1-semen.protsenko@linaro.org> <3460c787-0a72-3c37-1075-dfee9cc2c0b3@canonical.com> In-Reply-To: <3460c787-0a72-3c37-1075-dfee9cc2c0b3@canonical.com> From: Sam Protsenko Date: Thu, 14 Oct 2021 14:25:36 +0300 Message-ID: Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: Pass revision reg offsets To: Krzysztof Kozlowski Cc: Rob Herring , Sumit Semwal , Linux Samsung SOC , linux-arm Mailing List , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Oct 2021 at 09:41, Krzysztof Kozlowski wrote: > > On 13/10/2021 22:21, Sam Protsenko wrote: > > Old Exynos SoCs have both Product ID and Revision ID in one single > > register, while new SoCs tend to have two separate registers for those > > IDs. Implement handling of both cases by passing Revision ID register > > offsets in driver data. > > > > Signed-off-by: Sam Protsenko > > --- > > drivers/soc/samsung/exynos-chipid.c | 67 +++++++++++++++++++---- > > include/linux/soc/samsung/exynos-chipid.h | 6 +- > > 2 files changed, 58 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > > index 5c1d0f97f766..7837331fb753 100644 > > --- a/drivers/soc/samsung/exynos-chipid.c > > +++ b/drivers/soc/samsung/exynos-chipid.c > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -24,6 +25,17 @@ > > Include a changelog please. Your patch does not apply and there is no > information on tree which it was based on. > Sorry, my bad. Will do in v3. As for the tree: it's based on the latest mainline/master. I'll double check if patches apply correctly to that before sending v3. Please let me know if you want me to rebase this series on top of some other tree. > > Best regards, > Krzysztof