From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BF2C4320A for ; Fri, 6 Aug 2021 12:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A10C960EBC for ; Fri, 6 Aug 2021 12:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343552AbhHFMHg (ORCPT ); Fri, 6 Aug 2021 08:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbhHFMHe (ORCPT ); Fri, 6 Aug 2021 08:07:34 -0400 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E99BC06179C for ; Fri, 6 Aug 2021 05:07:18 -0700 (PDT) Received: by mail-vk1-xa33.google.com with SMTP id l6so1993327vkr.8 for ; Fri, 06 Aug 2021 05:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gqt1epFIpisC2AaHHhW6rQDffCjpf7dOna6ffmSk6Pk=; b=PYJAKwkdkYB3CHc5LDXvhWbDOQJLweH24aoRxbmL5aGyMP+ptY6zkNMm9jyNkNh/x6 RfKKUD4+yzflM1ivwtPUe6HAeP77SV8B1kOnZXC3EUjW3F938WR9ckq7RsbMdMquZPyu +1kGAaHyiYSZfaF5lvHTuQj2Yen2pjd7W1m8irpNPPQqu7F6PocYJ4kJAXJA/bTi0izy XuIBzfhI2b6ir/WJ4fS/OzuAZtCQYCcFRrEvJKqVlMoqPmMVWlS9+qfzf1GyAvrSXOdj QbbG7sLfs8WxjzTuj1yhaoN32qRvRbSQV8lsuQx6yc9pgS3IJwOO4m8oBvCEdMgKOtpU KIGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gqt1epFIpisC2AaHHhW6rQDffCjpf7dOna6ffmSk6Pk=; b=dd20xzeSMzOxbPSaLv11btEwqEkyxQG4uCSe5Yy2Ly51529ZBVM/4bc8Jo6CY7TB8q r3CSBOgBPI6vWsWuDm6HLG/rO0tf8HeDwLdB1kisZE8+zlLMtzajA+NGAabnPBY6VZat hpFzGUW39YKfKFFxKifISPKTaooIjt6qNUUM3y9Z+Dh8heAmHxYZI3ofLmx/kpDISvGy vDNoH28sKX5qFnGFlqrMi9USt1eh1jgIwg4hoBHGsim7ZLoefVXWDCV7+GBvgBjU7QqP traMxwfYJRRaRniH3+T0SOIqaiVaqSePUGE9fbzGcpumJOidTz0u3cg8whZZuHAIefl6 vwUA== X-Gm-Message-State: AOAM531HKUAOQELdItb5ZGgfENdqvIdtYTVXPgHMAA8nIIZVc3yIri/e Bvg8924sObQmay+zxaYYCFu1mjcGoFbCAauKgP5DTA== X-Google-Smtp-Source: ABdhPJyVUu5pNYaiqHzD1lZRaIELMMeDhL78lKcvRbfSsFFyQf0INxCFmIc71nMHI4l0mwKZQZl01NRyAzD0dfHYjsM= X-Received: by 2002:a1f:f441:: with SMTP id s62mr7388749vkh.8.1628251637291; Fri, 06 Aug 2021 05:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-13-semen.protsenko@linaro.org> <455cfb5e-dff7-a5c0-3875-49abe3e900f3@canonical.com> <68734f6c-fc76-595c-8d34-8924dbbbb845@canonical.com> In-Reply-To: <68734f6c-fc76-595c-8d34-8924dbbbb845@canonical.com> From: Sam Protsenko Date: Fri, 6 Aug 2021 15:07:05 +0300 Message-ID: Subject: Re: [PATCH 12/12] arm64: dts: exynos: Add Exynos850 SoC support To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Aug 2021 at 10:49, Krzysztof Kozlowski wrote: > > On 06/08/2021 01:06, Sam Protsenko wrote: > > On Sat, 31 Jul 2021 at 12:03, Krzysztof Kozlowski > > wrote: > > > >>> > >>> This patch adds minimal SoC support. Particular board device tree files > >>> can include exynos850.dtsi file to get SoC related nodes, and then > >>> reference those nodes further as needed. > >>> > >>> Signed-off-by: Sam Protsenko > >>> --- > >>> .../boot/dts/exynos/exynos850-pinctrl.dtsi | 782 ++++++++++++++++++ > >>> arch/arm64/boot/dts/exynos/exynos850-usi.dtsi | 30 + > >>> arch/arm64/boot/dts/exynos/exynos850.dtsi | 245 ++++++ > >> > >> Not buildable. Missing Makefile, missing DTS. Please submit with initial > >> DTS, otherwise no one is able to verify it even compiles. > >> > > > > This device is not available for purchase yet. I'll send the patch for > > board dts once it's announced. I can do all the testing for now, if > > you have any specific requests. Would it be possible for us to review > > and apply only SoC support for now? Will send v2 soon... > > What you propose is equal to adding a driver (C source code) without > ability to compile it. What's the point of having it in the kernel? It's > unverifiable, unbuildable and unusable. > Yes, I understand. That's adding code with no users, and it's not a good practice. > We can review the DTSI however merging has to be with a DTS. Usually the > SoC vendor adds first an evalkit (e.g. SMDK board). Maybe you have one > for Exynos850? Otherwise if you cannot disclose the actual board, the > DTSI will have to wait. You can submit drivers, though. > Sure, let's go this way. I'll send v2 soon. Improving patches and having Reviewed-by tag for those would good enough for me at this point. I'll continue to prepare another Exynos850 related patches until the actual board is announced, like proper clock driver, reset, MMC, etc. Is it ok if I send those for a review too (so I can fix all issues ahead)? And should I maybe add RFC tag for those? Anyway, once the board is out, I'll re-send this series including board's dts, as you suggested. Good thing is, I'll have some time to address any outstanding issues by that time, hopefully. Thanks! > > > >>> 3 files changed, 1057 insertions(+) > >>> create mode 100644 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > >>> create mode 100644 arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > >>> create mode 100644 arch/arm64/boot/dts/exynos/exynos850.dtsi > >>> > >>> diff --git a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > >>> new file mode 100644 > >>> index 000000000000..4cf0a22cc6db > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > >>> @@ -0,0 +1,782 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Samsung's Exynos850 SoC pin-mux and pin-config device tree source > >>> + * > >>> + * Copyright (C) 2017 Samsung Electronics Co., Ltd. > >>> + * Copyright (C) 2021 Linaro Ltd. > >>> + * > >>> + * Samsung's Exynos850 SoC pin-mux and pin-config options are listed as device > >>> + * tree nodes in this file. > >>> + */ > >>> + > >>> +#include > >>> + > >>> +/ { > >>> + /* ALIVE */ > >>> + pinctrl@11850000 { > >>> + gpa0: gpa0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >> > >> That's odd a little, why three cells? How this would be used/referenced? > >> > > > > Fixed. You are right, irq_domain_xlate_twocell() is used in > > pinctrl-exynos.c. Btw, that fixed the use-case when gpX is specified > > as interrupt-parrent for other nodes. > > > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + ; > >>> + }; > >>> + > >>> + gpa1: gpa1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + ; > >>> + }; > >>> + > >>> + gpa2: gpa2 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + ; > >>> + }; > >>> + > >>> + gpa3: gpa3 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + , > >>> + ; > >>> + }; > >>> + > >>> + gpa4: gpa4 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + , > >>> + , > >>> + , > >>> + ; > >>> + }; > >>> + > >>> + gpq0: gpq0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + /* USI_PERI_UART_DBG */ > >>> + uart0_bus: uart0-bus { > >>> + samsung,pins = "gpq0-0", "gpq0-1"; > >>> + samsung,pin-function = <2>; > >> > >> EXYNOS_PIN_FUNC_2 > >> > > > > Done, thanks. > > > >>> + samsung,pin-pud = <0>; > >> > >> EXYNOS_PIN_PULL_xx? > >> > > > > Yes, replaced pin-pud values with these constants, thanks. Won't touch > > pin-drv properties, though, as different domains have different > > meanings for the same values, so don't want to introduce the whole > > bunch of consts. > > > >>> + }; > >>> + > >>> + decon_f_te_on: decon_f_te_on { > >> > >> 1. Where is it used? > >> 2. Use hyphens in node names. > >> Please build it with W=1 and fix the warnings. > >> > > > > decon* nodes seem like leftover from vendor kernel. Those are not > > connected anywhere on my board, so I removed those nodes. > > > > Also fixed node names as you suggested, and fixed all stuff found with > > W=1 build, thanks for reminding me that. > > > >>> + samsung,pins = "gpa4-1"; > >> > >> Order the nodes based on first pin name, so: > >> i2c5_bus > >> i2c6_bus > >> decon_f_te_on > >> uart0_bus > >> > > > > Done. Also rearranged the nodes in that way for other pinctrl domains. > > > >>> + samsung,pin-function = <0xf>; > >>> + }; > >>> + > >>> + decon_f_te_off: decon_f_te_off { > >> > >> Where is it used? > >> > > > > Removed, as explained above. > > > >>> + samsung,pins = "gpa4-1"; > >>> + samsung,pin-function = <0x0>; > >>> + }; > >>> + > >>> + /* I2C_5 | CAM_PMIC_I2C */ > >> > >> This comment is confusing. I2C-5 is obvious from node name and label. > >> CAM_PMIC_I2C does not look like property of SoC but board. > >> > > > > Yeah, unfortunately this confusing I2C naming (CAM_PMIC_I2C and > > MOTOR_I2C) actually comes from TRM and SoC schematic symbol. > > Schematic symbol of SoC? Interesting document... What do you have there? > Internals of SoC? > Yeah, of course schematic symbol can't be considered a document :) What I meant was it might be confusing for users to see one bus name in TRM and schematics, and another one in device tree. > > > So in > > Device Tree it's called just i2c5 and i2c6 (because it's a regular I2C > > really), but in TRM it's a mix of both names. I guess it's just a poor > > pin function naming, done by SoC designers. > > > > That said, I suggest changing these comments to something like this: > > > > /* I2C5 (also called CAM_PMIC_I2C in TRM) */ > > /* I2C6 (also called MOTOR_I2C in TRM) */ > > OK, assuming that by TRM you mean Exynos850 TRM. > > > > >>> + i2c5_bus: i2c5-bus { > >>> + samsung,pins = "gpa3-5", "gpa3-6"; > >>> + samsung,pin-function = <3>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* I2C_6 | MOTOR_I2C */ > >>> + i2c6_bus: i2c6-bus { > >>> + samsung,pins = "gpa3-7", "gpa4-0"; > >>> + samsung,pin-function = <3>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + }; > >>> + > >>> + /* CMGP */ > >>> + pinctrl@11c30000 { > >>> + gpm0: gpm0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + gpm1: gpm1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + gpm2: gpm2 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + gpm3: gpm3 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + gpm4: gpm4 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + gpm5: gpm5 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <3>; > >>> + interrupt-parent = <&gic>; > >>> + interrupts = > >>> + ; > >>> + }; > >>> + > >>> + /* usi_cmgp00 */ > >>> + hsi2c3_bus: hsi2c3-bus { > >>> + samsung,pins = "gpm0-0", "gpm1-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* usi_cmgp01 */ > >>> + hsi2c4_bus: hsi2c4-bus { > >>> + samsung,pins = "gpm4-0", "gpm5-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* spi usi_cmgp00 */ > >>> + spi1_bus: spi1-bus { > >>> + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi1_cs: spi1-cs { > >>> + samsung,pins = "gpm3-0"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi1_cs_func: spi1-cs-func { > >>> + samsung,pins = "gpm3-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* spi usi_cmgp01 */ > >>> + spi2_bus: spi2-bus { > >>> + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi2_cs: spi2-cs { > >>> + samsung,pins = "gpm7-0"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi2_cs_func: spi2-cs-func { > >>> + samsung,pins = "gpm7-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* usi_cmgp00_uart */ > >>> + uart1_bus_single: uart1-bus { > >>> + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0", "gpm3-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + }; > >>> + > >>> + uart1_bus_dual: uart1-bus-dual { > >>> + samsung,pins = "gpm0-0", "gpm1-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + }; > >>> + > >>> + /* usi_cmgp01_uart */ > >>> + uart2_bus_single: uart2-bus { > >>> + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0", "gpm7-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + }; > >>> + > >>> + uart2_bus_dual: uart2-bus-dual { > >>> + samsung,pins = "gpm4-0", "gpm5-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + }; > >>> + }; > >>> + > >>> + /* AUD */ > >>> + pinctrl@14a60000 { > >>> + gpb0: gpb0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpb1: gpb1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + aud_codec_mclk: aud-codec-mclk { > >>> + samsung,pins = "gpb0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_codec_mclk_idle: aud-codec-mclk-idle { > >>> + samsung,pins = "gpb0-0"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_i2s0_bus: aud-i2s0-bus { > >>> + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_i2s0_idle: aud-i2s0-idle { > >>> + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_i2s1_bus: aud-i2s1-bus { > >>> + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_i2s1_idle: aud-i2s1-idle { > >>> + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_fm_bus: aud-fm-bus { > >>> + samsung,pins = "gpb1-4"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + > >>> + aud_fm_idle: aud-fm-idle { > >>> + samsung,pins = "gpb1-4"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <1>; > >>> + }; > >>> + }; > >>> + > >>> + /* HSI */ > >>> + pinctrl@13430000 { > >>> + gpf2: gpf2 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + sd2_clk: sd2-clk { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd2_cmd: sd2-cmd { > >>> + samsung,pins = "gpf2-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd2_bus1: sd2-bus-width1 { > >>> + samsung,pins = "gpf2-2"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd2_bus4: sd2-bus-width4 { > >>> + samsung,pins = "gpf2-3", "gpf2-4", "gpf2-5"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_1x: sd2-clk_fast_slew_rate_1x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_1_5x: sd2-clk_fast_slew_rate_1_5x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <1>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_2x: sd2-clk_fast_slew_rate_2x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_2_5x: sd2-clk_fast_slew_rate_2_5x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_3x: sd2-clk_fast_slew_rate_3x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <4>; > >>> + }; > >>> + > >>> + sd2_clk_fast_slew_rate_4x: sd2-clk_fast_slew_rate_4x { > >>> + samsung,pins = "gpf2-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <5>; > >>> + }; > >>> + > >>> + sd2_pins_as_pdn: sd2-pins-as-pdn { > >>> + samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3", > >>> + "gpf2-4", "gpf2-5"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <2>; > >>> + }; > >>> + > >> > >> No need for blank line. > >> > > > > Fixed. > > > >>> + }; > >>> + > >>> + /* CORE */ > >>> + pinctrl@12070000 { > >>> + gpf0: gpf0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + sd0_clk: sd0-clk { > >>> + samsung,pins = "gpf0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_cmd: sd0-cmd { > >>> + samsung,pins = "gpf0-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_rdqs: sd0-rdqs { > >>> + samsung,pins = "gpf0-2"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <1>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_nreset: sd0-nreset { > >>> + samsung,pins = "gpf0-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_clk_fast_slew_rate_1x: sd0-clk_fast_slew_rate_1x { > >>> + samsung,pins = "gpf0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <1>; > >>> + }; > >>> + > >>> + sd0_clk_fast_slew_rate_2x: sd0-clk_fast_slew_rate_2x { > >>> + samsung,pins = "gpf0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd0_clk_fast_slew_rate_3x: sd0-clk_fast_slew_rate_3x { > >>> + samsung,pins = "gpf0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sd0_clk_fast_slew_rate_4x: sd0-clk_fast_slew_rate_4x { > >>> + samsung,pins = "gpf0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + gpf1: gpf1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + sd0_bus1: sd0-bus-width1 { > >>> + samsung,pins = "gpf1-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_bus4: sd0-bus-width4 { > >>> + samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + > >>> + sd0_bus8: sd0-bus-width8 { > >>> + samsung,pins = "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <3>; > >>> + }; > >>> + }; > >>> + > >>> + /* PERI */ > >>> + pinctrl@139b0000 { > >>> + gpg0: gpg0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpp0: gpp0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + gpp1: gpp1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpp2: gpp2 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpg1: gpg1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpg2: gpg2 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpg3: gpg3 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpc0: gpc0 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + gpc1: gpc1 { > >>> + gpio-controller; > >>> + #gpio-cells = <2>; > >>> + > >>> + interrupt-controller; > >>> + #interrupt-cells = <2>; > >>> + }; > >>> + > >>> + xclkout: xclkout { > >>> + samsung,pins = "gpq0-2"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + }; > >>> + > >>> + /* usi_hsi2c_0 */ > >> > >> Comment seems to duplicate node name/label. > >> > > > > I think the comment is useful, maybe just designed poorly. It's > > pointing out that this HS-I2C block is based on USI IP-core. Basically > > we have 7 USI blocks in this SoC: > > - 5 USIs that pre-defined: HSI2C0, HSI2C1, HSI2C2, UART0 and SPI0; > > although AFAIU they can be changed via System Register as well, but > > seems like nobody does that > > - 2 USIs from CMGP blocks (CMGP0 and CMGP1), which are actually configurable > > > > I will revise all such comments like this, just to show those blocks > > are based on USI design: > > > > /* USI: HSI2C0 */ > > OK > > > > > At least when I was bringing up this board, I was really confused for > > long time about this USI business. So I'm sure some kind of comments > > might be actually helpful. And that's one reason to keep > > exynos850-usi.dtsi file: although I removed it for now, squashing it > > into exynos850.dtsi, I think it might be a good idea to bring that > > back once all USI nodes are described. Just thinking aloud :) > > > >>> + hsi2c0_bus: hsi2c0-bus { > >>> + samsung,pins = "gpc1-0", "gpc1-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* usi_hsi2c_1 */ > >>> + hsi2c1_bus: hsi2c1-bus { > >>> + samsung,pins = "gpc1-2", "gpc1-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* usi_hsi2c_2 */ > >>> + hsi2c2_bus: hsi2c2-bus { > >>> + samsung,pins = "gpc1-4", "gpc1-5"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + /* usi_spi_0 */ > >>> + spi0_bus: spi0-bus { > >>> + samsung,pins = "gpp2-0", "gpp2-2", "gpp2-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi0_cs: spi0-cs { > >>> + samsung,pins = "gpp2-1"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + spi0_cs_func: spi0-cs-func { > >>> + samsung,pins = "gpp2-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + i2c0_bus: i2c0-bus { > >>> + samsung,pins = "gpp0-0", "gpp0-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + i2c1_bus: i2c1-bus { > >>> + samsung,pins = "gpp0-2", "gpp0-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + i2c2_bus: i2c2-bus { > >>> + samsung,pins = "gpp0-4", "gpp0-5"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + i2c3_bus: i2c3-bus { > >>> + samsung,pins = "gpp1-0", "gpp1-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + i2c4_bus: i2c4-bus { > >>> + samsung,pins = "gpp1-2", "gpp1-3"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <3>; > >>> + samsung,pin-drv = <0>; > >>> + }; > >>> + > >>> + fm_lna_en: fm-lna-en { > >>> + samsung,pins = "gpg2-3"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-val = <0>; > >>> + }; > >>> + > >>> + sensor_mclk0_in: sensor-mclk0-in { > >>> + samsung,pins = "gpc0-0"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk0_out: sensor-mclk0-out { > >>> + samsung,pins = "gpc0-0"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <1>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk0_fn: sensor-mclk0-fn { > >> > >> No, seriously. What sensor is it? In SoC? > >> > > > > In this context, "sensor" stands for "camera". Of course, it resides > > (or rather *may* reside) outside of the SoC. This is just useful pin > > configuration for camera master clock lines (3 of them). On schematic > > those 3 lines are grouped into "MCLK" block, and those pins main > > function is CAM_MCLK. I guess it makes sense to keep those > > definitions, as I doubt somebody would actually consider using those > > lines for somthing else. Or I can remove all those sensor* > > definitions, if you'd like, then those can be added later, when camera > > support cames in. > > Hmmm, indeed we define in pinctrl useful typical functions and I > understand this one is such. Let's keep them then. > > > > >>> + samsung,pins = "gpc0-0"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk1_in: sensor-mclk1-in { > >>> + samsung,pins = "gpc0-1"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk1_out: sensor-mclk1-out { > >>> + samsung,pins = "gpc0-1"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <1>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk1_fn: sensor-mclk1-fn { > >>> + samsung,pins = "gpc0-1"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk2_in: sensor-mclk2-in { > >>> + samsung,pins = "gpc0-2"; > >>> + samsung,pin-function = <0>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk2_out: sensor-mclk2-out { > >>> + samsung,pins = "gpc0-2"; > >>> + samsung,pin-function = <1>; > >>> + samsung,pin-pud = <1>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + > >>> + sensor_mclk2_fn: sensor-mclk2-fn { > >>> + samsung,pins = "gpc0-2"; > >>> + samsung,pin-function = <2>; > >>> + samsung,pin-pud = <0>; > >>> + samsung,pin-drv = <2>; > >>> + }; > >>> + }; > >>> +}; > >>> diff --git a/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > >>> new file mode 100644 > >>> index 000000000000..fb243e0a6260 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > >>> @@ -0,0 +1,30 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Samsung's Exynos850 SoC USI device tree source > >>> + * > >>> + * Copyright (C) 2019 Samsung Electronics Co., Ltd. > >>> + * Copyright (C) 2021 Linaro Ltd. > >>> + * > >>> + * Samsung's Exynos850 SoC USI channels are listed in this file as device tree > >>> + * nodes. > >> > >> Why here not in exynos850.dtsi? > >> > > > > Yeah, you're right. As it's only serial_0 for now, I've moved that > > into exynos850.dtsi and removed exynos850-usi.dtsi. > > > >>> + */ > >>> + > >>> +#include > >>> + > >>> +/ { > >>> + aliases { > >>> + uart0 = &serial_0; > >>> + }; > >>> + > >>> + /* USI_UART */ > >>> + serial_0: uart@13820000 { > >> > >> This should ne in soc node. > >> > > > > Done. > > > >>> + compatible = "samsung,exynos850-uart"; > >>> + reg = <0x0 0x13820000 0x100>; > >>> + interrupts = ; > >>> + pinctrl-names = "default"; > >>> + pinctrl-0 = <&uart0_bus>; > >>> + clocks = <&clock GATE_UART_QCH>, <&clock DOUT_UART>; > >>> + clock-names = "gate_uart_clk0", "uart"; > >>> + status = "disabled"; > >>> + }; > >>> +}; > >>> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > >>> new file mode 100644 > >>> index 000000000000..ed2d1c8ae0c3 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > >>> @@ -0,0 +1,245 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 > >>> +/* > >>> + * Samsung Exynos850 SoC device tree source > >>> + * > >>> + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > >>> + * Copyright (C) 2021 Linaro Ltd. > >>> + * > >>> + * Samsung Exynos850 SoC device nodes are listed in this file. > >>> + * Exynos based board files can include this file and provide > >>> + * values for board specific bindings. > >>> + */ > >>> + > >>> +#include > >>> +#include > >>> +#include "exynos850-pinctrl.dtsi" > >>> +#include "exynos850-usi.dtsi" > >>> + > >>> +/ { > >> > >> Add a comment like: > >> /* Also known under engineering name exynos3830 */ > >> > > > > Sure. > > > >>> + compatible = "samsung,exynos850"; > >> > >> Undocumented compatible. Checkpatch should complain. > >> > > > > It actually doesn't, though it does complain about other undocumented > > compatibles. I understand that it should be documented in > > samsung-boards.yaml, but is it ok with you if I do that later, when > > adding some actual board's dts? Just don't want to have two patches > > for that. > > We're back to the first question - it needs to come with DTS and then > you document both compatibles. > > Best regards, > Krzysztof