Re: [patch v8 5/9] sched: update cpu load after task_tick.

From: Paul Turner <pjt@google.com>
To: Alex Shi <alex.shi@intel.com>
Cc: "Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Mike Galbraith" <efault@gmx.de>,
	"Morten Rasmussen" <morten.rasmussen@arm.com>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	"Preeti U Murthy" <preeti@linux.vnet.ibm.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Mel Gorman" <mgorman@suse.de>, "Rik van Riel" <riel@redhat.com>,
	"Michael Wang" <wangyun@linux.vnet.ibm.com>,
	"Jason Low" <jason.low2@hp.com>,
	"Changlong Xie" <changlongx.xie@intel.com>,
	sgruszka@redhat.com, "Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [patch v8 5/9] sched: update cpu load after task_tick.
Date: Mon, 17 Jun 2013 04:54:02 -0700	[thread overview]
Message-ID: <CAPM31RKkBHkL69K4AnEmmQcMaj2rfs6cWbc2WksT9G8=btjsQw@mail.gmail.com> (raw)
In-Reply-To: <1370589652-24549-6-git-send-email-alex.shi@intel.com>

On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi <alex.shi@intel.com> wrote:
> To get the latest runnable info, we need do this cpuload update after
> task_tick.
>
> Signed-off-by: Alex Shi <alex.shi@intel.com>

Reviewed-by: Paul Turner <pjt@google.com>

> ---
>  kernel/sched/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 6f226c2..05176b8 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2152,8 +2152,8 @@ void scheduler_tick(void)
>
>         raw_spin_lock(&rq->lock);
>         update_rq_clock(rq);
> -       update_cpu_load_active(rq);
>         curr->sched_class->task_tick(rq, curr, 0);
> +       update_cpu_load_active(rq);
>         raw_spin_unlock(&rq->lock);
>
>         perf_event_task_tick();
> --
> 1.7.12
>