From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8008EC433DF for ; Thu, 28 May 2020 20:30:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5996B2088E for ; Thu, 28 May 2020 20:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEvgWoFZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407262AbgE1UaU (ORCPT ); Thu, 28 May 2020 16:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407191AbgE1U35 (ORCPT ); Thu, 28 May 2020 16:29:57 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2BA7C08C5C6; Thu, 28 May 2020 13:29:54 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id k11so1351089ejr.9; Thu, 28 May 2020 13:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jubbYLeXvUFozWJ2dGJv9BknYxFFydhKvrR5dq59bYc=; b=lEvgWoFZbktWMVKAq2OjNpu1lz4P+/FVRhfbKVnDN42Z4qcQJBgHPikzonc97XyPOb hI6vQxJIfmoQcwlXslbmhgNwhMXV3k6TJd9ytmzYg6kv7uGgWWMGgtCg9CmjToKoXKDf OqgXMZJ1ssR7O4C5rTfnmZUgl2rNmJ6SYStDAd72pGxrg/1pLxVnkP53VdVIovQ2pqZq aorHs+mPxzHeUHZziDmqb9ail4EOQx/Txh5AQX1QhPCg1fAi+IMOTp0RLkHaDWi87Qwg cU22Sanfo7Wa/mm36qpi4cbk4nmS/0CS6Oj920ctvl0TmrH58OfL0MK0qqKc7CHQID5D n4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jubbYLeXvUFozWJ2dGJv9BknYxFFydhKvrR5dq59bYc=; b=sTa3LdDehcRjOyKUMFPQl1/w98ngv7l826QReU+r5CoDi5zx0Kl50+2t+Zzmf/OmiD InmRDTgZOz8K+pyfm50Q8tPiUtmbA0h8eaEoy4MbebgOr/fCxwjvWg8NBWvKRmFvfmf/ MIi6Mny8QKdQPZgQrloIYafCs24cRlpwaQ78aek9hFEWxB6k3yP63uYD8V43trrVMk5m m68H5BwFociF/ZFQbFs5XSxCSxAGpdF/lKsQXL3odWtwqw2uAnfp+qll5ZDRXOZS9SUj lX9KMVMwF8oHOVFM8RHiLYZKpPOOqxxlHxAeAZWUzp9zIgTj3knLcAQif7RFxRwfkW0F +23w== X-Gm-Message-State: AOAM531SJYbNLxwJu12ntH/1y7evBj4kOhQEbxkqbJUlUg9o5KrWQorP KZllKpQifyURi0PSam/l7y5vUflCn3zqTR/18K0hcJII X-Google-Smtp-Source: ABdhPJwBNoY2pCnaFWbbxsOYLa0Gov4fBr3XnIMoiOKDk6nJlaCbfvysQTfONH9RBPB7UA/a5zYQ94brdDrD2jJgEKU= X-Received: by 2002:a17:906:c9d6:: with SMTP id hk22mr4657328ejb.101.1590697793606; Thu, 28 May 2020 13:29:53 -0700 (PDT) MIME-Version: 1.0 References: <20200528054043.621510-1-hch@lst.de> <20200528193340.GR23230@ZenIV.linux.org.uk> In-Reply-To: <20200528193340.GR23230@ZenIV.linux.org.uk> From: Dave Airlie Date: Fri, 29 May 2020 06:29:42 +1000 Message-ID: Subject: Re: clean up kernel_{read,write} & friends v2 To: Al Viro Cc: Joe Perches , Linus Torvalds , Christoph Hellwig , Ian Kent , David Howells , Linux Kernel Mailing List , linux-fsdevel , LSM List , NetFilter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2020 at 05:35, Al Viro wrote: > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > Hard limits at 80 really don't work well, especially with > > some of the 25+ character length identifiers used today. > > IMO any such identifier is a good reason for a warning. > > The litmus test is actually very simple: how unpleasant would it be > to mention the identifiers while discussing the code over the phone? That doesn't make sense though, if you write the full english words out for something it'll be long but easier to say over the phone, if you use shortened kernel abbreviations it will be short but you'd have to read out every letter. To take an example: this would read pretty well on the phone, maybe params could be parameters amdgpu_atombios_get_leakage_vddc_based_on_leakage_params vddc would be a stumbler. try saying O_CREAT over the phone to someone not steeped in UNIX folklore. Dave.