From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbaKKCY2 (ORCPT ); Mon, 10 Nov 2014 21:24:28 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:52810 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbaKKCY0 (ORCPT ); Mon, 10 Nov 2014 21:24:26 -0500 MIME-Version: 1.0 In-Reply-To: References: <20141020133555.GA27111@redhat.com> <1413813529-11044-1-git-send-email-cornelia.huck@de.ibm.com> <20141020140508.GA11004@redhat.com> Date: Tue, 11 Nov 2014 12:24:24 +1000 Message-ID: Subject: Re: [PATCH] virtio_console: move early VQ enablement From: Dave Airlie To: Josh Boyer Cc: "Michael S. Tsirkin" , Cornelia Huck , Rusty Russell , Thomas Graf , "Linux-Kernel@Vger. Kernel. Org" , virtualization@lists.linux-foundation.org, KVM list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 October 2014 03:09, Josh Boyer wrote: > On Mon, Oct 20, 2014 at 10:05 AM, Michael S. Tsirkin wrote: >> On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote: >>> Commit f5866db6 (virtio_console: enable VQs early) tried to make >>> sure that DRIVER_OK was set when virtio_console started using its >>> virtqueues. Doing this in add_port(), however, means that we try >>> to set DRIVER_OK again when when a port is dynamically added after >>> the probe function is done. >>> >>> Let's move virtio_device_ready() to the probe function just before >>> trying to use the virtqueues instead. This is fine as nothing can >>> fail inbetween. >>> >>> Reported-by: Thomas Graf >>> Reviewed-by: Michael S. Tsirkin >>> Signed-off-by: Cornelia Huck >> >> Thanks! >> >> Acked-by: Michael S. Tsirkin >> Tested-by: Michael S. Tsirkin > > This fixed my KVM guest boot issue with 3.18-rc1. Thanks for such a quick fix. > > Tested-by: Josh Boyer ping So who's merging this? Rusty? still happens in -rc4. Dave.