From: Dave Airlie <airlied@gmail.com>
To: Frediano Ziglio <fziglio@redhat.com>
Cc: spice-devel <spice-devel@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
Dave Airlie <airlied@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Spice-devel] [PATCH 01/11] Do not cause spice-server to clean our objects
Date: Thu, 28 May 2015 13:08:03 +1000 [thread overview]
Message-ID: <CAPM=9tz0+OEhU=JV4fNgy3ruGxemWzHkRovEmnPzdbGGX+uivw@mail.gmail.com> (raw)
In-Reply-To: <1432721046-4418-2-git-send-email-fziglio@redhat.com>
On 27 May 2015 at 20:03, Frediano Ziglio <fziglio@redhat.com> wrote:
> If objects are moved back from system memory to VRAM (and spice id
> created again) memory is already initialized so we need to set flag
> to not clear memory.
> If you don't do it after a while using desktop many images turns to
> black or transparents.
Good point,
Reviewed-by: Dave Airlie <airlied@redhat.com>
>
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> ---
> qxl/qxl_cmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qxl/qxl_cmd.c b/qxl/qxl_cmd.c
> index bd5404e..85ed5dc 100644
> --- a/qxl/qxl_cmd.c
> +++ b/qxl/qxl_cmd.c
> @@ -502,6 +502,7 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
>
> cmd = (struct qxl_surface_cmd *)qxl_release_map(qdev, release);
> cmd->type = QXL_SURFACE_CMD_CREATE;
> + cmd->flags = QXL_SURF_FLAG_KEEP_DATA;
> cmd->u.surface_create.format = surf->surf.format;
> cmd->u.surface_create.width = surf->surf.width;
> cmd->u.surface_create.height = surf->surf.height;
> --
> 2.1.0
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
next prev parent reply other threads:[~2015-05-28 3:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 10:03 [PATCH 00/11] Miscellaneous stability patches Frediano Ziglio
2015-05-27 10:03 ` [PATCH 01/11] Do not cause spice-server to clean our objects Frediano Ziglio
2015-05-28 3:08 ` Dave Airlie [this message]
2015-05-27 10:03 ` [PATCH 02/11] Do not leak memory if qxl_release_list_add fails Frediano Ziglio
2015-05-28 3:09 ` [Spice-devel] " Dave Airlie
2015-05-27 10:03 ` [PATCH 03/11] Fix print statement not using uninitialized variable Frediano Ziglio
2015-05-28 3:10 ` [Spice-devel] " Dave Airlie
2015-05-27 10:03 ` [PATCH 04/11] Avoid double free on error Frediano Ziglio
2015-05-28 3:11 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 05/11] Handle all errors in qxl_surface_evict Frediano Ziglio
2015-05-28 3:16 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 06/11] Fix return for qxl_release_alloc Frediano Ziglio
2015-05-28 3:17 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 07/11] Handle correctly failures in qxl_alloc_relase_reserved Frediano Ziglio
2015-05-28 3:20 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 08/11] Remove format string errors Frediano Ziglio
2015-05-28 3:20 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 09/11] Move main reference counter to GEM object instead of TTM ones Frediano Ziglio
2015-05-28 3:31 ` [Spice-devel] " Dave Airlie
2015-05-29 11:11 ` Frediano Ziglio
2015-05-27 10:04 ` [PATCH 10/11] Simplify cleaning qxl processing command Frediano Ziglio
2015-05-28 3:32 ` [Spice-devel] " Dave Airlie
2015-05-27 10:04 ` [PATCH 11/11] Propagate correctly errors from qxlhw_handle_to_bo Frediano Ziglio
2015-05-28 3:33 ` [Spice-devel] " Dave Airlie
2015-05-27 12:47 ` [PATCH 00/11] Miscellaneous stability patches Josh Boyer
2015-05-27 12:49 ` Josh Boyer
2015-05-27 13:28 ` Frediano Ziglio
2015-05-28 3:07 ` [Spice-devel] " Dave Airlie
2015-05-28 14:10 ` Frediano Ziglio
2015-05-29 5:48 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9tz0+OEhU=JV4fNgy3ruGxemWzHkRovEmnPzdbGGX+uivw@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fziglio@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).