From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51994C433FE for ; Fri, 11 Dec 2020 04:49:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11B7123E54 for ; Fri, 11 Dec 2020 04:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395410AbgLKEsq (ORCPT ); Thu, 10 Dec 2020 23:48:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729717AbgLKEsW (ORCPT ); Thu, 10 Dec 2020 23:48:22 -0500 Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A29C0613CF for ; Thu, 10 Dec 2020 20:47:42 -0800 (PST) Received: by mail-vs1-xe42.google.com with SMTP id b23so4143713vsp.9 for ; Thu, 10 Dec 2020 20:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PCX++NcovFvmuiZAkYM9TG027ENLPf2SyX4C3UG/YXE=; b=UT8xK2wkBb30KnXY24s4al02jyc+2CbeUlsT5ixozhRHyoYvz3HB9+HXc3oL8dAEsQ FWIYNimr7jZMgzI/AIjks8hb17xxQI8WSv+7RmI/j08inNNwZyPka8WnqrhR+HrOG/sM 2pUAXovJaHfIJJzX9W9cRCMFxmZH8HDRNlIhc8iG/KUKr9FFmUtJ7hH0VSbj+zICsMW+ flO95g9tZWKWKBDGIiXy65M81Eio2IwQJi1vOaLf3MTIOmPN7vAr5MPv8VoNp7iQCbtg ATxuWG8aaAaJl6zuvqByRtJ9Zxd8ibzem6SLjP3c/w+JqD+YWfbJ3DxB7Hfk+sMHTdHY OGrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PCX++NcovFvmuiZAkYM9TG027ENLPf2SyX4C3UG/YXE=; b=Sby5v8OOcnzMn+5B/ZGK4AOJyOhbDXSIImztm2AhA26CFq2DZ894K/imt+IsCjyUQA oA8vck2Te0UBZEi8nUHy5NG140jCCFashMxgOSfeokc81lhYOx41jYMd3ixCRp1tbyig pG6wAKLgCzPetSoirEyEgiwjYs/HXBQ66fSUHjXkF24qq5Ntzm/S/Crq0Xpei1OpR3rY j9P7OK8dh+SPprj65xEA5sknH+v+++lfaneMgAN/SIYvLZ4jqoJloCONr6AthcG49QtY sW3Pqpu+y47gkmNeN6PZCWJkEJJEEUg92oQHRNTIUeXblJ5GaMr6geaSpeA7qzTmA5bT Tiww== X-Gm-Message-State: AOAM530sDOd2eeShzDUeqfzfU9oFpyAc6NSyzM5oM0K20mDtsW4KbGwu CsN0bJ4h9fh41+fdRh+eNLV9gw9fFqMSzYMvv4cw2g== X-Google-Smtp-Source: ABdhPJzfHH8iZuSy9IeM1QrBIrayI7MyRNM25MoLU8Lvcqnk22ZpJgt/nAsJc3SS58d4qVgH0ggK1geWx2PP7maNhiY= X-Received: by 2002:a67:6b46:: with SMTP id g67mr30004vsc.60.1607662061190; Thu, 10 Dec 2020 20:47:41 -0800 (PST) MIME-Version: 1.0 References: <20201210160521.3417426-1-gregkh@linuxfoundation.org> <20201210160521.3417426-6-gregkh@linuxfoundation.org> <20201210174548.GF107395@roeck-us.net> In-Reply-To: From: Badhri Jagan Sridharan Date: Thu, 10 Dec 2020 20:47:04 -0800 Message-ID: Subject: Re: [PATCH 5/5] USB: typec: tcpci: Add Bleed discharge to POWER_CONTROL definition To: Guenter Roeck Cc: Greg Kroah-Hartman , Heikki Krogerus , USB , LKML , Kyle Tso , Will McVicker Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, I have a patch ready to enable BLEED_DISCHARGE in tcpci code. I will send that in once you merge this patch to usb-next. Thanks, Badhri On Thu, Dec 10, 2020 at 10:56 AM Badhri Jagan Sridharan wrote: > > Hi Guenter, > > Yes I will send a follow up patch to update tcpci_maxim.c. > > Thanks, > Badhri > > > On Thu, Dec 10, 2020 at 9:45 AM Guenter Roeck wrote: > > > > On Thu, Dec 10, 2020 at 05:05:21PM +0100, Greg Kroah-Hartman wrote: > > > From: Badhri Jagan Sridharan > > > > > > "Table 4-19. POWER_CONTROL Register Definition" from tcpci spec > > > defines BIT(3) as the control bit for bleed discharge. > > > > > > Cc: Guenter Roeck > > > Cc: Heikki Krogerus > > > Cc: Kyle Tso > > > Signed-off-by: Badhri Jagan Sridharan > > > Signed-off-by: Will McVicker > > > Signed-off-by: Greg Kroah-Hartman > > > > Just wondering - is that going to be used in a follow-up commit ? > > > > Reviewed-by: Guenter Roeck > > > > Guenter > > > > > --- > > > drivers/usb/typec/tcpm/tcpci.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > > > index 116a69c85e38..c3c7d07d9b4e 100644 > > > --- a/drivers/usb/typec/tcpm/tcpci.h > > > +++ b/drivers/usb/typec/tcpm/tcpci.h > > > @@ -72,6 +72,7 @@ > > > > > > #define TCPC_POWER_CTRL 0x1c > > > #define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0) > > > +#define TCPC_POWER_CTRL_BLEED_DISCHARGE BIT(3) > > > #define TCPC_POWER_CTRL_AUTO_DISCHARGE BIT(4) > > > #define TCPC_FAST_ROLE_SWAP_EN BIT(7) > > > > > > -- > > > 2.29.2 > > >