From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E0CC43461 for ; Tue, 15 Sep 2020 19:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D9872078D for ; Tue, 15 Sep 2020 19:51:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e63A8UNi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727830AbgIOTvv (ORCPT ); Tue, 15 Sep 2020 15:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727832AbgIORKu (ORCPT ); Tue, 15 Sep 2020 13:10:50 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0486C061352 for ; Tue, 15 Sep 2020 09:58:23 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id j6so2307526vsg.8 for ; Tue, 15 Sep 2020 09:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VOZJDXmk4I7sBQkBNkbqiC999QN+5QxW+u+FQGNFV0A=; b=e63A8UNiaTNJGTTvmfggSIGCDE9Qr29ZZD6JllO168qvrxrxA3DUc1Nc0Aj64EKijO Txj7oJYWDhWJsEevrKKrmbyk5rdsc34U+SxKZ5QUiont8CyFcs3xM360KOTJ8ULfk9OY YEz49gC2k6VoBo85MxV1gabmZfVlicl5IiEV4VD6hFQOpw8BTV8zcn5j3akI0pQ9z30i BZWkl8m6eDs47dLDELpUGMKc+pKg3BL8DjV62J8OW6zpRnEzMT891r2wzsXZgvekwgbe VIdQ8pgY6bgxwrEU6dhpJJxf+mjUd5WpZdwwKWjuyQ3AIqQsBeVwjKEkpKm6wnlhTvx/ Z9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VOZJDXmk4I7sBQkBNkbqiC999QN+5QxW+u+FQGNFV0A=; b=jhFZ5fw3VMOKX5e9R1EnSdhHjWchCypAR8cjoJ57nsg5A6gS6v0Vrcb6gQ6WOCTBj7 fTRtFkiGjEmh5OKtNxh//VgFIPBMAAA08L9Q7z2KxJfqmv/8bvmpUJX2rYmuG76Ugh3X jAZHq7PCI7vSyZCqEcuXkTcI385hUEmWbv97alVzztuZOBSaaWzqAIeSHjVVmS9za/hM P+SmApGpLiprg0fPZJWTTYPEhXEcTwexUipk6eeMLuVlZ6jETlQXsuFqiRdx/hBG6DFB ZNJsCnrsBXmiD+GJGhuBcbSmPyMy0F4PVI4Xtppfk0Jp0ehHCXQr6UYcIXHI44Wub9IV Uxmw== X-Gm-Message-State: AOAM530PRG/4XDFc7kVAiWMhWS4tgrMPzpe+eaU/yvwVI9ejGXZbTo/D h9s5Y27XNkZw+02gSa0iiZJdFg7hX1vW0yCaDLq09w== X-Google-Smtp-Source: ABdhPJysYGKFNHZgqc12O3FvnUz67CSwz/ASv1bmn+v0ghVePdGTd1m+Au6nssZDFksIeluLQWCCUm7G4yZU6Dv7DF0= X-Received: by 2002:a67:ee1a:: with SMTP id f26mr2206910vsp.48.1600189102861; Tue, 15 Sep 2020 09:58:22 -0700 (PDT) MIME-Version: 1.0 References: <20200901025927.3596190-1-badhri@google.com> <20200915120927.GA1139641@kuha.fi.intel.com> In-Reply-To: <20200915120927.GA1139641@kuha.fi.intel.com> From: Badhri Jagan Sridharan Date: Tue, 15 Sep 2020 09:57:46 -0700 Message-ID: Subject: Re: [PATCH v6 00/14] TCPM support for FRS and AutoDischarge Disconnect To: Heikki Krogerus Cc: Guenter Roeck , Greg Kroah-Hartman , USB , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 5:09 AM Heikki Krogerus wrote: > > On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > > First of all apologies for mixing up the patch version as noted by > > Heikki and Greg. All of them were v1's but since I was manually adding > > the version numbers I mixed them up. Using the --reroll-count option > > now. Updating the patch version to v6 (highest version number in the > > previous patchset + 1) to avoid confusion. > > If this is v6, then where are v2 - v5? And what changed? Why didn't > you just make this v2? Frankly, I did not know how to fix the version numbers that I messed up in the original patchset. I had, by mistake, versioned the patch5 in the series v5 in the original patchset. So I thought I will consistently call them V6 and update all the patches to version v6 to avoid confusion. To confirm there is no v2-v5 for most of them. I have also mentioned the actual code changes and versioning changes in the change history for each patch. Hopefully that mitigates the confusion. Again apologies for messing up the versioning in the original patchset ! I have started to double check the patch version numbers before sending. Thanks, Badhri > > > > I also rebased on to off of the recent usb-next tip: > > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > > Which had the following changes causing merge conflict: > > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > > > Addressed comments from Heikki and Randy which have described in the > > individual commit's change history as well. > > > > Badhri Jagan Sridharan (14): > > usb: typec: tcpci: Add register definitions to tcpci > > usb: typec: tcpci: Add support when hidden tx registers are > > inaccessible > > usb: typec: tcpci: update ROLE_CONTROL for DRP > > usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference > > usb: typec: tcpci: Add set_vbus tcpci callback > > dt-bindings: usb: Maxim type-c controller device tree binding document > > usb: typec: tcpci_maxim: Chip level TCPC driver > > dt-bindings: connector: Add property to set initial current cap for > > FRS > > usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) > > usb: typec: tcpci: Implement callbacks for FRS > > usb: typec: tcpci_maxim: Add support for Sink FRS > > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support > > usb: typec: tcpci: Implement Auto discharge disconnect callbacks > > usb: typec: tcpci_maxim: Implemnent set_auto_vbus_discharge_threshold > > > > .../bindings/connector/usb-connector.txt | 128 ++++ > > .../devicetree/bindings/usb/maxim,tcpci.txt | 44 ++ > > drivers/usb/typec/tcpm/Kconfig | 5 + > > drivers/usb/typec/tcpm/Makefile | 13 +- > > drivers/usb/typec/tcpm/tcpci.c | 146 ++++- > > drivers/usb/typec/tcpm/tcpci.h | 43 ++ > > drivers/usb/typec/tcpm/tcpci_maxim.c | 564 ++++++++++++++++++ > > drivers/usb/typec/tcpm/tcpm.c | 291 ++++++++- > > include/dt-bindings/usb/pd.h | 10 + > > include/linux/usb/pd.h | 19 +- > > include/linux/usb/tcpm.h | 24 +- > > include/linux/usb/typec.h | 13 + > > 12 files changed, 1266 insertions(+), 34 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/connector/usb-connector.txt > > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.txt > > create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c > > > > > > base-commit: 5fedf0d295d3ef69fd85fdee4cb68fd3756b54c2 > > -- > > 2.28.0.402.g5ffc5be6b7-goog > > -- > heikki