From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488EAC4363C for ; Thu, 8 Oct 2020 06:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFC8321897 for ; Thu, 8 Oct 2020 06:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Uap0QwGe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727754AbgJHGdR (ORCPT ); Thu, 8 Oct 2020 02:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727437AbgJHGdR (ORCPT ); Thu, 8 Oct 2020 02:33:17 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B0BDC0613D3 for ; Wed, 7 Oct 2020 23:33:17 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id y1so17244uac.13 for ; Wed, 07 Oct 2020 23:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lluFhrYB3PEvXC7CXE2TI2ye7nUNlCyHKSdtn268RHs=; b=Uap0QwGe0bVpSyDIMIQCU35AKa7J9SWbQxq4Chum27zoWrYm0yc+uCdxq3Os950AOP x8NW+2M/bu9wAG5+y29o7oqGlRwUQFTjW+YXpMMCZbZN6475NOGMu3dGaQJ6rgQXkLnl UfemFBwE3dwvFmsX8J68Y7M1D4Ltf0Aw/uovjKO5q6u+P6YeqD1TeJFPR3MCW7vQqZ5e 7EnDOFQXrzf2NKBFkTcva8BC7cMT+Fy+xtWvX/6mggAlZJY+8K/TlWUrnFhKpEKQtYPs c6uzitFCHLPSXdoln1wx0HdD+WWfco61zakkolLzk7N217qF7k9/ZPPmO4GVfTGfx7Zs vR5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lluFhrYB3PEvXC7CXE2TI2ye7nUNlCyHKSdtn268RHs=; b=L1vcNTWk18PQioymsKg7d7d2kJQmjJFzl7exSsswJJwTQ51eQX9c7CfQIXI7oS7eKH KC/0M4FIuXaXBhe3TjdmdiGc9mocvgEH+uBFH4TMmBYKwNmEIBDcTK6y5Xr/k1vZNDLG OccqHEJ33bQp2poJMhsRjRgGZluIv2wW//Yw0u22WIDXbVRWOQ6rZuTA8Hc7f25Lzvsa +3y1IjrDlpx4ECiYKNVKL4X8nc+vD6A97C1oJUixOQAHKZXh12IHZvoTITz3TiagT6fC mqiwLTM+SxyMsV3vDXeggVcISYfS8jB1kyoFnIQm/TSyodl17rNwHpkX23o3wpLIbjwL yqOA== X-Gm-Message-State: AOAM530h6ChAngghFeWU8z3hT2fxRc8UVMFrxkgzfZC4uolG2Wq2YxfC Cs2pNXN8F2iKH8jXTrGGI8OhvxvxuDc1WRy3nN6X4Q== X-Google-Smtp-Source: ABdhPJx+JgKbahMVZ03FJfQUtlBPU0ys6TF84oj1TdEQhmAc5Ww45cf+EbI2/l+liFuUa4xS5QxDNygwT10mFfdKtB4= X-Received: by 2002:a9f:366e:: with SMTP id s43mr3791903uad.69.1602138796259; Wed, 07 Oct 2020 23:33:16 -0700 (PDT) MIME-Version: 1.0 References: <20200929024004.244992-1-badhri@google.com> <20200929024004.244992-3-badhri@google.com> <20201002133952.GA3411859@kroah.com> <20201002134041.GA3412330@kroah.com> <20201003155726.GC1509449@kroah.com> In-Reply-To: <20201003155726.GC1509449@kroah.com> From: Badhri Jagan Sridharan Date: Wed, 7 Oct 2020 23:32:39 -0700 Message-ID: Subject: Re: [PATCH v9 02/15] usb: typec: tcpci: Add set_vbus tcpci callback To: Greg Kroah-Hartman Cc: Guenter Roeck , Heikki Krogerus , Rob Herring , Lee Jones , Mark Brown , Maxime Ripard , Alexandre Belloni , Thierry Reding , Prashant Malani , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , USB Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 3, 2020 at 8:56 AM Greg Kroah-Hartman wrote: > > On Fri, Oct 02, 2020 at 09:08:00AM -0700, Badhri Jagan Sridharan wrote: > > Hi Greg, > > > > Yes I tested it on usb-next before sending it out. > > > > 630 | tcpci->tcpc.enable_frs = tcpci_enable_frs; > > > > In https://patchwork.kernel.org/project/linux-usb/list/?series=356837 > > i.e v9 version of this series, > > Patch 7 i.e. https://patchwork.kernel.org/patch/11804847/ is where the > > above line is added. > > > > I restested in combinations [1] [2] [3] [4]. All of them were clear > > cherry-picks. I didnt any merge conflicts. > > > > Maybe you are applying patches in a different order ? > > I didn't think so. Can you try applying the patches, in order, and > building after each one to see if you get the same error or not? Tried this as well. Not sure what I am doing differently. Also was manually looking for "tcpci_enable_frs" in the series and it's first occurrence is in: "[PATCH v9 07/15] usb: typec: tcpci: Implement callbacks for FRS". Just sent out the v10 after addressing a couple of comments from Rob Herring. Thanks, Badhri > > My usb-next branch is up to date with all of the recent patches. > > thanks, > > greg k-h