From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750838AbdE0Uf0 (ORCPT ); Sat, 27 May 2017 16:35:26 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35911 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743AbdE0UfZ (ORCPT ); Sat, 27 May 2017 16:35:25 -0400 MIME-Version: 1.0 In-Reply-To: <20170527054330.GB28555@kroah.com> References: <20170526204257.9062-1-Badhri@google.com> <20170527054330.GB28555@kroah.com> From: Badhri Jagan Sridharan Date: Sat, 27 May 2017 13:34:43 -0700 Message-ID: Subject: Re: [PATCHv4] usb: typec: Add a sysfs node to manage port type To: Greg Kroah-Hartman Cc: Heikki Krogerus , Guenter Roeck , Oliver Neukum , USB , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 10:43 PM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 01:42:57PM -0700, Badhri Jagan Sridharan wrote: >> User space applications in some cases have the need to enforce a >> specific port type(DFP/UFP/DRP). This change allows userspace to >> attempt setting the desired port type. Low level drivers can >> however reject the request if the specific port type is not supported. >> >> Signed-off-by: Badhri Jagan Sridharan >> --- >> Changelog since v1: >> - introduced a new variable port_type in struct typec_port to track >> the current port type instead of changing type member in >> typec_capability to address Heikki Krogerus comments. >> - changed the output format and strings that would be displayed as >> suggested by Heikki Krogerus. >> >> Changelog since v2: >> - introduced a new mutex lock to protect port_type for addressing >> the race conditions identified by Geunter Roeck >> - added typec_port_types_drp for printing port_type when cap->type >> is TYPE_PORT_DRP as suggested by Geunter Roeck >> - Power role swap and data role swaps would be rejected unless >> port port_type == TYPE_PORT_DRP >> - port_type_store would return immediately if the current port_type >> is same as the new port_type as suggested by Geunter Roeck >> >> Changelog since v3: >> - Moved as much as code outside port_type_lock as suggested by >> Geunter Roeck >> - Removed Change-Id line from commit message identified by >> Greg Kroah-Hartman > > Ok, this is how you write a changelog for a patch, very nice job! Thanks Greg :) > > greg k-h