From: Gwendal Grignou <gwendal@chromium.org>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 12/12] iio: cros_ec: flush as hwfifo attribute
Date: Sat, 28 Mar 2020 17:33:48 -0700 [thread overview]
Message-ID: <CAPUE2usGMaqieLW+L_Axou1GoVVOEnWDd6huAsqY21iKnMDPzQ@mail.gmail.com> (raw)
In-Reply-To: <20200328172256.583b483e@archlinux>
On Sat, Mar 28, 2020 at 10:22 AM Jonathan Cameron
<jic23@jic23.retrosnub.co.uk> wrote:
>
> On Fri, 27 Mar 2020 15:34:43 -0700
> Gwendal Grignou <gwendal@chromium.org> wrote:
>
> > Add buffer/hwfifo_flush. It is not part of the ABI, but it follows ST
> > and HID lead: Tells the sensor hub to send to the host all pending
> > sensor events.
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
>
> Unless I'm missing something there aren't any other drivers providing
> an explicit flush attribute.
The flush attribute comes from a requirement from Android to ask the
sensorhub to flush the samples still in its FIFO queue. (see
https://source.android.com/devices/sensors/hal-interface#flush_sensor)
It has been implemented in the ST Android HAL, which expects a
hw_fifo_flush attribute.:
https://github.com/STMicroelectronics/STMems_Android_Sensor_HAL_IIO/blob/STMems_Android_Sensor_HAL_IIO/src/utils.cpp#L31
But I misread kernel ST code; as you said, the request to flush
appends only when the buffer is enabled/disabled or the sensor
suspended, it is not exposed to user space.
For Bosh sensor : there is a patch that was proposed a while back:
"http://lkml.iu.edu/hypermail/linux/kernel/1504.3/03270.html", but it
never reached mainline.
For HID, the attribute is defined in the HID specification (31C) :
https://www.usb.org/sites/default/files/hutrr59_-_usages_for_wearables_0.pdf
but I could not find a publicly available proposed change request that uses it.
Anyhow, it was a mistake to put this patch in the current patch set. I
need it on chromebook for supporting Android, but it should be
discussed more widely to have it part of the ABI, or define a better
solution.
> The nearest equivalent is the flush
> callback which reads out stuff that is in a fifo to be read, but which
> hasn't yet reached a watermark to trigger normal readback.
>
> Can we do something similar here?
>
> If not this needs ABI documentation in Documentation/ABI/testing/...
> I'm not keen on it in becoming general ABI unless I'm missing a
> strong argument in favour of it.
>
> Jonathan
Thank you for your support,
Gwendal.
>
>
> > ---
> > No changes in v7.
> > New in v6.
> >
> > .../cros_ec_sensors/cros_ec_sensors_core.c | 28 +++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > index c831915ca7e56..aaf124a82e0e4 100644
> > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > @@ -113,6 +113,33 @@ static int cros_ec_sensor_set_ec_rate(struct cros_ec_sensors_core_state *st,
> > return ret;
> > }
> >
> > +static ssize_t cros_ec_sensors_flush(struct device *dev,
> > + struct device_attribute *attr,
> > + const char *buf, size_t len)
> > +{
> > + struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > + struct cros_ec_sensors_core_state *st = iio_priv(indio_dev);
> > + int ret = 0;
> > + bool flush;
> > +
> > + ret = strtobool(buf, &flush);
> > + if (ret < 0)
> > + return ret;
> > + if (!flush)
> > + return -EINVAL;
> > +
> > + mutex_lock(&st->cmd_lock);
> > + st->param.cmd = MOTIONSENSE_CMD_FIFO_FLUSH;
> > + ret = cros_ec_motion_send_host_cmd(st, 0);
> > + if (ret != 0)
> > + dev_warn(&indio_dev->dev, "Unable to flush sensor\n");
> > + mutex_unlock(&st->cmd_lock);
> > + return ret ? ret : len;
> > +}
> > +
> > +static IIO_DEVICE_ATTR(hwfifo_flush, 0644, NULL,
> > + cros_ec_sensors_flush, 0);
> > +
> > static ssize_t cros_ec_sensor_set_report_latency(struct device *dev,
> > struct device_attribute *attr,
> > const char *buf, size_t len)
> > @@ -175,6 +202,7 @@ static ssize_t hwfifo_watermark_max_show(struct device *dev,
> > static IIO_DEVICE_ATTR_RO(hwfifo_watermark_max, 0);
> >
> > const struct attribute *cros_ec_sensor_fifo_attributes[] = {
> > + &iio_dev_attr_hwfifo_flush.dev_attr.attr,
> > &iio_dev_attr_hwfifo_timeout.dev_attr.attr,
> > &iio_dev_attr_hwfifo_watermark_max.dev_attr.attr,
> > NULL,
>
next prev parent reply other threads:[~2020-03-29 0:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:34 [PATCH v7 00/12] Cros EC sensor hub FIFO support Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 01/12] platform: chrome: sensorhub: Add the number of sensors in sensorhub Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 02/12] platform: chrome: sensorhub: Add FIFO support Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 03/12] platform: chrome: sensorhub: Add code to spread timestmap Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 04/12] platform: chrome: sensorhub: Add median filter Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 05/12] iio: cros_ec: Move function description to .c file Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 06/12] iio: expose iio_device_set_clock Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 07/12] iio: cros_ec: Register to cros_ec_sensorhub when EC supports FIFO Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 08/12] iio: cros_ec: Remove pm function Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 09/12] iio: cros_ec: Expose hwfifo_timeout Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 10/12] iio: cros_ec: Report hwfifo_watermark_max Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 11/12] iio: cros_ec: Use Hertz as unit for sampling frequency Gwendal Grignou
2020-03-27 22:34 ` [PATCH v7 12/12] iio: cros_ec: flush as hwfifo attribute Gwendal Grignou
2020-03-28 9:14 ` Enric Balletbo i Serra
2020-03-28 17:24 ` Jonathan Cameron
2020-03-28 17:22 ` Jonathan Cameron
2020-03-29 0:33 ` Gwendal Grignou [this message]
2020-03-29 9:31 ` Jonathan Cameron
2020-03-29 11:22 ` Andy Shevchenko
2020-03-30 12:56 ` [PATCH v7 00/12] Cros EC sensor hub FIFO support Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPUE2usGMaqieLW+L_Axou1GoVVOEnWDd6huAsqY21iKnMDPzQ@mail.gmail.com \
--to=gwendal@chromium.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).